85a61ea6f0
bdev hotremove event is send directly to hotremove callback given during spdk_scsi_dev_construct() call. So any bdev hotremove might be promoted to whole SCSI device removal (like in vhost) wich will trigger LUN removal. But after returning from hotremove callback LUN and device might be still referenced (eg to register poller or by outstanding IO). Even worse: spdk_scsi_dev object is not dynamicaly allocated but returned from static array which mean there is no way to detect use-after-free error on spdk_scsi_dev by any tool. This might lead to using SCSI device that is freed or assigned to different device. To fix this: - always delete LUN using hotremove path - defer spdk_scsi_dev delete/removal after all LUNS are really deleted. Change-Id: I65598bf42cd507f620095dff5d32509a0424d060 Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-on: https://review.gerrithub.io/393674 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
155 lines
5.0 KiB
C
155 lines
5.0 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef SPDK_SCSI_INTERNAL_H
|
|
#define SPDK_SCSI_INTERNAL_H
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "spdk/bdev.h"
|
|
#include "spdk/scsi.h"
|
|
#include "spdk/scsi_spec.h"
|
|
#include "spdk/trace.h"
|
|
|
|
#include "spdk_internal/log.h"
|
|
|
|
enum {
|
|
SPDK_SCSI_TASK_UNKNOWN = -1,
|
|
SPDK_SCSI_TASK_COMPLETE,
|
|
SPDK_SCSI_TASK_PENDING,
|
|
};
|
|
|
|
struct spdk_scsi_port {
|
|
uint8_t is_used;
|
|
uint64_t id;
|
|
uint16_t index;
|
|
char name[SPDK_SCSI_PORT_MAX_NAME_LENGTH];
|
|
};
|
|
|
|
struct spdk_scsi_dev {
|
|
int id;
|
|
int is_allocated;
|
|
bool removed;
|
|
|
|
char name[SPDK_SCSI_DEV_MAX_NAME + 1];
|
|
|
|
struct spdk_scsi_lun *lun[SPDK_SCSI_DEV_MAX_LUN];
|
|
|
|
int num_ports;
|
|
struct spdk_scsi_port port[SPDK_SCSI_DEV_MAX_PORTS];
|
|
|
|
uint8_t protocol_id;
|
|
};
|
|
|
|
struct spdk_scsi_lun {
|
|
/** LUN id for this logical unit. */
|
|
int id;
|
|
|
|
/** Pointer to the SCSI device containing this LUN. */
|
|
struct spdk_scsi_dev *dev;
|
|
|
|
/** The bdev associated with this LUN. */
|
|
struct spdk_bdev *bdev;
|
|
|
|
/** Descriptor for opened block device. */
|
|
struct spdk_bdev_desc *bdev_desc;
|
|
|
|
/** I/O channel for the bdev associated with this LUN. */
|
|
struct spdk_io_channel *io_channel;
|
|
|
|
/** Thread ID for the thread that allocated the I/O channel for this
|
|
* LUN. All I/O to this LUN must be performed from this thread.
|
|
*/
|
|
pthread_t thread_id;
|
|
|
|
/** The reference number for this LUN, thus we can correctly free the io_channel */
|
|
uint32_t ref;
|
|
|
|
/** Poller to release the resource of the lun when it is hot removed */
|
|
struct spdk_poller *hotplug_poller;
|
|
|
|
/** The LUN is removed */
|
|
bool removed;
|
|
|
|
/** Callback to be fired when LUN removal is first triggered. */
|
|
void (*hotremove_cb)(const struct spdk_scsi_lun *lun, void *arg);
|
|
|
|
/** Argument for hotremove_cb */
|
|
void *hotremove_ctx;
|
|
|
|
TAILQ_HEAD(tasks, spdk_scsi_task) tasks; /* pending tasks */
|
|
};
|
|
|
|
struct spdk_lun_db_entry {
|
|
struct spdk_scsi_lun *lun;
|
|
struct spdk_lun_db_entry *next;
|
|
};
|
|
|
|
extern struct spdk_lun_db_entry *spdk_scsi_lun_list_head;
|
|
|
|
/* This typedef exists to work around an astyle 2.05 bug.
|
|
* Remove it when astyle is fixed.
|
|
*/
|
|
typedef struct spdk_scsi_lun _spdk_scsi_lun;
|
|
|
|
_spdk_scsi_lun *spdk_scsi_lun_construct(struct spdk_bdev *bdev,
|
|
void (*hotremove_cb)(const struct spdk_scsi_lun *, void *),
|
|
void *hotremove_ctx);
|
|
void spdk_scsi_lun_destruct(struct spdk_scsi_lun *lun);
|
|
|
|
void spdk_scsi_lun_execute_task(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task);
|
|
int spdk_scsi_lun_task_mgmt_execute(struct spdk_scsi_task *task, enum spdk_scsi_task_func func);
|
|
void spdk_scsi_lun_complete_task(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task);
|
|
void spdk_scsi_lun_complete_mgmt_task(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task);
|
|
int spdk_scsi_lun_allocate_io_channel(struct spdk_scsi_lun *lun);
|
|
void spdk_scsi_lun_free_io_channel(struct spdk_scsi_lun *lun);
|
|
bool spdk_scsi_lun_has_pending_tasks(const struct spdk_scsi_lun *lun);
|
|
|
|
struct spdk_scsi_dev *spdk_scsi_dev_get_list(void);
|
|
|
|
int spdk_scsi_port_construct(struct spdk_scsi_port *port, uint64_t id,
|
|
uint16_t index, const char *name);
|
|
void spdk_scsi_port_destruct(struct spdk_scsi_port *port);
|
|
|
|
int spdk_bdev_scsi_execute(struct spdk_scsi_task *task);
|
|
int spdk_bdev_scsi_reset(struct spdk_scsi_task *task);
|
|
|
|
struct spdk_scsi_globals {
|
|
pthread_mutex_t mutex;
|
|
};
|
|
|
|
extern struct spdk_scsi_globals g_spdk_scsi;
|
|
|
|
#endif /* SPDK_SCSI_INTERNAL_H */
|