Jim Harris f01146ae48 blob: use uint64_t for unmap and write_zeroes lba count ... Previous patches (5363eb3c) tried to work around the 32-bit unmap and write_zeroes LBA counts by breaking up larger operations into smaller chunks of max size UINT32_MAX lba chunks. But some SSDs may just ignore unmap operations that are not aligned to full physical block boundaries - and a UINT32_MAX lba unmap on a 512B logical / 4KiB physical SSD would not be aligned. If the SSD decided to ignore the unmap/deallocate (which it is allowed to do according to NVMe spec), we could end up with not unmapping *any* blocks. Probably SSDs should always be trying hard to unmap as many blocks as possible, but let's not try to depend on that in blobstore. So one option would be to break them into chunks close to UINT32_MAX which are still aligned to 4KiB boundaries. But the better fix is to just change the unmap and write_zeroes APIs to take 64-bit arguments, and then we can avoid the chunking altogether. Fixes issue #2190. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I23998e493a764d466927c3520c7a8c7f943000a6 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9737 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>		2021-10-14 08:17:16 +00:00
..
accel	lib/idxd: only select idxd device that are on the same socket	2021-10-07 09:26:50 +00:00
bdev	bdev/nvme: Use cb_arg of for_each_channel() to pass result of reset	2021-10-14 08:16:32 +00:00
blob	blob: use uint64_t for unmap and write_zeroes lba count	2021-10-14 08:17:16 +00:00
blobfs	blobfs: check return value of strdup in blobfs_fuse_start()	2021-06-16 08:53:21 +00:00
env_dpdk	so_ver: increase all major versions	2021-02-05 14:43:47 +00:00
event	nvmf: Correct the error path of transport creation.	2021-09-08 08:08:41 +00:00
scheduler	scheduler_dynamic: prioritize g_main_lcore during _find_optimal_core	2021-10-12 09:10:32 +00:00
sock	sock/posix: move fd creation to a separated function	2021-09-22 07:00:28 +00:00
Makefile	scheduler: create public API and subsystem for scheduler/governor	2021-09-07 07:33:03 +00:00