numam-spdk
Go to file
Daniel Verkamp 8af4b6c40f nvmf: fix potential use-after-free in hot remove
The subsystem->ns array may be resized with realloc(), so old ns
pointers can become invalid.

To fix this, allocate each ns as a separate object, and change the
subsystem->ns[] array to point to the namespaces rather than containing
them.

Change-Id: I873502fa90cf840e4eaa9b1abd94a95afe0f737f
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/399726
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-02-16 13:06:11 -05:00
app build: add @: to remaining 'all' targets 2018-02-14 17:38:25 -05:00
build/lib build: consolidate library outputs in build/lib 2016-11-17 13:15:09 -07:00
doc build/doc: add dependencies to 'output' rule 2018-02-15 11:10:55 -05:00
dpdk@6ece49ad5a dpdk: switch DPDK submodule to spdk-17.11 branch 2017-11-20 16:47:54 -05:00
dpdkbuild build: add 'make install' rule 2017-11-27 17:58:02 -05:00
etc/spdk iscsi: remove idle connection handling 2018-01-22 23:22:17 -05:00
examples build: add @: to remaining 'all' targets 2018-02-14 17:38:25 -05:00
include blob: convert spdk_bs_opts comments to Doxygen format 2018-02-16 11:49:47 -05:00
lib nvmf: fix potential use-after-free in hot remove 2018-02-16 13:06:11 -05:00
mk build: add @: to remaining 'all' targets 2018-02-14 17:38:25 -05:00
scripts iscsi&rpc: Add new initiator information to an existing initiator group 2018-02-15 11:28:19 -05:00
test nvmf: fix potential use-after-free in hot remove 2018-02-16 13:06:11 -05:00
.astylerc astyle: change "add-braces" to "j" for compatibility 2017-12-13 21:23:27 -05:00
.gitignore Makefile: try harder to use correct Python interpreter 2018-01-30 15:44:10 -05:00
.gitmodules build: add dpdk as a submodule 2017-05-17 09:49:27 -07:00
.travis.yml travis: move git submodule update to run first 2017-09-27 17:55:23 -04:00
autobuild.sh build: add top-level cc_version and cxx_version Makefile targets 2018-02-12 17:48:48 -05:00
autopackage.sh autopackage: avoid timezone issues with git archive 2017-06-02 12:04:44 -04:00
autorun_post.py pep8: re-enable E302 (2 blank lines between functions) 2018-02-15 11:10:41 -05:00
autorun.sh autorun: make config setup common to all scripts 2017-05-02 17:11:46 -07:00
autotest.sh autotest.sh: enable vhost migration test 2018-02-14 15:36:06 -05:00
CHANGELOG.md jsonrpc: allow send_buf to grow as needed 2018-02-15 11:03:54 -05:00
CONFIG build: add 'make install' rule 2017-11-27 17:58:02 -05:00
configure Makefile: try harder to use correct Python interpreter 2018-01-30 15:44:10 -05:00
CONTRIBUTING.md Add CONTRIBUTING.md 2017-09-05 13:25:45 -04:00
LICENSE Remove year from copyright headers. 2016-01-28 08:54:18 -07:00
Makefile build: add top-level cc_version and cxx_version Makefile targets 2018-02-12 17:48:48 -05:00
README.md doc: add the example to configure different memory size 2017-11-14 12:47:25 -05:00
unittest.sh test: add spdk_sock unit tests 2018-02-12 12:30:39 -05:00

Storage Performance Development Kit

Build Status

The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for writing high performance, scalable, user-mode storage applications. It achieves high performance by moving all of the necessary drivers into userspace and operating in a polled mode instead of relying on interrupts, which avoids kernel context switches and eliminates interrupt handling overhead.

The development kit currently includes:

In this readme:

Documentation

Doxygen API documentation is available, as well as a Porting Guide for porting SPDK to different frameworks and operating systems.

Source Code

git clone https://github.com/spdk/spdk
cd spdk
git submodule update --init

Prerequisites

The dependencies can be installed automatically by scripts/pkgdep.sh.

./scripts/pkgdep.sh

Build

Linux:

./configure
make

FreeBSD: Note: Make sure you have the matching kernel source in /usr/src/ and also note that CONFIG_COVERAGE option is not available right now for FreeBSD builds.

./configure
gmake

Unit Tests

./unittest.sh

You will see several error messages when running the unit tests, but they are part of the test suite. The final message at the end of the script indicates success or failure.

Vagrant

A Vagrant setup is also provided to create a Linux VM with a virtual NVMe controller to get up and running quickly. Currently this has only been tested on MacOS and Ubuntu 16.04.2 LTS with the VirtualBox provider. The VirtualBox Extension Pack must also be installed in order to get the required NVMe support.

Details on the Vagrant setup can be found in the SPDK Vagrant documentation.

Advanced Build Options

Optional components and other build-time configuration are controlled by settings in two Makefile fragments in the root of the repository. CONFIG contains the base settings. Running the configure script generates a new file, CONFIG.local, that contains overrides to the base CONFIG file. For advanced configuration, there are a number of additional options to configure that may be used, or CONFIG.local can simply be created and edited by hand. A description of all possible options is located in CONFIG.

Boolean (on/off) options are configured with a 'y' (yes) or 'n' (no). For example, this line of CONFIG controls whether the optional RDMA (libibverbs) support is enabled:

CONFIG_RDMA?=n

To enable RDMA, this line may be added to CONFIG.local with a 'y' instead of 'n'. For the majority of options this can be done using the configure script. For example:

./configure --with-rdma

Additionally, CONFIG options may also be overrriden on the make command line:

make CONFIG_RDMA=y

Users may wish to use a version of DPDK different from the submodule included in the SPDK repository. To specify an alternate DPDK installation, run configure with the --with-dpdk option. For example:

Linux:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-linuxapp-gcc
make

FreeBSD:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-bsdapp-clang
gmake

The options specified on the make command line take precedence over the default values in CONFIG and CONFIG.local. This can be useful if you, for example, generate a CONFIG.local using the configure script and then have one or two options (i.e. debug builds) that you wish to turn on and off frequently.

Hugepages and Device Binding

Before running an SPDK application, some hugepages must be allocated and any NVMe and I/OAT devices must be unbound from the native kernel drivers. SPDK includes a script to automate this process on both Linux and FreeBSD. This script should be run as root.

sudo scripts/setup.sh

Users may wish to configure a specific memory size. Below is an example of configuring 8192MB memory.

sudo HUGEMEM=8192 scripts/setup.sh

Example Code

Example code is located in the examples directory. The examples are compiled automatically as part of the build process. Simply call any of the examples with no arguments to see the help output. You'll likely need to run the examples as a privileged user (root) unless you've done additional configuration to grant your user permission to allocate huge pages and map devices through vfio.

Contributing

For additional details on how to get more involved in the community, including contributing code and participating in discussions and other activiites, please refer to spdk.io