c4d4800a46
Make sure we don't crash or do any other bad memory accesses when we fail to connect to a discovery controller. Change-Id: I7c3e25899bc78f4beff9ad017612bacf286d52c7 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/474153 Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
91 lines
2.5 KiB
Bash
Executable File
91 lines
2.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
testdir=$(readlink -f $(dirname $0))
|
|
rootdir=$(readlink -f $testdir/../../..)
|
|
source $rootdir/test/common/autotest_common.sh
|
|
source $rootdir/test/nvmf/common.sh
|
|
|
|
PLUGIN_DIR=$rootdir/examples/nvme/fio_plugin
|
|
|
|
MALLOC_BDEV_SIZE=64
|
|
MALLOC_BLOCK_SIZE=512
|
|
|
|
rpc_py="$rootdir/scripts/rpc.py"
|
|
|
|
function disconnect_init()
|
|
{
|
|
nvmfappstart "-m 0xF0"
|
|
|
|
$rpc_py bdev_malloc_create $MALLOC_BDEV_SIZE $MALLOC_BLOCK_SIZE -b Malloc0
|
|
|
|
$rpc_py nvmf_create_transport $NVMF_TRANSPORT_OPTS
|
|
$rpc_py nvmf_subsystem_create nqn.2016-06.io.spdk:cnode1 -a -s SPDK00000000000001
|
|
|
|
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode1 Malloc0
|
|
$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode1 -t $TEST_TRANSPORT -a $1 -s $NVMF_PORT
|
|
}
|
|
|
|
# There is an intermittent error relating to this test and Soft-RoCE. for now, just
|
|
# skip this test if we are using rxe. TODO: get to the bottom of GitHub issue #1043
|
|
if check_ip_is_soft_roce $NVMF_FIRST_TARGET_IP; then
|
|
echo "Using software RDMA, skipping the target disconnect tests."
|
|
exit 0
|
|
fi
|
|
|
|
timing_enter target_disconnect
|
|
|
|
nvmftestinit
|
|
|
|
# Test to make sure we don't segfault or access null pointers when we try to connect to
|
|
# a discovery controller that doesn't exist yet.
|
|
set +e
|
|
$rootdir/examples/nvme/reconnect/reconnect -q 32 -o 4096 -w randrw -M 50 -t 10 -c 0xF \
|
|
-r "trtype:$TEST_TRANSPORT adrfam:IPv4 traddr:$NVMF_FIRST_TARGET_IP trsvcid:$NVMF_PORT"
|
|
# If the program crashes, the high bit of $? will be set so we will get a value in the hundreds.
|
|
# But if the reconnect code detects errors and exits normally it will return 1.
|
|
if [ $? != 1 ]; then
|
|
set -e
|
|
exit 1
|
|
fi
|
|
set -e
|
|
|
|
disconnect_init $NVMF_FIRST_TARGET_IP
|
|
|
|
# If perf doesn't shut down, this test will time out.
|
|
$rootdir/examples/nvme/reconnect/reconnect -q 32 -o 4096 -w randrw -M 50 -t 10 -c 0xF \
|
|
-r "trtype:$TEST_TRANSPORT adrfam:IPv4 traddr:$NVMF_FIRST_TARGET_IP trsvcid:$NVMF_PORT" &
|
|
reconnectpid=$!
|
|
|
|
sleep 2
|
|
kill -9 $nvmfpid
|
|
|
|
sleep 2
|
|
disconnect_init $NVMF_FIRST_TARGET_IP
|
|
|
|
wait $reconnectpid
|
|
sync
|
|
|
|
if [ -n "$NVMF_SECOND_TARGET_IP" ]; then
|
|
timing_enter failover_test
|
|
|
|
$rootdir/examples/nvme/reconnect/reconnect -q 32 -o 4096 -w randrw -M 50 -t 10 -c 0xF \
|
|
-r "trtype:$TEST_TRANSPORT adrfam:IPv4 traddr:$NVMF_FIRST_TARGET_IP trsvcid:$NVMF_PORT alt_traddr:$NVMF_SECOND_TARGET_IP" &
|
|
reconnectpid=$!
|
|
|
|
sleep 2
|
|
kill -9 $nvmfpid
|
|
|
|
sleep 2
|
|
disconnect_init $NVMF_SECOND_TARGET_IP
|
|
|
|
wait $reconnectpid
|
|
sync
|
|
|
|
timing_exit failover_test
|
|
fi
|
|
|
|
trap - SIGINT SIGTERM EXIT
|
|
rm -f $PLUGIN_DIR/example_config_extended.fio || true
|
|
nvmftestfini
|
|
timing_exit target_disconnect
|