numam-spdk
Go to file
Shuhei Matsumoto 8f64724e86 iscsi: Use not malloc'ed but fixed size string for portal IP address
Using malloc'ed string for string in iSCSI target has caused
scan-build error.

Define maximum IP address of portal to be 256 and use fixed size string
whose size is 257 for spdk_iscsi_portal_grp::host.

This change will reduce the potential malloc failure.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Iceeae94e250ea426f72ff72355a213606308da51
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459708
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2019-07-01 05:03:07 +00:00
.githooks test: use SKIP_DPDK_BUILD in pre-push githook 2018-07-14 02:20:30 +00:00
app app/iscsi_tgt: Optional VMD enumeration 2019-07-01 03:53:06 +00:00
build/lib
doc doc/vpp: update VPP integration docs 2019-06-27 08:23:08 +00:00
dpdk@cb4240afc3 dpdk: update submodule commit id 2019-06-04 23:32:34 +00:00
dpdkbuild dpdk: build and link QAT for both crypto and compression 2019-06-05 19:07:32 +00:00
etc/spdk nvmf/tcp: Use the success optimization by default 2019-06-26 06:24:03 +00:00
examples examples/bdev/hello_world: Optional VMD enumeration 2019-07-01 03:53:06 +00:00
go go: empty Go package 2018-06-28 18:15:51 +00:00
include blobfs: make internal asynchronous APIs as public APIs 2019-06-28 09:50:50 +00:00
intel-ipsec-mb@489ec6082a ipsec: move to version 0.52 2019-04-24 22:49:11 +00:00
ipsecbuild Makefile: Add possibility to uninstall spdk. 2019-05-16 20:56:18 +00:00
isa-l@09e787231b spdk: Add ISA-L support with related crc32 function 2019-01-29 08:31:00 +00:00
isalbuild Makefile: Add possibility to uninstall spdk. 2019-05-16 20:56:18 +00:00
lib iscsi: Use not malloc'ed but fixed size string for portal IP address 2019-07-01 05:03:07 +00:00
mk net/vpp: allow to compile with vpp 2019-06-27 08:23:08 +00:00
ocf@515137f25e ocf: Update ocf submodule to version OCF v19.3.2 2019-06-07 18:18:42 +00:00
pkg version: 19.07 pre 2019-04-30 21:30:18 +00:00
scripts perf/nvmf: add link files into zipped SPDK source codes 2019-06-28 05:36:37 +00:00
shared_lib Makefile: Add possibility to uninstall spdk. 2019-05-16 20:56:18 +00:00
test iscsi: Use not malloc'ed but fixed size string for portal IP address 2019-07-01 05:03:07 +00:00
.astylerc astyle: change "add-braces" to "j" for compatibility 2017-12-13 21:23:27 -05:00
.gitignore makefile: Add cc.flags.mk to .gitignore list 2019-05-15 18:44:59 +00:00
.gitmodules ocf: add ocf submodule 2019-02-27 17:26:51 +00:00
.travis.yml .travis.yml: remove IRC notifications 2019-06-05 20:31:48 +00:00
autobuild.sh Makefile: Add possibility to uninstall spdk. 2019-05-16 20:56:18 +00:00
autopackage.sh autotest: don't source the configuration file in every test script 2019-05-10 22:08:13 +00:00
autorun_post.py Check file permissions in the check_format script 2018-10-04 23:08:12 +00:00
autorun.sh autorun.sh: print test configuration at the beginning 2019-05-10 22:08:13 +00:00
autotest.sh net/vpp: include VPP into iSCSI test scripts 2019-06-27 08:23:08 +00:00
CHANGELOG.md blobfs: make internal asynchronous APIs as public APIs 2019-06-28 09:50:50 +00:00
CONFIG configure: use the external rte_vhost lib by default 2019-06-11 01:14:45 +00:00
configure net/vpp: allow to compile with vpp 2019-06-27 08:23:08 +00:00
CONTRIBUTING.md
ISSUE_TEMPLATE.md github: Add issue tracker template 2018-04-19 13:50:08 -04:00
LICENSE
Makefile build: make dpdk depend on ipsec 2019-05-30 14:38:51 +00:00
README.md doc: update doc with instructions for building shared lib 2018-10-26 20:41:24 +00:00

Storage Performance Development Kit

Build Status

The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for writing high performance, scalable, user-mode storage applications. It achieves high performance by moving all of the necessary drivers into userspace and operating in a polled mode instead of relying on interrupts, which avoids kernel context switches and eliminates interrupt handling overhead.

The development kit currently includes:

In this readme:

Documentation

Doxygen API documentation is available, as well as a Porting Guide for porting SPDK to different frameworks and operating systems.

Source Code

git clone https://github.com/spdk/spdk
cd spdk
git submodule update --init

Prerequisites

The dependencies can be installed automatically by scripts/pkgdep.sh.

./scripts/pkgdep.sh

Build

Linux:

./configure
make

FreeBSD: Note: Make sure you have the matching kernel source in /usr/src/ and also note that CONFIG_COVERAGE option is not available right now for FreeBSD builds.

./configure
gmake

Unit Tests

./test/unit/unittest.sh

You will see several error messages when running the unit tests, but they are part of the test suite. The final message at the end of the script indicates success or failure.

Vagrant

A Vagrant setup is also provided to create a Linux VM with a virtual NVMe controller to get up and running quickly. Currently this has only been tested on MacOS and Ubuntu 16.04.2 LTS with the VirtualBox provider. The VirtualBox Extension Pack must also be installed in order to get the required NVMe support.

Details on the Vagrant setup can be found in the SPDK Vagrant documentation.

Advanced Build Options

Optional components and other build-time configuration are controlled by settings in the Makefile configuration file in the root of the repository. CONFIG contains the base settings for the configure script. This script generates a new file, mk/config.mk, that contains final build settings. For advanced configuration, there are a number of additional options to configure that may be used, or mk/config.mk can simply be created and edited by hand. A description of all possible options is located in CONFIG.

Boolean (on/off) options are configured with a 'y' (yes) or 'n' (no). For example, this line of CONFIG controls whether the optional RDMA (libibverbs) support is enabled:

CONFIG_RDMA?=n

To enable RDMA, this line may be added to mk/config.mk with a 'y' instead of 'n'. For the majority of options this can be done using the configure script. For example:

./configure --with-rdma

Additionally, CONFIG options may also be overridden on the make command line:

make CONFIG_RDMA=y

Users may wish to use a version of DPDK different from the submodule included in the SPDK repository. Note, this includes the ability to build not only from DPDK sources, but also just with the includes and libraries installed via the dpdk and dpdk-devel packages. To specify an alternate DPDK installation, run configure with the --with-dpdk option. For example:

Linux:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-linuxapp-gcc
make

FreeBSD:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-bsdapp-clang
gmake

The options specified on the make command line take precedence over the values in mk/config.mk. This can be useful if you, for example, generate a mk/config.mk using the configure script and then have one or two options (i.e. debug builds) that you wish to turn on and off frequently.

Shared libraries

By default, the build of the SPDK yields static libraries against which the SPDK applications and examples are linked. Configure option --with-shared provides the ability to produce SPDK shared libraries, in addition to the default static ones. Use of this flag also results in the SPDK executables linked to the shared versions of libraries. SPDK shared libraries by default, are located in ./build/lib. This includes the single SPDK shared lib encompassing all of the SPDK static libs (libspdk.so) as well as individual SPDK shared libs corresponding to each of the SPDK static ones.

In order to start a SPDK app linked with SPDK shared libraries, make sure to do the following steps:

  • run ldconfig specifying the directory containing SPDK shared libraries
  • provide proper LD_LIBRARY_PATH

Linux:

./configure --with-shared
make
ldconfig -v -n ./build/lib
LD_LIBRARY_PATH=./build/lib/ ./app/spdk_tgt/spdk_tgt

Hugepages and Device Binding

Before running an SPDK application, some hugepages must be allocated and any NVMe and I/OAT devices must be unbound from the native kernel drivers. SPDK includes a script to automate this process on both Linux and FreeBSD. This script should be run as root.

sudo scripts/setup.sh

Users may wish to configure a specific memory size. Below is an example of configuring 8192MB memory.

sudo HUGEMEM=8192 scripts/setup.sh

Example Code

Example code is located in the examples directory. The examples are compiled automatically as part of the build process. Simply call any of the examples with no arguments to see the help output. You'll likely need to run the examples as a privileged user (root) unless you've done additional configuration to grant your user permission to allocate huge pages and map devices through vfio.

Contributing

For additional details on how to get more involved in the community, including contributing code and participating in discussions and other activities, please refer to spdk.io