8fcb8b966d
- Use consistent cache line size units in KiB across RPC calls and config files. The KiB units are much easier to use then the bytes units and are more human readable. - Properly handle cache start when cache line size is incorrect. - Add test to check if cache line size value is reported correctly. - Add cache line size info to JSON RPC documentation. Fixes #1858 Signed-off-by: Rafal Stefanowski <rafal.stefanowski@intel.com> Change-Id: Iec9ede85f6884b64605d2d112947b3f175cbd938 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7614 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
57 lines
1.8 KiB
Bash
Executable File
57 lines
1.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
curdir=$(dirname $(readlink -f "${BASH_SOURCE[0]}"))
|
|
rootdir=$(readlink -f $curdir/../../..)
|
|
source $rootdir/test/common/autotest_common.sh
|
|
|
|
rpc_py=$rootdir/scripts/rpc.py
|
|
cache_line_sizes=(4 8 16 32 64)
|
|
cache_modes=(wt wb pt wa wi wo)
|
|
|
|
$SPDK_BIN_DIR/iscsi_tgt &
|
|
spdk_pid=$!
|
|
|
|
waitforlisten $spdk_pid
|
|
|
|
# Create OCF cache with different cache line sizes
|
|
for cache_line_size in "${cache_line_sizes[@]}"; do
|
|
$rpc_py bdev_malloc_create 101 512 -b Malloc0
|
|
$rpc_py bdev_malloc_create 101 512 -b Malloc1
|
|
$rpc_py bdev_ocf_create Cache0 wt Malloc0 Malloc1 --cache-line-size $cache_line_size
|
|
|
|
$rpc_py bdev_ocf_get_bdevs | jq -e \
|
|
'.[0] | .started and .cache.attached and .core.attached'
|
|
|
|
# Check if cache line size values are reported correctly
|
|
$rpc_py bdev_get_bdevs -b Cache0 | jq -e \
|
|
".[0] | .driver_specific.cache_line_size == $cache_line_size"
|
|
$rpc_py save_subsystem_config -n bdev | jq -e \
|
|
".config | .[] | select(.method == \"bdev_ocf_create\") | .params.cache_line_size == $cache_line_size"
|
|
|
|
$rpc_py bdev_ocf_delete Cache0
|
|
$rpc_py bdev_malloc_delete Malloc0
|
|
$rpc_py bdev_malloc_delete Malloc1
|
|
done
|
|
|
|
# Prepare OCF cache for dynamic configuration switching
|
|
$rpc_py bdev_malloc_create 101 512 -b Malloc0
|
|
$rpc_py bdev_malloc_create 101 512 -b Malloc1
|
|
$rpc_py bdev_ocf_create Cache0 wt Malloc0 Malloc1
|
|
|
|
$rpc_py bdev_ocf_get_bdevs | jq -e \
|
|
'.[0] | .started and .cache.attached and .core.attached'
|
|
|
|
# Change cache mode
|
|
for cache_mode in "${cache_modes[@]}"; do
|
|
$rpc_py bdev_ocf_set_cache_mode Cache0 $cache_mode
|
|
|
|
# Check if cache mode values are reported correctly
|
|
$rpc_py bdev_get_bdevs -b Cache0 | jq -e \
|
|
".[0] | .driver_specific.mode == \"$cache_mode\""
|
|
$rpc_py save_subsystem_config -n bdev | jq -e \
|
|
".config | .[] | select(.method == \"bdev_ocf_create\") | .params.mode == \"$cache_mode\""
|
|
done
|
|
|
|
trap - SIGINT SIGTERM EXIT
|
|
killprocess $spdk_pid
|