Darek Stojaczyk e8e46cb615 env_dpdk/pci: remove device detach callback ... You don't get notified when someone starts using your hooked device, so there's not much gain from knowing when someone stops. Remove that callback and also move DPDK device detach under the same lock which sets the pending_removal flag. This eliminates a data race window when hotremove notification could arrive after device was detached, but before it was scheduled to be removed. vmd and ioat nest the spdk_pci_device struct and abigail complains even though the parent structs only have forward declarations in public headers. Adding those two structs to the suppression list doesn't help though. Abidiff still complains about the pci device struct being changed, probably because ioat.h and vmd.h both include env.h. Abidiff suppresion list should eventually be split per-lib, but for now ignore struct spdk_pci_device changes globally. $ abidiff [...]/libspdk_ioat.so [...] 'struct spdk_pci_device at env.h:652:1' changed: type size changed from 1024 to 960 (in bits) 1 data member deletion: <SNIP> Change-Id: I9b113572c661f0e0786b6d625e16dc07fe77e778 Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2939 Community-CI: Mellanox Build Bot Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>		2020-07-23 20:48:47 +00:00
..
check_so_deps.sh	env_dpdk/pci: remove device detach callback	2020-07-23 20:48:47 +00:00