numam-spdk/lib/json/json_util.c
Seth Howell 7883a289ec json_util: fixed off by 1 error.
Also add tests to ensure against regressions on this fix.

Change-Id: Ic617f75f1865f17121896f7622290e64020bb2d6
Signed-off-by: Seth Howell <seth.howell@intel.com>
Reviewed-on: https://review.gerrithub.io/362275
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-05-30 23:55:36 -04:00

296 lines
6.1 KiB
C

/*-
* BSD LICENSE
*
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "json_internal.h"
size_t
spdk_json_val_len(const struct spdk_json_val *val)
{
if (val == NULL) {
return 0;
}
if (val->type == SPDK_JSON_VAL_ARRAY_BEGIN || val->type == SPDK_JSON_VAL_OBJECT_BEGIN) {
return val->len + 2;
}
return 1;
}
bool
spdk_json_strequal(const struct spdk_json_val *val, const char *str)
{
size_t len;
if (val->type != SPDK_JSON_VAL_STRING && val->type != SPDK_JSON_VAL_NAME) {
return false;
}
len = strlen(str);
if (val->len != len) {
return false;
}
return memcmp(val->start, str, len) == 0;
}
char *
spdk_json_strdup(const struct spdk_json_val *val)
{
size_t len;
char *s;
if (val->type != SPDK_JSON_VAL_STRING && val->type != SPDK_JSON_VAL_NAME) {
return NULL;
}
len = val->len;
if (memchr(val->start, '\0', len)) {
/* String contains embedded NUL, so it is not a valid C string. */
return NULL;
}
s = malloc(len + 1);
if (s == NULL) {
return s;
}
memcpy(s, val->start, len);
s[len] = '\0';
return s;
}
int
spdk_json_number_to_double(const struct spdk_json_val *val, double *num)
{
char buf[32];
char *end;
if (val->type != SPDK_JSON_VAL_NUMBER || val->len >= sizeof(buf)) {
*num = 0.0;
return -1;
}
memcpy(buf, val->start, val->len);
buf[val->len] = '\0';
errno = 0;
/* TODO: strtod() uses locale for decimal point (. is not guaranteed) */
*num = strtod(buf, &end);
if (*end != '\0' || errno != 0) {
return -1;
}
return 0;
}
int
spdk_json_number_to_int32(const struct spdk_json_val *val, int32_t *num)
{
double dbl;
if (spdk_json_number_to_double(val, &dbl)) {
return -1;
}
*num = (int32_t)dbl;
if (dbl != (double)*num) {
return -1;
}
return 0;
}
int
spdk_json_number_to_uint32(const struct spdk_json_val *val, uint32_t *num)
{
double dbl;
if (spdk_json_number_to_double(val, &dbl)) {
return -1;
}
if (dbl < 0) {
return -1;
}
*num = (uint32_t)dbl;
if (dbl != (double)*num) {
return -1;
}
return 0;
}
int
spdk_json_decode_object(const struct spdk_json_val *values,
const struct spdk_json_object_decoder *decoders, size_t num_decoders, void *out)
{
uint32_t i;
bool invalid = false;
size_t decidx;
bool *seen;
if (values == NULL || values->type != SPDK_JSON_VAL_OBJECT_BEGIN) {
return -1;
}
seen = calloc(sizeof(bool), num_decoders);
if (seen == NULL) {
return -1;
}
for (i = 0; i < values->len;) {
const struct spdk_json_val *name = &values[i + 1];
const struct spdk_json_val *v = &values[i + 2];
bool found = false;
for (decidx = 0; decidx < num_decoders; decidx++) {
const struct spdk_json_object_decoder *dec = &decoders[decidx];
if (spdk_json_strequal(name, dec->name)) {
void *field = (void *)((uintptr_t)out + dec->offset);
found = true;
if (seen[decidx]) {
/* duplicate field name */
invalid = true;
} else {
seen[decidx] = true;
if (dec->decode_func(v, field)) {
invalid = true;
/* keep going to fill out any other valid keys */
}
}
break;
}
}
if (!found) {
invalid = true;
}
i += 1 + spdk_json_val_len(v);
}
for (decidx = 0; decidx < num_decoders; decidx++) {
if (!decoders[decidx].optional && !seen[decidx]) {
/* required field is missing */
invalid = true;
break;
}
}
free(seen);
return invalid ? -1 : 0;
}
int
spdk_json_decode_array(const struct spdk_json_val *values, spdk_json_decode_fn decode_func,
void *out, size_t max_size, size_t *out_size, size_t stride)
{
uint32_t i;
char *field;
if (values == NULL || values->type != SPDK_JSON_VAL_ARRAY_BEGIN) {
return -1;
}
if (values->len > max_size) {
return -1;
}
*out_size = 0;
field = out;
for (i = 0; i < values->len;) {
const struct spdk_json_val *v = &values[i + 1];
if (decode_func(v, field)) {
return -1;
}
i += spdk_json_val_len(v);
field += stride;
(*out_size)++;
}
return 0;
}
int
spdk_json_decode_bool(const struct spdk_json_val *val, void *out)
{
bool *f = out;
if (val->type != SPDK_JSON_VAL_TRUE && val->type != SPDK_JSON_VAL_FALSE) {
return -1;
}
*f = val->type == SPDK_JSON_VAL_TRUE;
return 0;
}
int
spdk_json_decode_int32(const struct spdk_json_val *val, void *out)
{
int32_t *i = out;
return spdk_json_number_to_int32(val, i);
}
int
spdk_json_decode_uint32(const struct spdk_json_val *val, void *out)
{
uint32_t *i = out;
return spdk_json_number_to_uint32(val, i);
}
int
spdk_json_decode_string(const struct spdk_json_val *val, void *out)
{
char **s = out;
free(*s);
*s = spdk_json_strdup(val);
if (*s) {
return 0;
} else {
return -1;
}
}