f341e69a50
Using malloc'ed string for string in iSCSI target has caused scan-build error. Define maximum port number of portal to be 32 and use fixed size string whose size is 33 for spdk_iscsi_portal_grp::port. This change will reduce the potential malloc failure. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Ie1fcdbd45ce000a9c1c53761195697555b8d030a Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459709 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
88 lines
3.5 KiB
C
88 lines
3.5 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef SPDK_PORTAL_GRP_H
|
|
#define SPDK_PORTAL_GRP_H
|
|
|
|
#include "spdk/conf.h"
|
|
#include "spdk/cpuset.h"
|
|
|
|
#define MAX_PORTAL_ADDR 256
|
|
#define MAX_PORTAL_PORT 32
|
|
|
|
struct spdk_json_write_ctx;
|
|
|
|
struct spdk_iscsi_portal {
|
|
struct spdk_iscsi_portal_grp *group;
|
|
char host[MAX_PORTAL_ADDR + 1];
|
|
char port[MAX_PORTAL_PORT + 1];
|
|
struct spdk_sock *sock;
|
|
struct spdk_cpuset *cpumask;
|
|
struct spdk_poller *acceptor_poller;
|
|
TAILQ_ENTRY(spdk_iscsi_portal) per_pg_tailq;
|
|
TAILQ_ENTRY(spdk_iscsi_portal) g_tailq;
|
|
};
|
|
|
|
struct spdk_iscsi_portal_grp {
|
|
int ref;
|
|
int tag;
|
|
TAILQ_ENTRY(spdk_iscsi_portal_grp) tailq;
|
|
TAILQ_HEAD(, spdk_iscsi_portal) head;
|
|
};
|
|
|
|
/* SPDK iSCSI Portal Group management API */
|
|
|
|
struct spdk_iscsi_portal *spdk_iscsi_portal_create(const char *host, const char *port,
|
|
const char *cpumask);
|
|
void spdk_iscsi_portal_destroy(struct spdk_iscsi_portal *p);
|
|
|
|
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_create(int tag);
|
|
void spdk_iscsi_portal_grp_add_portal(struct spdk_iscsi_portal_grp *pg,
|
|
struct spdk_iscsi_portal *p);
|
|
void spdk_iscsi_portal_grp_destroy(struct spdk_iscsi_portal_grp *pg);
|
|
void spdk_iscsi_portal_grp_release(struct spdk_iscsi_portal_grp *pg);
|
|
int spdk_iscsi_parse_portal_grps(void);
|
|
void spdk_iscsi_portal_grps_destroy(void);
|
|
int spdk_iscsi_portal_grp_register(struct spdk_iscsi_portal_grp *pg);
|
|
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_unregister(int tag);
|
|
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_find_by_tag(int tag);
|
|
int spdk_iscsi_portal_grp_open(struct spdk_iscsi_portal_grp *pg);
|
|
|
|
void spdk_iscsi_portal_grp_close_all(void);
|
|
void spdk_iscsi_portal_grps_config_text(FILE *fp);
|
|
void spdk_iscsi_portal_grps_info_json(struct spdk_json_write_ctx *w);
|
|
void spdk_iscsi_portal_grps_config_json(struct spdk_json_write_ctx *w);
|
|
|
|
#endif /* SPDK_PORTAL_GRP_H */
|