47c4304d83
Passing cpu_mask hints that match only single core were usefull to prevent any accidents when doing round-robin in case of 'static' scheduler. In practice this is not required in case of 'static' scheduler, the threads will be spread out over all reactors anyway. This hinders other schedulers which try to respect the cpu_mask hints, as they would not move the thread to any reactor. Preventing bunching up less used threads on single reactor. Drawback of this patch is that poll group names will not match the cores they are on. Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Change-Id: I5fb308362dd045228ea9fcca24f988388854c054 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7028 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: <dongx.yi@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
63 lines
1.6 KiB
Bash
Executable File
63 lines
1.6 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
testdir=$(readlink -f "$(dirname "$0")")
|
|
rootdir=$(readlink -f "$testdir/../../")
|
|
|
|
source "$rootdir/test/common/autotest_common.sh"
|
|
source "$testdir/common.sh"
|
|
|
|
trap 'killprocess "$spdk_pid"' EXIT
|
|
|
|
thread_stats() {
|
|
local thread
|
|
local busy_threads=0
|
|
|
|
get_thread_stats
|
|
|
|
# Simply verify if threads stay idle
|
|
for thread in "${!thread_map[@]}"; do
|
|
if ((idle[thread] < busy[thread])); then
|
|
printf 'Waiting for %s to become idle\n' "${thread_map[thread]}"
|
|
((++busy_threads))
|
|
elif ((idle[thread] > busy[thread])); then
|
|
printf '%s is idle\n' "${thread_map[thread]}"
|
|
fi
|
|
done
|
|
|
|
((busy_threads == 0))
|
|
}
|
|
|
|
idle() {
|
|
local reactor_framework
|
|
local reactors thread
|
|
local cpusmask thread_cpumask
|
|
local threads
|
|
|
|
exec_under_dynamic_scheduler "${SPDK_APP[@]}" -m "$spdk_cpusmask" --main-core "$spdk_main_core"
|
|
|
|
# The expectation here is that when SPDK app is idle the following is true:
|
|
# - all threads are assigned to main lcore
|
|
# - threads are not being moved between lcores
|
|
|
|
xtrace_disable
|
|
while ((samples++ < 5)); do
|
|
cpusmask=0
|
|
reactor_framework=$(rpc_cmd framework_get_reactors | jq -r '.reactors[]')
|
|
threads=($(
|
|
jq -r "select(.lcore == $spdk_main_core) | .lw_threads[].name" <<< "$reactor_framework"
|
|
))
|
|
|
|
for thread in "${threads[@]}"; do
|
|
thread_cpumask=0x$(jq -r "select(.lcore == $spdk_main_core) | .lw_threads[] | select(.name == \"$thread\") | .cpumask" <<< "$reactor_framework")
|
|
((cpusmask |= thread_cpumask))
|
|
done
|
|
|
|
printf 'SPDK cpumask: %x Threads cpumask: %x\n' "$spdk_cpusmask" "$cpusmask"
|
|
thread_stats
|
|
done
|
|
|
|
xtrace_restore
|
|
}
|
|
|
|
idle
|