47dd5b4a35
DPDK rte_eal_firmware.c will use libarchive APIs when libarchive is installed on the system. SPDK doesn't currently account for this, so if the user has libarchive installed, DPDK will emit libarchive calls that don't get resolved during link phase for static builds. We've had a similar situation with libbsd for a long time, where we remove the associated #define from the DPDK build config header file before we kick off the DPDK build. So extend that here for the RTE_HAS_LIBARCHIVE #define. It would be nicer to use pkg-config somehow to generate the necessarily libraries to install on the SPDK link line for static builds. But it's not exactly straightforward, so this solution ended up being the simplest by far, extending a mechanism that's worked well with SPDK's dpdkbuild up until this point. Fixes issue #2357. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I79ff4648ee58a3e13f4b873f8acd1b31cca0fc31 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11385 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> |
||
|---|---|---|
| .. | ||
| Makefile | ||