d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

stand/efi: Better variable name

Browse Source 
sanity_check_currdev returns true if it found a kernel or a sane loader
config file. A better name for this would be 'bootable' rather than 'rv'
which connotes in other places an errno value or similar.

Sponsored by:		Netflix
This commit is contained in:
Warner Losh 2023-01-08 12:00:51 -07:00
parent dd2b23006c
commit 23ed2a38c2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
stand/efi/loader/main.c
View File

@ -267,7 +267,7 @@ probe_zfs_currdev(uint64_t guid)
char *devname;
struct zfs_devdesc currdev;
char *buf = NULL;
bool rv;
bool bootable;
currdev.dd.d_dev = &zfs_dev;
currdev.dd.d_unit = 0;
@ -277,8 +277,8 @@ probe_zfs_currdev(uint64_t guid)
devname = devformat(&currdev.dd);
init_zfs_boot_options(devname);
rv = sanity_check_currdev();
if (rv) {
bootable = sanity_check_currdev();
if (bootable) {
buf = malloc(VDEV_PAD_SIZE);
if (buf != NULL) {
if (zfs_get_bootonce(&currdev, OS_BOOTONCE, buf,
@ -291,7 +291,7 @@ probe_zfs_currdev(uint64_t guid)
(void) zfs_attach_nvstore(&currdev);
}
}
return (rv);
return (bootable);
}
#endif