d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nvme: Update comment

Browse Source 
Fix comment to note we should grab additional data from the error log
page, but don't currently (it's inclear if we should do that here
and other places in nvd that want it, or if we should let nvd / the
nda periph make the request).

Sponsored by:		Netflix
Reviewed by:		chuck, mav, jhb
Differential Revision:	https://reviews.freebsd.org/D41315
This commit is contained in:
Warner Losh 2023-08-07 16:36:25 -06:00
parent 95cd10f139
commit 63b0c00eb0
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/nvme/nvme_sim.c
View File

@ -69,7 +69,9 @@ nvme_sim_nvmeio_done(void *ccb_arg, const struct nvme_completion *cpl)
/*
* Let the periph know the completion, and let it sort out what
* it means. Make our best guess, though for the status code.
* it means. Report an error or success based on SC and SCT.
* We do not try to fetch additional data from the error log,
* though maybe we should in the future.
*/
memcpy(&ccb->nvmeio.cpl, cpl, sizeof(*cpl));
ccb->ccb_h.status &= ~CAM_SIM_QUEUED;