d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove some harmless cruft from vn_generic_copy_file_range().

Browse Source 
An earlier version of the patch had code that set "error" between
line#s 2797-2799. When that code was moved, the second check for "error != 0"
could never be true and the check became harmless cruft.
This patch removes the cruft, mainly to make Coverity happy.

Reported by:	asomers, cem
This commit is contained in:
Rick Macklem 2019-08-08 20:07:38 +00:00
parent 614633146f
commit 6b1bc6f7dd
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=350777
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/kern/vfs_vnops.c
View File

@ -2798,8 +2798,6 @@ vn_generic_copy_file_range(struct vnode *invp, off_t *inoffp,
if (VOP_PATHCONF(invp, _PC_MIN_HOLE_SIZE, &holein) != 0)
holein = 0;
VOP_UNLOCK(invp, 0);
if (error != 0)
goto out;
mp = NULL;
error = vn_start_write(outvp, &mp, V_WAIT);