d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Don't use /tmp because it's outside ATF's prescribed sandbox

Browse Source 
- Replace a hardcoded PATH_MAX value with sizeof(path)
- Use path like an array, not a pointer, and always try to unlink it in cleanup

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
Enji Cooper 2015-04-11 03:18:14 +00:00
parent c7ded8ba9e
commit b74bcac4bd
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=281394
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/regression/sockets/sendfile/sendfile.c
View File

@ -452,8 +452,8 @@ run_parent(void)
static void
cleanup(void)
{
if (*path != '\0')
unlink(path);
unlink(path);
}
int
@ -461,12 +461,12 @@ main(int argc, char *argv[])
{
int pagesize;
*path = '\0';
path[0] = '\0';
pagesize = getpagesize();
if (argc == 1) {
snprintf(path, PATH_MAX, "/tmp/sendfile.XXXXXXXXXXXX");
snprintf(path, sizeof(path), "sendfile.XXXXXXXXXXXX");
file_fd = mkstemp(path);
if (file_fd == -1)
FAIL_ERR("mkstemp");