d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add comments to places where we treat errors as ciritical, but it is possible

Browse Source 
to handle them more gracefully.

MFC after:	1 week
This commit is contained in:
Pawel Jakub Dawidek 2011-01-28 21:51:40 +00:00
parent c3c56f8e41
commit d64c0992e4
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=218042
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sbin/hastd/primary.c
View File

@ -796,6 +796,7 @@ hastd_primary(struct hast_resource *res)
* Create communication channel between parent and child.
*/
if (proto_client("socketpair://", &res->hr_ctrl) < 0) {
/* TODO: There's no need for this to be fatal error. */
KEEP_ERRNO((void)pidfile_remove(pfh));
pjdlog_exit(EX_OSERR,
"Unable to create control sockets between parent and child");
@ -804,6 +805,7 @@ hastd_primary(struct hast_resource *res)
* Create communication channel between child and parent.
*/
if (proto_client("socketpair://", &res->hr_event) < 0) {
/* TODO: There's no need for this to be fatal error. */
KEEP_ERRNO((void)pidfile_remove(pfh));
pjdlog_exit(EX_OSERR,
"Unable to create event sockets between child and parent");
@ -811,6 +813,7 @@ hastd_primary(struct hast_resource *res)
pid = fork();
if (pid < 0) {
/* TODO: There's no need for this to be fatal error. */
KEEP_ERRNO((void)pidfile_remove(pfh));
pjdlog_exit(EX_TEMPFAIL, "Unable to fork");
}