Commit Graph

124 Commits

Author SHA1 Message Date
Yaroslav Tykhiy
c7bb2e64aa Found a single point where rmuser(8) wasn't robust to strange
characters in a username:  where it was inserted into a regexp.
Fix it by escaping metacharacters in the name with \Q-\E.
2002-02-11 15:26:20 +00:00
Yaroslav Tykhiy
8335d0edc2 Keep similar things together: Check for too long usernames
inside the function that verifies username validity.
2002-01-28 17:59:09 +00:00
Yaroslav Tykhiy
76ed1f96fd Disallow adding duplicate roots, toors, or other users w/uid 0.
Previously, a truth check instead if defined() check erroneously
allowed that.

PR:		bin/8745
2002-01-28 17:30:12 +00:00
Yaroslav Tykhiy
710e76b063 Implement a flexible way of letting some unusual characters
into usernames: Make the regular expression to check usernames
against configurable.

PR:		bin/22860 bin/31049
Reviewed by:	sheldonh
2002-01-28 17:03:13 +00:00
Yaroslav Tykhiy
743511b28c Remove the newly added -force option because it made adduser(8)
less robust to possible errors of the user/admin while adduser(8)
had been intended to minimize their possibility.
An alternative way of introducing strange symbols into usernames
to be committed really soon.
2002-01-28 16:37:35 +00:00
Ian Dowse
dd24e86e74 Add `-h' to the chown command so that symbolic links copied from
the skeleton directory are chown'd to the new user.

PR:		bin/10601
Submitted by:	Adrian Filipi-Martin <adrian2ubergeeks.com@gosub.cstone.net>
MFC after:	1 month
2002-01-20 17:05:07 +00:00
Ruslan Ermilov
491a842962 yp(4) -> yp(8).
PR:		docs/30797
2002-01-14 16:59:03 +00:00
Wolfram Schneider
12076922ff Remove myself as maintainer, I don't have free time for adduser anymore. 2002-01-13 11:54:48 +00:00
Yaroslav Tykhiy
2d6a2675b3 Oops, missed one point where $pwd_mkdb had been used.
Now it should be @pwd_mkdb since we moved to Perl's
safe system() not using /bin/sh.
2002-01-04 21:28:32 +00:00
Yaroslav Tykhiy
b4ca3f2583 Document a new option: -force. 2002-01-02 19:01:53 +00:00
Yaroslav Tykhiy
1b0805da95 Allow weird characters in usernames if an admin persists on that:
a) Convert all the remaining older Perl system() calls to the new,
   more secure LIST format so they are robust to whitespace and
   shell metacharacters in their arguments.
b) Add a new option: -force, which allows adding usernames containing
   characters that are otherwise illegal.

PR:		bin/22860 bin/31049
2002-01-02 18:54:40 +00:00
Yaroslav Tykhiy
9666534916 Be consistent in what restriction is imposed on a username
in the code and what the warning message reads.
2002-01-02 16:19:14 +00:00
Yaroslav Tykhiy
ff1ebf7e7d Forbid adding duplicate users with the name of "0".
Previously, it was possible due to 0 and "0" being
equivalent in Perl.
2002-01-02 15:49:49 +00:00
Yaroslav Tykhiy
55a0e28451 Parse atq(1) output correctly under various (but not all perhaps)
locale settings: allow any date and time separator characters.
2002-01-02 15:35:33 +00:00
Yaroslav Tykhiy
0dd4be31b5 In remove_at_jobs():
Don't print "Removing at jobs" if there are no jobs to remove.
Add a whitespace before "done." so the output looks better.
2002-01-02 15:24:10 +00:00
Dima Dorfman
6680d16d19 Print the correct filename if we fail to open $etc_passwd.
Submitted by:	Brian Poole <raj@cerias.purdue.edu>
2001-09-06 12:21:21 +00:00
Dima Dorfman
e3d0beed03 Pass the username we just made to pwd_mkdb so that the latter doesn't
have to regenerate the entire database.

PR:		25798
Submitted by:	Domas Mituzas <domas.mituzas@delfi.lt>
2001-08-20 01:20:05 +00:00
Ruslan Ermilov
753d686d34 mdoc(7) police: s/BSD/.Bx/ where appropriate. 2001-08-14 10:01:54 +00:00
Guy Helmer
3b62c20eda Add "use Fcntl" to resolve O_RDWR|O_CREAT|O_EXCL macros used in
new sysopen call.

PR:		29366 (in part)
2001-08-01 16:32:36 +00:00
Guy Helmer
80b9c37313 Install the new password file with pwd_mkdb, not the old one.
PR:		29366 (in part)
2001-08-01 15:27:39 +00:00
Guy Helmer
15bfd2c9b9 The variable giving the name of the temporary password file was
inconsistently named "ptmp" and "etc_ptmp".  This commit changes
it to "passwd_tmp" for consistency and to match OpenBSD's name
for the variable.

Consulted with: jedgar
2001-07-30 16:23:56 +00:00
Chris D. Faulhaber
eea11e0277 Use a safer method of creating the temporary password file.
Submitted by:	dynamo@harvard.net
Obtained from:	OpenBSD
MFC after:	3 days
2001-07-25 11:55:33 +00:00
Guy Helmer
ffbd2b9e9d Fix removal of at jobs.
PR:		bin/23052
Submitted by:	Mike Sellenschuetter <mike.sellenschuetter@bankofamerica.com>
MFC after:	1 week
2001-07-23 18:25:45 +00:00
Dima Dorfman
35904a3be8 Generate a bigger salt. This is necessary for blowfish to work
properly, and doesn't hurt the other algorithms.

PR:		28991
Submitted by:	Yoshihiro Koya <Yoshihiro.Koya@math.yokohama-cu.ac.jp>
2001-07-19 12:00:04 +00:00
Dima Dorfman
f247324df7 Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
Ruslan Ermilov
a4c37c816b mdoc(7) police: removed HISTORY info from the .Os call. 2001-07-10 15:12:08 +00:00
Adrian Chadd
127826924a Fix the rmuser script to correctly determine if a user does not exist.
PR: 26674
2001-05-02 13:30:42 +00:00
Adrian Chadd
aa96491de1 Extend adduser to create "locked" accounts. Adduser can now lock an
account at creation, create accounts with a "*" password (so you can
use alternate authentication schemes without fearing a "default" password
biting you later), and blank passwords.

Yes, adduser could create a blank password account, but this makes it
slightly more difficult to shoot yourself in the foot.

The /etc/adduser.conf entries are:

# use password-based authentication for new users
# defaultusepassword =  "yes" | "no"
defaultusepassword = "yes"

# enable account password at creation
# (the password will be prepended with a star if the account isn't enabled)
# defaultenableaccount = "yes" | "no"
defaultenableaccount = "yes"

# allow blank passwords
# defaultemptypassword = "yes" | "no"
defaultemptypassword = "no"

Requested by: alfred
Reviewed by: alfred
2001-05-02 13:20:12 +00:00
Doug Barton
555dff94cc By popular demand, have adduser preserve comments at the top of the
group file. Because of the way the group sorting works while printing
out the new file it's not possible at this time to restore comments
in other locations, but at least they won't just disappear altogether.
2001-04-17 09:42:07 +00:00
Doug Barton
cf6490c9c7 Add a more useful solution to the problem of password files with more than
one user who differs only by case. The other perl tools assume (or enforce)
the all lowercase requirement, therefore making the search through
master.passwd case insensitive seemed a reasonable optimization, IMO.

I understand, although I do not sympathize with, the argument that someone
might want to do this on purpose, and might subsequently want to use the
wrong tool for the job. So, this fix should hopefully satisfy both camps.
2001-04-15 20:43:49 +00:00
David E. O'Brien
5efcb24b76 Rev 1.11 introduced a bug where the processing became case insensative for
username to rm.

PR:		25961
Submitted by:	Linh Pham <lplist@closedsrc.org>
2001-04-15 20:01:02 +00:00
Ruslan Ermilov
b9ad8c8635 beforeinstall -> SCRIPTS. 2001-04-07 11:21:35 +00:00
Ruslan Ermilov
345e52e742 - Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.
2001-03-26 14:42:20 +00:00
Ruslan Ermilov
610a5778c5 mdoc(7) police: split punctuation characters + misc fixes. 2001-02-01 16:44:04 +00:00
Ruslan Ermilov
1bfea903ed Prepare for mdoc(7)NG. 2001-01-16 09:39:23 +00:00
Ruslan Ermilov
8b5c4af3ff Prepare for mdoc(7)NG. 2000-12-27 15:30:30 +00:00
Doug Barton
6fce744ee3 * Fix a long line that I introduced in the last commit
* Backslash escape non-alphanumeric chars in the login name so that perl
  doesn't choke on things like '$'.
2000-12-17 23:42:45 +00:00
Ruslan Ermilov
ed40311694 mdoc(7) police: removed history info from the .Os FreeBSD call. 2000-12-14 11:52:05 +00:00
Doug Barton
56cda6bf39 If a user is in the database, rmuser ought to be able to remove them.
Address this by using getpwnam(), thus killing several birds with
the same stone. My fix is slightly more aggressive than the
originators. :)

PR:		misc/22278
2000-11-21 05:52:35 +00:00
Ruslan Ermilov
e97407b4f2 mdoc(7) police: use the new features of the Nm macro. 2000-11-20 20:10:44 +00:00
Ruslan Ermilov
726b61ab5f Avoid use of direct troff requests in mdoc(7) manual pages. 2000-11-10 17:46:15 +00:00
Gregory Neil Shapiro
2216e2a2cd Complete migration of aliases file to /etc/mail/aliases.
The maintainers of share/examples/diskless/README.TEMPLATING and mergemaster
have been contacted so those may be updated as well.
2000-08-13 18:38:58 +00:00
Mark Newton
545dccdc92 Un-botch my botched reduction in permitted characters in the permitted
username check which resulted from my attempt to expand them.

PR:		bin/17372
Reviewed by:	sheldonh
2000-03-14 14:27:34 +00:00
Mark Newton
44dfd6a858 Fix the case where username validity test would incorrectly fail if
the specified username contained uppercase alphabetics.

PR:		bin/17372
2000-03-14 14:19:17 +00:00
Sheldon Hearn
2ed2dc52a6 Remove more single-space hard sentence breaks. 2000-03-06 09:45:37 +00:00
Sheldon Hearn
f2e366a105 Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.
2000-03-01 14:09:25 +00:00
Peter Wemm
97d92980a9 $Id$ -> $FreeBSD$ 1999-08-28 01:35:59 +00:00
Nik Clayton
9657f84c0f Remove references to the non-existent addgroup(8) and rmgroup(8)
commands.

PR:             docs/12659
Submitted by:   Mark Diekhans <markd@Grizzly.COM>
1999-07-27 18:22:18 +00:00
Kris Kennaway
dac696d0ca Grammar and spelling fixes
Obtained from:	OpenBSD
1999-06-30 12:49:56 +00:00
Wolfram Schneider
1c9a0db841 Added myself as maintainer. 1999-02-09 17:23:03 +00:00