Jilles Tjoelker
fe56b17710
Add tests for reaper receiving SIGCHLD (r309886).
...
PR: 213928
MFC after: 2 weeks
2016-12-12 22:51:29 +00:00
Devin Teske
6c26775c2f
In awk, casting a variable as a boolean condition is the same as testing if
...
the length of the variable contents is greater than zero
This allows us to also move the secondary condition into the action clause
2016-12-12 21:29:48 +00:00
Devin Teske
275c0c0741
Remove an unnecessary call to f_dialog_title_restore()
2016-12-12 21:27:29 +00:00
Devin Teske
1045858386
Whitespace
2016-12-12 21:26:36 +00:00
Devin Teske
d124dfc410
Utilize provided i18n strings
2016-12-12 21:23:47 +00:00
Devin Teske
877ea04721
Remove incomplete and unnecessary creation of fd3
...
The provided API already provides a passthru descriptor and even
gives you a varaible for referring to it.
2016-12-12 21:20:56 +00:00
Devin Teske
8bcf564644
Remove unnecessary semi-colons
2016-12-12 21:18:24 +00:00
Devin Teske
0b8f01fe99
Use awk the following (more succinct) awk syntax:
...
condition1 { action1 }
condition2 { action2 }
instead of the following syntax:
{
if (condition1) { action1 }
else if (condition2) { action2 }
}
2016-12-12 21:16:37 +00:00
Devin Teske
d9f83eb9f4
1 is the default descriptor for redirects without an fd prefix
2016-12-12 21:11:55 +00:00
Devin Teske
bef42d18c5
Fix invalid parameter expansion (change $@ to "$@")
...
Without quotes, $@ loses its special meanining (see below)
% sh -c 'echo $@' /bin/sh " 1 " " 2 "
1 2
% sh -c 'echo "$@"' /bin/sh " 1 " " 2 "
1 2
The quotes are required to get ARGV to be unperterped
2016-12-12 21:04:11 +00:00
Devin Teske
35c8d5eb1b
Allow the script path to contain whitespace and special characters
2016-12-12 21:01:20 +00:00
Devin Teske
58ce2edc98
Use provided API to centralize dialog title strings
2016-12-12 21:00:09 +00:00
Devin Teske
7797a5973f
Reorder dialog parameters based on commonality for readability
2016-12-12 20:54:20 +00:00
Devin Teske
6ea6e3fa7d
Fix incorrect use of provided API
...
The result of which was incorrectly sized menu dialogs
2016-12-12 20:49:49 +00:00
Devin Teske
ea2e60b01c
Use provided API (change "dialog" to "$DIALOG")
2016-12-12 20:43:09 +00:00
Devin Teske
2abc4c242e
Whitespace (dialog options separated to minimize diffs)
2016-12-12 20:41:27 +00:00
Pedro F. Giffuni
8bd856de21
ed(1): Simplify some checks.
...
The return type for both fread(3) and fwrite(3) cannot be negative, this
renders some checks invalid and variable 'ct' unnecessary.
Also bump 'len' to size_t to avoid signed/unsigned comparison warnings.
2016-12-12 20:25:59 +00:00
Emmanuel Vadot
adff859ba2
Use the spibus accessor when applicable.
...
MFC after: 3 days
2016-12-12 20:04:31 +00:00
Devin Teske
b5938e7da3
Consolidate redirects into here documents, with proper code indentation
2016-12-12 19:46:49 +00:00
Hiroki Sato
dc96a41b44
- Refactor listening socket list. All of the listening sockets are
...
now maintained in a single linked-list in a transport-independent manner.
- Use queue.h for linked-list structure.
- Use linked-list for AllowedPeers.
- Use getaddrinfo(8) even for Unix Domain sockets.
- Use macros to type-casting from/to struct sockaddr{,_in,_in6}.
- Define fu_* macro for union f_un to shorten the member names.
- Remove an extra #include <sys/type.h>.
- Add "static" to non-exported symbols.
- !INET support is still incomplete but will be fixed later.
There is no functional change except for some minor debug messages.
2016-12-12 19:33:40 +00:00
Devin Teske
15fadc4858
Remove an unnecessary "return $?" at end of function
2016-12-12 19:26:55 +00:00
Hiroki Sato
8555a6e0a4
Temporarily backout the previous commit because it was totally broken due to
...
unresolved merge conflicts.
Pointy hat to: hrs
2016-12-12 19:24:52 +00:00
Devin Teske
7bcf4508be
Use ternary operator
2016-12-12 19:24:32 +00:00
Mateusz Guzik
25e578de55
vfs: use vrefact in getcwd and fchdir
2016-12-12 19:16:35 +00:00
Devin Teske
0e638f57e6
If you're not going to make use of the products of a match() in awk
...
(e.g., RSTART and RLENGTH variables) then use ~ instead of match()
2016-12-12 19:12:31 +00:00
Edward Tomasz Napierala
e3d4c4dcde
Undo r309891. Konstantin is right in that this condition normally
...
cannot happen - the um_dev field is assigned at mount and never written
to afterwards.
2016-12-12 19:11:04 +00:00
Devin Teske
71ef4d586a
Now that these variables do not contain the --default-item flag itself,
...
change the name of the variable from $def_item_... to $default_...
2016-12-12 19:10:39 +00:00
Hiroki Sato
783e461c73
- Refactor listening socket list. All of the listening sockets are
...
now maintained in a single linked-list in a transport-independent manner.
- Use queue.h for linked-list structure.
- Use linked-list for AllowedPeers.
- Use getaddrinfo(8) even for Unix Domain sockets.
- Use macros to type-casting from/to struct sockaddr{,_in,_in6}.
- Define fu_* macro for union f_un to shorten the member names.
- Remove an extra #include <sys/type.h>.
- Add "static" to non-exported symbols.
- !INET support is still incomplete but will be fixed later.
There is no functional change except for some minor debug messages.
2016-12-12 19:10:14 +00:00
Devin Teske
86e1d2977f
Always pass --default-item parameter to dialog
2016-12-12 19:09:17 +00:00
Devin Teske
48e9fce2f5
There is zero harm in always passing --default-item to dialog
2016-12-12 19:07:42 +00:00
Devin Teske
58dc38bd1c
Centralize backtitle string
2016-12-12 19:01:04 +00:00
Bartek Rutkowski
94161f30b7
Fix regression when stdin/out/err fds are are overridden by shell.
...
Submitted by: Pawel Biernacki <pawel.biernacki@gmail.com>
Reported by: ngie
Approved by: ngie
Sponsored by: Mysterious Code Ltd.
Differential Revision: https://reviews.freebsd.org/D8543
2016-12-12 18:56:40 +00:00
Devin Teske
5357f8f7c8
Use provided API instead of hard-coded status integers
2016-12-12 18:55:41 +00:00
Devin Teske
76b07bd950
Whitespace
2016-12-12 18:52:22 +00:00
Devin Teske
9ca8b7be34
Remove unnecessary `-n' parameter to head/tail
2016-12-12 18:48:00 +00:00
Devin Teske
3204364296
awk(1) match() takes a regex, use /.../ to remind ourselves of this
...
NB: The difference between "..." and /.../ for a regex in awk is that
quoted strings go through escape expansion first (e.g., \\ becomes \)
2016-12-12 18:45:52 +00:00
Devin Teske
4fa8c81cc3
Be internally consistent (": > ..." is used elsewhere in this file)
2016-12-12 18:43:42 +00:00
Devin Teske
edcf330372
"echo | sed | sed | awk" is silly (changed to "echo | awk")
2016-12-12 18:42:55 +00:00
Devin Teske
1cac9fc2a3
Add missing `-e' parameter to sed invocations
2016-12-12 18:39:26 +00:00
Devin Teske
8d5182d698
Allow $BSDINSTALL_TMPETC to contain whitespace or special chars
2016-12-12 18:38:18 +00:00
Emmanuel Vadot
718860e469
CS ivar is uint32_t, not int.
...
MFC after: 3 days
2016-12-12 18:36:46 +00:00
Devin Teske
c62801e26d
Group fallbacks together
2016-12-12 18:34:21 +00:00
Devin Teske
0b04945dc0
Remove unnecessary quotes around number in test
2016-12-12 18:33:40 +00:00
Devin Teske
e9c843adc7
Change "[ ! ... ] && ..." to "[ ... ] || ..."
2016-12-12 18:29:24 +00:00
Devin Teske
e20253348d
Collapse tiny if statements
2016-12-12 18:28:20 +00:00
Devin Teske
114a587e3b
Replace funny block with something easy to digest
2016-12-12 18:24:41 +00:00
Devin Teske
bede070805
Consolidate locals
2016-12-12 18:21:56 +00:00
Devin Teske
5b57fabb45
Remove unnecessary local initializers
2016-12-12 18:20:56 +00:00
Devin Teske
38a9942347
Change "[ ! -z ... ]" => "[ ... ]" and "[ -z ... ]" => "[ ! ... ]"
2016-12-12 18:17:30 +00:00
Andrew Turner
adca4ffc22
Enable ACPI on arm64. It's not yet functional, but it will help keeping the
...
code building until it is ready.
Obtained from: ABT Systems Ltd
Sponsored by: The FreeBSD Foundation
2016-12-12 18:13:03 +00:00