d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
18557a86ad
freebsd-dev/sys/dev
History
Maxime Henrion 18557a86ad Fix a bunch of bugs I came accross when looking at the ixgb(4) driver, 
some of which are rather serious:
- Use the device sysctl tree instead of rolling our own.
- Don't create a bus_dmamap_t to pass to bus_dmamem_alloc(), it is
  bus_dmamem_alloc() that creates it itself.  The DMA map created
  by the driver was overwritten and its memory was leaked.
- Fix resource handling bugs in the error path of ixgb_dma_alloc().
- Don't use vtophys() to get the base address of the TX and RX rings
  when busdma already gave us the correct address to use!
- Remove now useless includes and the alpha_XXX_dmamap() hack.
- Don't initialize if_output to ether_output(), ether_ifattach() does
  it for us already.
- Add proper module dependencies on ether and pci.

Unfortunately, I'm not lucky enough to own an ixgb(4) card, nor a
machine with a bus where to plug it in and I couldn't find anyone able
to test these patches, so they are only build-tested and I won't MFC
them for 5.4-RELEASE.
2005-03-27 16:38:08 +00:00
..
aac purge dead code 2005-03-26 23:37:54 +00:00
acpi_support Use device_set_desc_copy() for non-constant strings. 2005-03-24 21:07:55 +00:00
acpica If a device_add_child fails (i.e. low memory situation), be sure to free 2005-03-27 03:37:43 +00:00
adlink Instead of a rather useless generation number, use a sample number to 2005-03-19 12:55:46 +00:00
advansys Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 19:24:22 +00:00
agp Add device id for the Ali M1671 host to AGP bridge. 2005-02-27 13:05:34 +00:00
aha
ahb
aic
aic7xxx Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 19:24:22 +00:00
amd Use BUS_PROBE_DEFAULT 2005-03-06 06:55:11 +00:00
amr Fix a null pointer de-ref when passthrough ioctls are issued. This 2005-03-13 06:25:53 +00:00
an Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 19:06:12 +00:00
ar Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 19:06:12 +00:00
arl
asr Bring back some of the ioctl junk that was removed in rev 1.59 as a 2005-03-17 01:20:49 +00:00
ata Whitespace nit. Clarifies which body this line belongs to. 2005-03-06 10:17:30 +00:00
ath fix braino introduced when converting from madwifi 2005-03-20 01:55:02 +00:00
atkbdc plug memory leak 2005-02-26 18:55:53 +00:00
auxio
awi reclaim mbuf chain when ieee80211_crypto_encap fails 2005-03-08 17:01:03 +00:00
bfe Releasing TX/RX descriptor dmamaps during device detachment instead of 2005-03-17 13:59:30 +00:00
bge Adding new device ID for BCM5751M support. 2005-03-12 06:51:25 +00:00
bktr Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 19:06:12 +00:00
buslogic
cardbus Use STAILQ in preference to SLIST for the resources. Insert new resources 2005-03-18 05:19:50 +00:00
ciss Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
cm
cnw
cp Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
cpufreq Only activate ICH speedstep if we're going to use it. No bugs were observed 2005-03-20 01:25:21 +00:00
cs
ct
ctau Use dynamic major number allocation. 2005-02-27 22:16:58 +00:00
cx netchild's mega-patch to isolate compiler dependencies into a central 2005-03-02 21:33:29 +00:00
cy Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
dc Bugger, wiped out a needed comma in the previous commit. 2005-03-09 00:54:55 +00:00
dcons
de Return BUS_PROBE_DEFAULT instead of 0. 2005-02-24 21:32:56 +00:00
dec
digi Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
dpt Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
drm move ptr deref's to after null checks 2005-02-26 18:52:54 +00:00
ed Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
eisa Now that the Adaptec 2842 has its own probe routine, no need to have 2005-03-17 17:36:07 +00:00
em Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
en Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
ep
esp The existing locking in the esp driver appears to be fairly adequate, so 2005-03-02 15:56:42 +00:00
ex
exca
fatm Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
fb check copyin return values when loading pallete 2005-03-26 18:01:35 +00:00
fdc If we fail a sanity check for the resources just allocated, make sure 2005-03-15 08:02:47 +00:00
fe
firewire Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
fxp Unload and destroy the TX DMA maps before destroying the DMA tag 2005-03-16 16:39:04 +00:00
gem Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
gfb
harp
hatm Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
hfa Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
hifn Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
hme Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:30:12 +00:00
hptmv Don't read past the end of pVDevice[]. (Previously, we would iterate 2005-03-18 05:43:34 +00:00
ic
ichsmb Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:17:35 +00:00
ichwd
ida Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:17:35 +00:00
idt Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:17:35 +00:00
ie
ieee488 Add placeholder mutex argument to new_unrhdr(). 2005-03-07 11:05:47 +00:00
if_ndis Argh. PCI resource list became an STAILQ instead of an SLIST. Try to 2005-03-27 10:35:07 +00:00
iicbus
iir Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:17:35 +00:00
io
ips Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:17:35 +00:00
isp Prefer <sys/cdefs.h>'s __printflike() macro to the recently added 2005-03-07 15:29:11 +00:00
ispfw
ixgb Fix a bunch of bugs I came accross when looking at the ixgb(4) driver, 2005-03-27 16:38:08 +00:00
joy
kbd plug memory leak 2005-02-26 18:55:53 +00:00
led Add placeholder mutex argument to new_unrhdr(). 2005-03-07 11:05:47 +00:00
lge Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:17:35 +00:00
lnc Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:17:35 +00:00
mc146818
mca
mcd netchild's mega-patch to isolate compiler dependencies into a central 2005-03-02 21:33:29 +00:00
md
mem
mii
mk48txx
mlx Don't call mlx_free() i mlx_attach() in case of failure. Doing so 2005-03-26 21:58:09 +00:00
mly Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:10:49 +00:00
mpt Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:10:49 +00:00
mse
musycc Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:10:49 +00:00
my Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:10:49 +00:00
ncv
nge deref correct mbuf ptr to collect any vlan tag 2005-03-26 18:47:17 +00:00
nmdm
nsp
null Use dynamic major number allocation. 2005-02-27 22:01:09 +00:00
nve Support MCP versions 4-11. 2005-03-24 18:55:07 +00:00
ofw
owi
patm Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:10:49 +00:00
pbio
pccard deal with malloc failure 2005-03-26 21:34:12 +00:00
pccbb Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:10:49 +00:00
pcf
pci fix a copy/paste typo for scanner/gameport... 2005-03-26 22:17:48 +00:00
pdq Offer unhandled IOCTLS to fddi_ioctl(). 2005-03-24 01:58:20 +00:00
ppbus When locking a MTX_SPIN, one needs to use mtx_lock_spin. 2005-03-17 20:45:24 +00:00
ppc
pst Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:10:49 +00:00
puc Use BUS_PROBE_DEFAULT for pci probe return value 2005-03-05 18:10:49 +00:00
random Fix off-by-one (too little!) array size problem. 2005-03-18 07:13:35 +00:00
ray
rc
re Unbreak build with POLLING. I should really listen and test with NOTES 2005-03-13 01:54:41 +00:00
rndtest
rp - Use pci_get_device() and pci_get_vendor() when we only want one part 2005-03-25 03:10:51 +00:00
sab
safe Use BUS_PROBE_DEFAULT in preference to 0 and BUS_PROBE_LOW_PRIORITY in 2005-03-01 08:58:06 +00:00
sbni
sbsh Use BUS_PROBE_DEFAULT in preference to 0 and BUS_PROBE_LOW_PRIORITY in 2005-03-01 08:58:06 +00:00
scd netchild's mega-patch to isolate compiler dependencies into a central 2005-03-02 21:33:29 +00:00
sf Fix style(9) issues with __P removal. 2005-02-24 22:33:05 +00:00
si Use BUS_PROBE_DEFAULT in preference to 0 and BUS_PROBE_LOW_PRIORITY in 2005-03-01 08:58:06 +00:00
sio
sk handle malloc failure and sk_vpd_prodname potentially being null for 2005-03-26 22:57:28 +00:00
smbus
sn
snc Only send packet to bpf if we are committed to send it. Previously it was 2005-02-21 17:30:10 +00:00
snp Disable two users of findcdev. They do the wrong thing now and will 2005-03-15 12:39:30 +00:00
sound Return BUS_PROBE_DEFAULT in preference to 0. 2005-03-20 20:13:21 +00:00
speaker
sr Use BUS_PROBE_DEFAULT in preference to 0 and BUS_PROBE_LOW_PRIORITY in 2005-03-01 08:58:06 +00:00
stg Use BUS_PROBE_DEFAULT in preference to 0 and BUS_PROBE_LOW_PRIORITY in 2005-03-01 08:58:06 +00:00
streams
sx Use BUS_PROBE_DEFAULT in preference to 0 and BUS_PROBE_LOW_PRIORITY in 2005-03-01 08:58:06 +00:00
sym eliminate double free when sym_cam_attach fails 2005-03-26 18:17:58 +00:00
syscons Remove debug printout of major/minor numbers, print name instead. 2005-02-27 21:16:26 +00:00
tdfx Use BUS_PROBE_DEFAULT in preference to 0. Also for vx, return 2005-03-01 07:50:12 +00:00
tga Use BUS_PROBE_DEFAULT in preference to 0. Also for vx, return 2005-03-01 07:50:12 +00:00
ti deal with malloc failure when setting up the multicast filter 2005-03-26 23:26:49 +00:00
trm Use BUS_PROBE_DEFAULT in preference to 0. Also for vx, return 2005-03-01 07:50:12 +00:00
twa check copyin+copyout return values when processing TWA_IOCTL_GET_LOCK 2005-03-27 00:29:37 +00:00
twe Use correct flags for bus_dma_tag_create(). 2005-03-06 20:57:54 +00:00
tx Use BUS_PROBE_DEFAULT in preference to 0. Also for vx, return 2005-03-01 07:50:12 +00:00
txp Use BUS_PROBE_DEFAULT in preference to 0. Also for vx, return 2005-03-01 07:50:12 +00:00
uart In uart_cpu_getdev_console() when determinig whether we should use 2005-03-12 17:06:03 +00:00
ubsec Use BUS_PROBE_DEFAULT in preference to 0. Also for vx, return 2005-03-01 07:50:12 +00:00
usb Don't defer the boot-time exploration of high-speed USB busses. 2005-03-27 15:31:23 +00:00
utopia Split the chip-specific code from the generic Utopia code. This simplifies 2005-02-24 16:56:36 +00:00
vge Use BUS_PROBE_DEFAULT in preference to 0. Also for vx, return 2005-03-01 07:50:12 +00:00
vkbd plug memory leak 2005-02-25 03:41:11 +00:00
vr Fix style(9) issues with __P removal. 2005-02-24 22:33:05 +00:00
vx Use BUS_PROBE_DEFAULT in preference to 0. Also for vx, return 2005-03-01 07:50:12 +00:00
watchdog
wds
wi Unbreak LINT. 2005-03-27 15:57:42 +00:00
wl
xe
zs The zs(4) driver is superseded by uart(4) and broken in -CURRENT. Remove 2005-02-27 15:23:58 +00:00