FreeBSD src
Go to file
Kristof Provost 52bb6100e9 riscv: Fix copyin/copyout
r343275 introduced a performance optimisation to the copyin/copyout
routines by attempting to copy word-per-word rather than byte-per-byte
where possible.

This optimisation failed to account for cases where the buffer is longer
than XLEN_BYTES, but due to misalignment does not not allow for any
word-sized copies. E.g. a 9 byte buffer (with XLEN_BYTES == 8) which is
misaligned by 2 bytes. The code nevertheless did a single full-word
copy, which meant we copied too much data. This potentially clobbered
other data.

This is most easily demonstrated by a simple `sysctl -a`.

Fix it by not assuming that we'll always have at least one full-word
copy to do, but instead checking the remaining length first.

Reviewed by:	markj@, mhorne@, br@ (previous version)
MFC after:	1 week
Sponsored by:	Axiado
Differential Revision:	https://reviews.freebsd.org/D21100
2019-07-29 14:59:14 +00:00
bin Now that we have MK_LS_COLORS, we don't need RELEASE_CRUNCH check here. 2019-07-15 07:35:46 +00:00
cddl Fix a bug introduced with parallel mounting of zfs 2019-07-26 13:12:33 +00:00
contrib Pull in r366369 from upstream llvm trunk (by Francis Visoiu Mistrih): 2019-07-26 18:49:20 +00:00
crypto Complete LOCAL_PEERCRED support. Cache pid of the remote process in the 2019-05-30 14:24:26 +00:00
etc Remove NAND and NANDFS support 2019-06-25 04:50:09 +00:00
gnu powerpc: Transition to Secure-PLT, like most other OSs (Toolchain part) 2019-06-25 02:35:22 +00:00
include Add an entry for copy_file_range(2) to unistd.h. 2019-07-25 06:10:44 +00:00
kerberos5 Fix generation of krb5-config with LC_CTYPE=*.UTF-8 2019-07-01 11:47:45 +00:00
lib Merge libcxxrt master f96846efbfd508f66d91fcbbef5dd808947c7f6d. 2019-07-26 16:55:06 +00:00
libexec motd: Generate from template to /var/run 2019-07-20 20:56:31 +00:00
release motd: Generate from template to /var/run 2019-07-20 20:56:31 +00:00
rescue Remove unused defines since r147075 2019-07-12 04:44:50 +00:00
sbin Add some new fields and bits from NVMe 1.4. 2019-07-29 03:28:46 +00:00
secure Merge OpenSSL 1.1.1c. 2019-05-28 21:54:12 +00:00
share * Improve input validation of sysctl parameters for DCTPC. 2019-07-29 08:50:35 +00:00
stand loader: ignore some variable settings if input unverified 2019-07-17 23:33:14 +00:00
sys riscv: Fix copyin/copyout 2019-07-29 14:59:14 +00:00
targets Remove cap_random(3). 2019-07-24 22:50:43 +00:00
tests Temporarily skip flakey test case 2019-07-24 17:41:40 +00:00
tools Save the last callout function executed on each CPU 2019-07-03 19:22:44 +00:00
usr.bin Fix printing of Server Re-Failed and Server Faults. 2019-07-28 21:44:01 +00:00
usr.sbin Add device temperature reporting into CTL. 2019-07-26 03:49:16 +00:00
.arcconfig
.arclint arc lint: ignore /tests/ in chmod 2017-12-19 03:38:06 +00:00
.cirrus.yml cirrus.yml: use OVMF.fd from uefi-edk2-qemu-x86_64 package 2019-07-24 21:08:30 +00:00
.clang-format Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitattributes Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitignore Ignore _.universe-toolchain file. 2018-07-01 13:50:37 +00:00
COPYRIGHT Happy New Year 2019! 2019-01-01 00:25:25 +00:00
LOCKS LOCKS: update current locks 2018-06-09 03:08:04 +00:00
MAINTAINERS Update/reformat maintainer entries that I am a part of 2019-04-29 18:48:43 +00:00
Makefile pkgbase: Add the sub stage-packages targets to TGTS 2019-07-24 08:00:00 +00:00
Makefile.inc1 Add head(1) to native-xtools so that it can be used in qemu-user jails 2019-06-20 13:24:58 +00:00
Makefile.libcompat libsysdecode: use the proper include directory 2019-07-25 17:10:17 +00:00
Makefile.sys.inc AUTO_OBJ: For all top-level targets enforce using an OBJDIR. 2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc Remove cap_random(3). 2019-07-24 22:50:43 +00:00
README Import OpenSSL 1.1.1c. 2019-05-28 20:08:17 +00:00
README.md README: add generic notes about GENERIC and NOTES 2018-06-17 19:44:24 +00:00
RELNOTES Document r350307. 2019-07-24 22:57:17 +00:00
UPDATING Re-wrap the text at 80 columns after fixing the indent in the prior commit. 2019-07-26 17:58:46 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html, and https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information, including setting make(1) variables.

Source Roadmap:

bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

stand		Boot loader sources.

sys		Kernel sources.

sys/<arch>/conf Kernel configuration files. GENERIC is the configuration
		used in release builds. NOTES contains documentation of
		all possible entries.

tests		Regression tests which can be run by Kyua.  See tests/README
		for additional information.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/current-stable.html