a4f3f02be6
-w flag matching with an empty pattern was generally 'broken', allowing matches to occur on any line whether or not it actually matches -w criteria. This fix required a good amount of refactoring to address. procline() is altered to *only* process the line and return whether it was a match or not, necessary to be able to short-circuit the whole function in case of this matchall flag. -m flag handling is moved out as well because it suffers from the same fate as context handling if we bypass any actual pattern matching. The matching context (matches, mostly) didn't previously exist outside of procline(), so we go ahead and create context object for file processing bits to pass around. grep_printline() was created due to this, for the scenarios where the matches don't actually matter and we just want to print a line or two, a la flushing the context queue and no -o or --color specified. Damage from this broken behavior would have been mitigated by the fact that it is unlikely users would invoke grep -w with an empty pattern. This was identified while checking PR 105221 for problems it this may cause in BSD grep, but PR 105221 is *not* a report of this behavior. Submitted by: Kyle Evans <kevans91 at ksu.edu> Differential Revision: https://reviews.freebsd.org/D10433 |
||
|---|---|---|
| .. | ||
| awk | ||
| basename | ||
| bzip2 | ||
| cc | ||
| cmp | ||
| config | ||
| cut | ||
| diff | ||
| dirname | ||
| find | ||
| gdb | ||
| grep | ||
| gzip | ||
| id | ||
| infocmp | ||
| jot | ||
| ld | ||
| m4 | ||
| make | ||
| mixerctl | ||
| mkdep | ||
| nbperf | ||
| netpgpverify | ||
| pr | ||
| rump_server | ||
| sdiff | ||
| sed | ||
| shmif_dumpbus | ||
| sort | ||
| tmux | ||
| tr | ||
| unifdef | ||
| uniq | ||
| vmstat | ||
| xlint/lint1 | ||