Warner Losh 53366abd02 Close, but not eliminate, a race condition. It is one that properly ...

designed drivers would never hit, but was exposed in diving into
another problem...

When expanding the devclass array, free the old memory after updating
the pointer to the new memory.  For the following single race case,
this helps:

	allocate new memory
	copy to new memory
	free old memory
<interrupt>				read pointer to freed memory
	update pointer to new memory

Now we do
	allocate new memory
	copy to new memory
	update pointer to new memory
	free old memory

Which closes this problem, but doesn't even begin to address the
multicpu races, which all should be covered by Giant at the moment,
but likely aren't completely.

Note: reviewers were ok with this fix, but suggested the use case
wasn't one we wanted to encourage.

Reviewed by:	jhb, scottl.

2008-10-10 17:49:47 +00:00

..

bus_if.m

Implement a BUS_BIND_INTR() method in the bus interface to bind an IRQ

2008-03-20 21:24:32 +00:00

clock_if.m

…

cpufreq_if.m

…

device_if.m

…

genassym.sh

refactor code so it can run in a chroot without having to have /dev/mounted

2008-01-18 17:02:14 +00:00

imgact_aout.c

Change the static struct sysentvec and struct Elf_Brandinfo initializers

2008-09-24 10:14:37 +00:00

imgact_elf32.c

…

imgact_elf64.c

…

imgact_elf.c

If the ABI-overriden interpreter was not loaded, do not set

2008-10-08 11:11:36 +00:00

imgact_gzip.c

VOP_LOCK1() (and so VOP_LOCK()) and VOP_UNLOCK() are only used in

2008-01-13 14:44:15 +00:00

imgact_shell.c

Decontextualize the couplet VOP_GETATTR / VOP_SETATTR as the passed thread

2008-08-28 15:23:18 +00:00

inflate.c

…

init_main.c

Change the static struct sysentvec and struct Elf_Brandinfo initializers

2008-09-24 10:14:37 +00:00

init_sysent.c

Regen.

2008-09-25 20:08:36 +00:00

kern_acct.c

Properly lock proctree_lock before locking the process while accounting.

2008-08-21 15:02:17 +00:00

kern_alq.c

Use msleep_spin() instead of unlock/tsleep/lock. This was

2008-07-02 20:44:33 +00:00

kern_clock.c

Implement per-cpu callout threads, wheels, and locks.

2008-04-02 11:20:30 +00:00

kern_condvar.c

- Don't do a WITNESS_SAVE() on the interlock if it is Giant in the condition

2008-09-25 13:42:19 +00:00

kern_conf.c

Move uminor() and umajor() to the same place as userspace minor() and major().

2008-09-27 13:19:09 +00:00

kern_context.c

Further system call comment cleanup:

2007-03-05 13:10:58 +00:00

kern_cpu.c

Fix a few edge cases with error handling in cpufreq(4)'s CPUFREQ_GET()

2008-05-05 19:13:52 +00:00

kern_cpuset.c

Add a `show cpusets' DDB command to print numbered root and

2008-07-07 21:32:02 +00:00

kern_ctf.c

Add the CTF source file which gets shared with link_elf.c and link_elf_obj.c.

2008-05-23 03:04:27 +00:00

kern_descrip.c

Integrate the new MPSAFE TTY layer to the FreeBSD operating system.

2008-08-20 08:31:58 +00:00

kern_dtrace.c

Remove code that isn't required. It actually breaks the case where KDTRACE_HOOKS

2008-06-16 04:44:29 +00:00

kern_environment.c

Implement the following macros for completeness:

2008-07-21 15:05:25 +00:00

kern_event.c

The kqueue_register() function assumes that it is called from the top of

2008-07-07 09:30:11 +00:00

kern_exec.c

Remove VSVTX, VSGID and VSUID. This should be a no-op,

2008-09-10 13:16:41 +00:00

kern_exit.c

Don't remove queued SIGCHLD if options contain WNOWAIT, so other

2008-08-29 01:34:05 +00:00

kern_fork.c

Do the pargs_hold() on the copy of the pointer to the p_args of the

2008-07-23 08:45:25 +00:00

kern_idle.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

kern_intr.c

style(9)

2008-09-23 14:25:56 +00:00

kern_jail.c

Step 1.5 of importing the network stack virtualization infrastructure

2008-10-02 15:37:58 +00:00

kern_kthread.c

Kill a dead variable

2008-08-03 21:07:19 +00:00

kern_ktr.c

…

kern_ktrace.c

This patch adds a new ktrace(2) record type, KTR_STRUCT, whose payload

2008-02-23 01:01:49 +00:00

kern_linker.c

Decontextualize the couplet VOP_GETATTR / VOP_SETATTR as the passed thread

2008-08-28 15:23:18 +00:00

kern_lock.c

Teach WITNESS about the interlocks used with lockmgr. This removes a bunch

2008-09-10 19:13:30 +00:00

kern_lockf.c

Re-implement the client side of rpc.lockd in the kernel. This implementation

2008-06-26 10:21:54 +00:00

kern_malloc.c

Enable the creation of a kmem map larger than 4GB.

2008-07-05 19:34:33 +00:00

kern_mbuf.c

Reintroduce UMA_SLAB_KMAP; however, change its spelling to

2008-04-04 18:41:12 +00:00

kern_mib.c

Step 1.5 of importing the network stack virtualization infrastructure

2008-10-02 15:37:58 +00:00

kern_module.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

kern_mtxpool.c

Universally adopt most conventional spelling of acquire.

2007-05-27 20:50:23 +00:00

kern_mutex.c

Teach WITNESS about the interlocks used with lockmgr. This removes a bunch

2008-09-10 19:13:30 +00:00

kern_ntptime.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

kern_physio.c

…

kern_pmc.c

Support sparsely numbered CPUs.

2008-09-22 10:37:02 +00:00

kern_poll.c

Commit step 1 of the vimage project, (network stack)

2008-08-17 23:27:27 +00:00

kern_priv.c

Remove the suser(9) interface from the kernel. It has been replaced from

2008-09-17 15:49:44 +00:00

kern_proc.c

Fix minor TTY API inconsistency.

2008-09-16 14:57:23 +00:00

kern_prot.c

Merge first in a series of TrustedBSD MAC Framework KPI changes

2007-10-24 19:04:04 +00:00

kern_resource.c

Fix a small typo in a comment in calcru1().

2008-09-05 15:55:06 +00:00

kern_rmlock.c

Teach WITNESS about the interlocks used with lockmgr. This removes a bunch

2008-09-10 19:13:30 +00:00

kern_rwlock.c

Teach WITNESS about the interlocks used with lockmgr. This removes a bunch

2008-09-10 19:13:30 +00:00

kern_sdt.c

Add kernel support for the Statically Defined Trace provider.

2008-05-18 19:32:36 +00:00

kern_sema.c

…

kern_shutdown.c

Collect N identical (or near identical) mkdumpheader() implementations into

2008-10-01 22:08:53 +00:00

kern_sig.c

Decontextualize the couplet VOP_GETATTR / VOP_SETATTR as the passed thread

2008-08-28 15:23:18 +00:00

kern_subr.c

Make ureadc() warn when holding any locks, just like uiomove().

2008-08-28 19:34:58 +00:00

kern_switch.c

fix typo in runz_fuzz

2008-05-12 06:42:06 +00:00

kern_sx.c

Teach WITNESS about the interlocks used with lockmgr. This removes a bunch

2008-09-10 19:13:30 +00:00

kern_synch.c

- Don't do a WITNESS_SAVE() on the interlock if it is Giant in the condition

2008-09-25 13:42:19 +00:00

kern_syscalls.c

Various style fixes. 7 space indent is just odd.

2008-09-18 20:10:11 +00:00

kern_sysctl.c

Add sysctl_rename_oid() to support device_set_unit() usage. Otherwise,

2007-11-30 21:29:08 +00:00

kern_tc.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

kern_thr.c

Fix compiling problem.

2008-04-29 05:48:05 +00:00

kern_thread.c

A suspended thread can, in fact, be swapped out. Thus,

2008-08-22 16:15:58 +00:00

kern_time.c

Make sure reading td_runtime in critical section since thread may be

2008-01-18 13:00:28 +00:00

kern_timeout.c

add callout_schedule; besides being useful it also improves

2008-08-02 17:42:38 +00:00

kern_umtx.c

Add two commands to _umtx_op system call to allow a simple mutex to be

2008-06-24 07:32:12 +00:00

kern_uuid.c

Step 1.5 of importing the network stack virtualization infrastructure

2008-10-02 15:37:58 +00:00

kern_xxx.c

Step 1.5 of importing the network stack virtualization infrastructure

2008-10-02 15:37:58 +00:00

ksched.c

Commit 14/14 of sched_lock decomposition.

2007-06-05 00:00:57 +00:00

link_elf_obj.c

Calling linker_load_dependencies() while holding the module'

2008-08-03 13:33:45 +00:00

link_elf.c

Calling linker_load_dependencies() while holding the module'

2008-08-03 13:33:45 +00:00

linker_if.m

Add the ctf_get method.

2008-05-23 04:06:49 +00:00

Make.tags.inc

Remove netatm from HEAD as it is not MPSAFE and relies on the now removed

2008-05-25 22:11:40 +00:00

Makefile

style.Makefile(5)

2007-12-14 21:30:51 +00:00

makesyscalls.sh

Tidy up a few things with syscall generation:

2008-09-25 20:07:42 +00:00

md4c.c

…

md5c.c

…

p1003_1b.c

Remove kernel support for M:N threading.

2008-03-12 10:12:01 +00:00

posix4_mib.c

Fix mispatch of includes list; allows my kernel to build successfully.

2006-11-12 03:34:03 +00:00

sched_4bsd.c

When choosing a CPU for a thread in a cpuset, prefer the last CPU that the

2008-07-28 20:39:21 +00:00

sched_ule.c

- Check whether we've recorded this tick in ts_ticks on another cpu in

2008-07-19 05:13:47 +00:00

serdev_if.m

…

stack_protector.c

Fix a chicken-and-egg problem: this files implements SSP support,

2008-06-26 07:52:45 +00:00

subr_acl_posix1e.c

Eliminate now-unused SUSER_ALLOWJAIL arguments to priv_check_cred(); in

2007-06-12 00:12:01 +00:00

subr_autoconf.c

If run_interrupt_driven_config_hooks() waits 360 seconds and INVARIANTS

2008-07-21 20:50:49 +00:00

subr_blist.c

add malloc flag to blist so that it can be used in ithread context

2008-05-05 19:48:54 +00:00

subr_bus.c

Close, but not eliminate, a race condition. It is one that properly

2008-10-10 17:49:47 +00:00

subr_clist.c

Now that the number of clist consumers have dropped massively, trim down

2008-09-21 18:12:18 +00:00

subr_clock.c

Now that all platforms use genclock, shuffle things around slightly

2008-04-22 19:38:30 +00:00

subr_devstat.c

…

subr_disk.c

Add a new I/O request - BIO_FLUSH, which basically tells providers below to

2006-10-31 21:11:21 +00:00

subr_eventhandler.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

subr_fattime.c

Better naming of fattime conversion functions, they do convert to timespec

2006-10-24 10:27:23 +00:00

subr_firmware.c

dynamically allocate the task structure in firmware_mountroot: when

2008-10-04 23:58:02 +00:00

subr_hints.c

…

subr_kdb.c

Expand kdb_alt_break a little, most commonly used with the option

2008-05-04 23:29:38 +00:00

subr_kobj.c

…

subr_lock.c

- track maximum wait time

2008-07-27 21:45:20 +00:00

subr_log.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

subr_mbpool.c

Add parens around *free in *free++ in mbp_count() so that mbp_count()

2007-05-27 17:38:36 +00:00

subr_mchain.c

Replaced the misleading uses of a historical artefact M_TRYWAIT with M_WAIT.

2008-03-25 09:39:02 +00:00

subr_module.c

…

subr_msgbuf.c

…

subr_param.c

Correct an error in the comments for init_param3().

2008-07-04 19:36:58 +00:00

subr_pcpu.c

Make ddb command registration dynamic so modules can extend

2008-09-15 22:45:14 +00:00

subr_power.c

…

subr_prf.c

Integrate the new MPSAFE TTY layer to the FreeBSD operating system.

2008-08-20 08:31:58 +00:00

subr_prof.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

subr_rman.c

Make ddb command registration dynamic so modules can extend

2008-09-15 22:45:14 +00:00

subr_rtc.c

Now that all platforms use genclock, shuffle things around slightly

2008-04-22 19:38:30 +00:00

subr_sbuf.c

Switch to simplified BSD license (with phk's approval), plus whitespace

2008-08-09 10:26:21 +00:00

subr_scanf.c

…

subr_sleepqueue.c

Make ddb command registration dynamic so modules can extend

2008-09-15 22:45:14 +00:00

subr_smp.c

- Only count the number of CPUs in the rendezvous map once rather than

2008-08-27 18:23:55 +00:00

subr_stack.c

Staticize M_STACK.

2008-07-13 17:15:05 +00:00

subr_taskqueue.c

revert local change

2008-07-18 07:10:33 +00:00

subr_trap.c

- Make SCHED_STATS more generic by adding a wrapper to create the

2008-04-17 04:20:10 +00:00

subr_turnstile.c

Make ddb command registration dynamic so modules can extend

2008-09-15 22:45:14 +00:00

subr_unit.c

Since cdev mutex is after system map mutex in global lock order, free()

2007-07-04 06:56:58 +00:00

subr_witness.c

Oops, missed updating a place with with 's/lock1/plock/' when adding

2008-10-03 18:13:05 +00:00

sys_generic.c

Reverse if() logic to improve readability.

2008-09-23 14:25:38 +00:00

sys_pipe.c

Another problem caused by the knlist_cleardel() potentially dropping

2008-05-23 11:14:03 +00:00

sys_process.c

- Relax requirements for p_numthreads, p_threads, p_swtick, and p_nice from

2008-03-19 06:19:01 +00:00

sys_socket.c

Lock receive socket buffer in soo_stat() rather than commenting that we

2008-10-07 07:10:28 +00:00

syscalls.c

Regen.

2008-09-25 20:08:36 +00:00

syscalls.master

Tidy up a few things with syscall generation:

2008-09-25 20:07:42 +00:00

systrace_args.c

Regen.

2008-09-25 20:08:36 +00:00

sysv_ipc.c

Eliminate now-unused SUSER_ALLOWJAIL arguments to priv_check_cred(); in

2007-06-12 00:12:01 +00:00

sysv_msg.c

Merge first in a series of TrustedBSD MAC Framework KPI changes

2007-10-24 19:04:04 +00:00

sysv_sem.c

Renew semaphore's pointer after wakeup since during msleep

2008-06-19 18:08:42 +00:00

sysv_shm.c

Make sure we restrict Linux only IPC calls from being executed

2008-02-12 20:55:03 +00:00

tty_compat.c

Fix an awful bug inside our COMPAT_43TTY code.

2008-09-04 16:30:53 +00:00

tty_cons.c

Integrate the new MPSAFE TTY layer to the FreeBSD operating system.

2008-08-20 08:31:58 +00:00

tty_info.c

Integrate the new MPSAFE TTY layer to the FreeBSD operating system.

2008-08-20 08:31:58 +00:00

tty_inq.c

Fix some edge cases in the TTY queues:

2008-08-30 09:18:27 +00:00

tty_outq.c

Fix some edge cases in the TTY queues:

2008-08-30 09:18:27 +00:00

tty_pts.c

Track state to determine if the associated TTY device node has been used.

2008-09-23 17:12:25 +00:00

tty_pty.c

Allow the user to suppress the rate-limited pty(4) warning.

2008-08-23 16:03:00 +00:00

tty_tty.c

Remove unneeded Giant locking of /dev/tty.

2008-06-03 12:38:00 +00:00

tty_ttydisc.c

Introduce a hooks layer for the MPSAFE TTY layer.

2008-09-22 19:25:14 +00:00

tty.c

Don't forget to initialize `int error' in ttydev_open().

2008-09-26 18:17:04 +00:00

uipc_accf.c

…

uipc_cow.c

Give MEXTADD() another argument to make both void pointers to the

2008-02-01 19:36:27 +00:00

uipc_debug.c

Change a variable name to not shadow a global

2008-07-03 08:35:59 +00:00

uipc_domain.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

uipc_mbuf2.c

Merge first in a series of TrustedBSD MAC Framework KPI changes

2007-10-24 19:04:04 +00:00

uipc_mbuf.c

Remove the alignment of the align parameter. This is up to the caller to pass

2008-09-05 04:05:31 +00:00

uipc_mqueue.c

fdescfs, devfs, mqueuefs, nfs, portalfs, pseudofs, tmpfs and xfs

2008-09-20 19:50:52 +00:00

uipc_sem.c

Rework the lifetime management of the kernel implementation of POSIX

2008-06-27 05:39:04 +00:00

uipc_shm.c

Rework the lifetime management of the kernel implementation of POSIX

2008-06-27 05:39:04 +00:00

uipc_sockbuf.c

Rewrite sbreserve_locked()'s comment on NULL thread pointers, eliminating

2008-10-07 09:51:39 +00:00

uipc_socket.c

In soreceive_dgram, when a 0-length buffer is passed into recv(2) and

2008-10-07 20:57:55 +00:00

uipc_syscalls.c

When sendto(2) is called with an explicit destination address

2008-05-22 07:18:54 +00:00

uipc_usrreq.c

Remove stale comment (and XXX saying so) about why we zero the file

2008-10-08 06:26:51 +00:00

vfs_acl.c

Add the support for the AT_FDCWD and fd-relative name lookups to the

2008-03-31 12:01:21 +00:00

vfs_aio.c

Use minimum of max_aio_procs and target_aio_procs when spawning new

2008-06-21 11:34:34 +00:00

vfs_bio.c

Add the ffs structures introspection functions for ddb.

2008-09-16 11:19:38 +00:00

vfs_cache.c

Part 1 of making shared lookups more resilient with respect to forced

2008-09-24 18:51:33 +00:00

vfs_cluster.c

- Complete part of the unfinished bufobj work by consistently using

2008-03-22 09:15:16 +00:00

vfs_default.c

Decontextualize the couplet VOP_GETATTR / VOP_SETATTR as the passed thread

2008-08-28 15:23:18 +00:00

vfs_export.c

Provide the mutual exclusion between the nfs export list modifications

2008-06-09 10:31:38 +00:00

vfs_extattr.c

Add the support for the AT_FDCWD and fd-relative name lookups to the

2008-03-31 12:01:21 +00:00

vfs_hash.c

In keeping with style(9)'s recommendations on macros, use a ';'

2008-03-16 10:58:09 +00:00

vfs_init.c

Remove VFS_VPTOFH entirely. API is already broken and it is good time to

2007-02-16 17:32:41 +00:00

vfs_lookup.c

Enable shared locks for path name lookups on supported filesystems (NFS

2008-10-01 19:25:37 +00:00

vfs_mount.c

Add freebsd32 compat shim for nmount(2).

2008-09-19 15:17:32 +00:00

vfs_subr.c

Decontextualize vfs_busy(), vfs_unbusy() and vfs_mount_alloc() functions.

2008-08-31 14:26:08 +00:00

vfs_syscalls.c

When setting error to EINVAL in 'fvp == tdvp' case, jump to out label,

2008-09-01 10:11:39 +00:00

vfs_vnops.c

Initialize va_rdev to NODEV and va_fsid to VNOVAL before the

2008-09-20 19:48:24 +00:00

vnode_if.src

Decontextualize the couplet VOP_GETATTR / VOP_SETATTR as the passed thread

2008-08-28 15:23:18 +00:00