Ian Dowse
0ce606de7c
Attempt to fix a number of race conditions in the handling of ...
transfer timeouts that typically cause a transfer to be completed
twice, resulting in panics and page faults:
o A transfer completion interrupt could arrive while an abort_task
event was set up, so the transfer would be aborted after it had
completed. This is very easy to reproduce. Fix this by setting
the transfer status to USBD_TIMEOUT before scheduling the
abort_task so that the transfer completion code will ignore it.
o The transfer completion code could execute concurrently with the
timeout callout, leaving the callout blocked (e.g. waiting for
Giant) while the transfer completion code runs. In this case,
callout_stop() does not prevent the callout from running, so
again the timeout code would run after the transfer was complete.
Handle this case by checking the return value from callout_stop(),
and ignoring the transfer if the callout could not be removed.
o Finally, protect against a timeout callout occurring while a
transfer is being aborted by another process. Here we arrange
for the timeout processing to ignore the transfer, and use
callout_drain() to ensure that the callout has really gone before
completing the transfer.
This was tested by repeatedly performing USB transfers with a timeout
set to approximately the same as the normal transfer completion
time. In the PR below, apparently this occurred by accident with a
particular printer and the default timeout.
PR: kern/71491
2004-11-09 20:51:32 +00:00
2004-10-21 19:14:32 +00:00
2004-11-08 16:54:26 +00:00
2004-11-09 07:02:33 +00:00
2004-09-19 21:52:15 +00:00
2004-05-30 20:08:47 +00:00
2004-10-24 07:31:07 +00:00
2004-09-15 11:58:34 +00:00
2004-03-17 17:50:55 +00:00
2004-05-27 03:49:45 +00:00
2004-10-24 15:33:08 +00:00
2004-05-30 20:08:47 +00:00
2004-09-14 16:36:12 +00:00
2004-08-01 23:58:04 +00:00
2004-08-13 22:52:11 +00:00
2004-08-13 22:54:19 +00:00
2004-08-02 23:32:23 +00:00
2004-10-20 10:11:05 +00:00
2004-08-08 17:10:54 +00:00
2004-10-14 22:21:59 +00:00
2004-10-09 07:31:03 +00:00
2004-08-13 22:55:25 +00:00
2004-10-23 08:33:10 +00:00
2004-11-08 19:27:00 +00:00
2004-09-11 04:32:55 +00:00
2004-09-15 11:58:34 +00:00
2004-06-27 13:07:02 +00:00
2004-08-16 23:13:16 +00:00
2004-08-13 22:57:44 +00:00
2004-05-23 16:11:53 +00:00
2004-09-23 12:21:11 +00:00
2004-08-13 23:03:11 +00:00
2004-07-10 20:57:43 +00:00
2004-09-23 12:21:11 +00:00
2004-10-13 09:27:18 +00:00
2004-10-05 07:42:19 +00:00
2004-10-01 15:23:31 +00:00
2004-10-28 12:18:22 +00:00
2004-11-08 19:21:57 +00:00
2004-10-18 21:51:27 +00:00
2004-03-17 17:50:55 +00:00
2004-08-29 07:49:53 +00:00
2004-10-20 04:54:50 +00:00
2004-08-16 22:05:53 +00:00
2004-11-03 14:11:18 +00:00
2004-08-02 00:18:36 +00:00
2004-07-22 07:11:15 +00:00
2004-09-13 15:15:38 +00:00
2004-10-17 21:44:11 +00:00
2004-08-16 01:57:06 +00:00
2004-03-17 17:50:55 +00:00
2004-09-24 01:08:34 +00:00
2004-11-08 18:53:52 +00:00
2004-10-07 20:56:29 +00:00
2004-10-22 15:39:39 +00:00
2004-09-18 19:13:13 +00:00
2004-08-13 23:11:24 +00:00
2004-07-10 22:29:41 +00:00
2004-07-15 08:26:07 +00:00
2004-03-17 17:50:55 +00:00
2004-08-27 18:33:08 +00:00
2004-10-15 03:54:56 +00:00
2004-08-14 22:38:20 +00:00
2004-10-24 09:23:07 +00:00
2004-04-07 20:46:16 +00:00
2004-06-24 18:21:28 +00:00
2004-06-13 05:00:19 +00:00
2004-06-16 09:47:26 +00:00
2004-08-27 18:33:08 +00:00
2004-08-13 23:15:44 +00:00
2004-10-18 21:33:56 +00:00
2004-08-13 23:16:44 +00:00
2004-09-03 08:44:23 +00:00
2004-08-02 20:42:28 +00:00
2004-06-16 09:47:26 +00:00
2004-09-23 05:25:22 +00:00
2004-07-15 08:26:07 +00:00
2004-08-14 00:17:04 +00:00
2004-06-16 09:47:26 +00:00
2004-06-16 09:47:26 +00:00
2004-07-10 15:38:27 +00:00
2004-11-08 19:21:57 +00:00
2004-08-22 23:01:13 +00:00
2004-06-16 09:47:26 +00:00
2004-10-29 11:09:21 +00:00
2004-11-06 13:16:35 +00:00
2004-08-04 18:30:31 +00:00
2004-09-24 22:24:33 +00:00
2004-09-20 00:09:32 +00:00
2004-06-16 09:47:26 +00:00
2004-06-16 09:47:26 +00:00
2004-08-25 17:54:19 +00:00
2004-06-16 09:47:26 +00:00
2004-09-28 20:14:51 +00:00
2004-06-09 14:34:04 +00:00
2004-07-10 21:05:14 +00:00
2004-11-08 19:21:57 +00:00
2004-10-18 21:51:27 +00:00
2004-07-10 21:06:08 +00:00
2004-08-02 19:59:41 +00:00
2004-10-18 21:51:27 +00:00
2004-05-26 00:53:10 +00:00
2004-10-24 15:33:08 +00:00
2004-10-11 00:58:24 +00:00
2004-09-09 18:48:09 +00:00
2004-08-16 06:33:58 +00:00
2004-08-12 17:41:33 +00:00
2004-11-01 22:15:15 +00:00
2004-09-22 17:16:04 +00:00
2004-08-27 18:33:08 +00:00
2004-05-30 20:08:47 +00:00
2004-10-03 16:06:46 +00:00
2004-08-12 17:41:33 +00:00
2004-11-05 20:15:06 +00:00
2004-08-13 23:39:07 +00:00
2004-10-07 06:19:11 +00:00
2004-09-28 18:22:24 +00:00
2004-10-04 09:38:53 +00:00
2004-10-12 22:33:19 +00:00
2004-05-30 20:08:47 +00:00
2004-08-13 23:41:00 +00:00
2004-05-30 20:08:47 +00:00
2004-10-29 11:09:50 +00:00
2004-08-28 15:10:35 +00:00
2004-10-02 18:49:29 +00:00
2004-10-14 22:21:59 +00:00
2004-11-01 17:21:04 +00:00
2004-06-16 09:47:26 +00:00
2004-06-09 14:34:04 +00:00
2004-08-13 23:47:01 +00:00
2004-11-05 18:32:14 +00:00
2004-10-25 10:29:57 +00:00
2004-06-16 09:47:26 +00:00
2004-08-13 23:49:48 +00:00
2004-07-10 21:14:20 +00:00
2004-07-15 08:26:07 +00:00
2004-10-08 06:45:10 +00:00
2004-09-10 18:39:02 +00:00
2004-10-18 21:51:27 +00:00
2004-06-16 09:47:26 +00:00
2004-09-01 22:53:13 +00:00
2004-08-28 15:10:35 +00:00
2004-05-30 20:08:47 +00:00
2004-08-18 16:14:44 +00:00
2004-06-16 09:47:26 +00:00
2004-08-13 23:52:33 +00:00
2004-08-13 23:53:36 +00:00
2004-10-12 21:00:19 +00:00
2004-05-30 20:08:47 +00:00
2004-11-09 20:51:32 +00:00
2004-07-15 08:26:07 +00:00
2004-09-11 22:13:25 +00:00
2004-10-27 19:02:23 +00:00
2004-08-18 16:56:54 +00:00
2004-06-16 09:47:26 +00:00
2004-08-01 23:58:04 +00:00
2004-05-30 20:08:47 +00:00
2004-08-14 00:15:26 +00:00
2004-10-20 16:22:00 +00:00
0ce606de7c