freebsd-nq/module/lua
Brian Behlendorf 0e6c493fec cppcheck: integrete cppcheck
In order for cppcheck to perform a proper analysis it needs to be
aware of how the sources are compiled (source files, include
paths/files, extra defines, etc).  All the needed information is
available from the Makefiles and can be leveraged with a generic
cppcheck Makefile target.  So let's add one.

Additional minor changes:

* Removing the cppcheck-suppressions.txt file.  With cppcheck 2.3
  and these changes it appears to no longer be needed.  Some inline
  suppressions were also removed since they appear not to be
  needed.  We can add them back if it turns out they're needed
  for older versions of cppcheck.

* Added the ax_count_cpus m4 macro to detect at configure time how
  many processors are available in order to run multiple cppcheck
  jobs.  This value is also now used as a replacement for nproc
  when executing the kernel interface checks.

* "PHONY =" line moved in to the Rules.am file which is included
  at the top of all Makefile.am's.  This is just convenient becase
  it allows us to use the += syntax to add phony targets.

* One upside of this integration worth mentioning is it now allows
  `make cppcheck` to be run in any directory to check that subtree.

* For the moment, cppcheck is not run against the FreeBSD specific
  kernel sources.  The cppcheck-FreeBSD target will need to be
  implemented and testing on FreeBSD to support this.

Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #11508
2021-01-26 16:12:26 -08:00
..
setjmp Mark lua setjmp/longjmp for powerpc weak 2020-08-25 10:32:49 -07:00
lapi.c Use known license string for zlua 2020-10-27 09:43:36 -07:00
lapi.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lauxlib.c Update build system and packaging 2018-05-29 16:00:33 -07:00
lbaselib.c Update build system and packaging 2018-05-29 16:00:33 -07:00
lcode.c OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lcode.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lcompat.c Fix coverity defects: zfs channel programs 2018-02-20 11:19:42 -08:00
lcorolib.c Update build system and packaging 2018-05-29 16:00:33 -07:00
lctype.c OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lctype.h Fix coverity defects: zfs channel programs 2018-02-20 11:19:42 -08:00
ldebug.c cppcheck: integrete cppcheck 2021-01-26 16:12:26 -08:00
ldebug.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
ldo.c cppcheck: integrete cppcheck 2021-01-26 16:12:26 -08:00
ldo.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lfunc.c OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lfunc.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lgc.c OpenZFS 9035 - zfs: this statement may fall through 2018-02-21 14:55:34 -08:00
lgc.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
llex.c Linux 5.3: Fix switch() fall though compiler errors 2019-08-21 09:29:23 -07:00
llex.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
llimits.h FreeBSD: Reduce stack usage of Lua 2020-09-22 16:03:11 -07:00
lmem.c OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lmem.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lobject.c Fix coverity defects: zfs channel programs 2018-02-20 11:19:42 -08:00
lobject.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lopcodes.c OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lopcodes.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lparser.c Fix coverity defects: zfs channel programs 2018-02-20 11:19:42 -08:00
lparser.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lstate.c Fix lua stack overflow on recursive call to gsub() 2020-07-27 16:11:47 -07:00
lstate.h Fix lua stack overflow on recursive call to gsub() 2020-07-27 16:11:47 -07:00
lstring.c Fix coverity defects: zfs channel programs 2018-02-20 11:19:42 -08:00
lstring.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lstrlib.c Replace sprintf()->snprintf() and strcpy()->strlcpy() 2020-06-07 11:42:12 -07:00
ltable.c OpenZFS 9035 - zfs: this statement may fall through 2018-02-21 14:55:34 -08:00
ltable.h Fix coverity defects: zfs channel programs 2018-02-20 11:19:42 -08:00
ltablib.c Move linux qsort def to platform header 2019-12-03 09:49:40 -08:00
ltm.c OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
ltm.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lvm.c Switch off -Wmissing-prototypes for libgcc math functions 2020-06-18 12:21:46 -07:00
lvm.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lzio.c OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
lzio.h OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
Makefile.in Cleanup linux module kbuild files 2020-06-10 09:24:15 -07:00
README.zfs OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00

#
# CDDL HEADER START
#
# This file and its contents are supplied under the terms of the
# Common Development and Distribution License ("CDDL"), version 1.0.
# You may only use this file in accordance with the terms of version
# 1.0 of the CDDL.
#
# A full copy of the text of the CDDL should have accompanied this
# source.  A copy of the CDDL is also available via the Internet at
# http://www.illumos.org/license/CDDL.
#
# CDDL HEADER END
#

#
# Copyright (c) 2017 by Delphix. All rights reserved.
#

Introduction
------------

This README describes the Lua interpreter source code that lives in the ZFS
source tree to enable execution of ZFS channel programs, including its
maintenance policy, the modifications that have been made to it, and how it
should (and should not) be used.

For a description of the Lua language and features exposed by ZFS channel
programs, please refer to the zfs-program(1m) man page instead.


Maintenance policy
------------------

The Lua runtime is considered stable software. Channel programs don't need much
complicated logic, so updates to the Lua runtime from upstream are viewed as
nice-to-have, but not required for channel programs to be well-supported. As
such, the Lua runtime in ZFS should be updated on an as-needed basis for
security vulnerabilities, but not much else.


Modifications to Lua
--------------------

The version of the Lua runtime we're using in ZFS has been modified in a variety
of ways to make it more useful for the specific purpose of running channel
programs. These changes include:

1. "Normal" Lua uses floating point for all numbers it stores, but those aren't
   useful inside ZFS / the kernel. We have changed the runtime to use int64_t
   throughout for all numbers.
2. Some of the Lua standard libraries do file I/O or spawn processes, but
   neither of these make sense from inside channel programs. We have removed
   those libraries rather than reimplementing them using kernel APIs.
3. The "normal" Lua runtime handles errors by failing fatally, but since this
   version of Lua runs inside the kernel we must handle these failures and
   return meaningful error codes to userland. We have customized the Lua
   failure paths so that they aren't fatal.
4. Running poorly-vetted code inside the kernel is always a risk; even if the
   ability to do so is restricted to the root user, it's still possible to write
   an incorrect program that results in an infinite loop or massive memory use.
   We've added new protections into the Lua interpreter to limit the runtime
   (measured in number of Lua instructions run) and memory overhead of running
   a channel program.
5. The Lua bytecode is not designed to be secure / safe, so it would be easy to
   pass invalid bytecode which can panic the kernel. By comparison, the parser
   is hardened and fails gracefully on invalid input. Therefore, we only accept
   Lua source code at the ioctl level and then interpret it inside the kernel.

Each of these modifications have been tested in the zfs-test suite. If / when
new modifications are made, new tests should be added to the suite located in
zfs-tests/tests/functional/channel_program/lua_core.


How to use this Lua interpreter
-------------------------------

From the above, it should be clear that this is not a general-purpose Lua
interpreter. Additional work would be required to extricate this custom version
of Lua from ZFS and make it usable by other areas of the kernel.