3128fa9a5a
sys/dev/ppbus/ppb_1284.c:296:46: error: implicit conversion from 'int'
to 'char' changes value from 144 to -112 [-Werror,-Wconstant-conversion]
if ((error = do_peripheral_wait(bus, SELECT | nBUSY, 0))) {
~~~~~~~~~~~~~~~~~~ ~~~~~~~^~~~~~~
sys/dev/ppbus/ppb_1284.c:785:48: error: implicit conversion from 'int'
to 'char' changes value from 240 to -16 [-Werror,-Wconstant-conversion]
if (do_1284_wait(bus, nACK | SELECT | PERROR | nBUSY,
~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
sys/dev/ppbus/ppb_1284.c:786:29: error: implicit conversion from 'int'
to 'char' changes value from 240 to -16 [-Werror,-Wconstant-conversion]
nACK | SELECT | PERROR | nBUSY)) {
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
This is because nBUSY is 0x80, so the plain char argument is wrapped to
a negative value. Fix this in a minimal fashion, by using uint8_t in a
few places.
Reviewed by: emaste
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D7771
|
||
|---|---|---|
| .. | ||
| if_plip.c | ||
| immio.c | ||
| lpbb.c | ||
| lpt.c | ||
| lpt.h | ||
| lptio.h | ||
| pcfclock.c | ||
| ppb_1284.c | ||
| ppb_1284.h | ||
| ppb_base.c | ||
| ppb_msq.c | ||
| ppb_msq.h | ||
| ppbconf.c | ||
| ppbconf.h | ||
| ppbio.h | ||
| ppbus_if.m | ||
| ppi.c | ||
| ppi.h | ||
| pps.c | ||
| vpo.c | ||
| vpoio.c | ||
| vpoio.h | ||