Don't break out of the m_advance() loop if len drops to zero.
If a packet contains the Ethernet header (14 bytes) in the first mbuf and the payload (IP + UDP + data) in the second mbuf, then the attempt to fetch the l3hdr will return a NULL pointer. The first loop iteration will drop len to zero and exit the loop without setting 'p'. However, the desired data is at the start of the second mbuf, so the correct behavior is to loop around and let the conditional set 'p' to m_data of the next mbuf (and leave offset as 0). Reviewed by: np Sponsored by: Chelsio Communications
This commit is contained in:
parent
a66a58c963
commit
21c9ef235a
@ -2082,7 +2082,7 @@ m_advance(struct mbuf **pm, int *poffset, int len)
|
||||
|
||||
MPASS(len > 0);
|
||||
|
||||
while (len) {
|
||||
for (;;) {
|
||||
if (offset + len < m->m_len) {
|
||||
offset += len;
|
||||
p = mtod(m, uintptr_t) + offset;
|
||||
|
Loading…
Reference in New Issue
Block a user