d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pms(4): Limit maximum I/O size to 256KB instead of 1MB.

Browse Source 
There is a weird limit of AGTIAPI_MAX_DMA_SEGS (128) S/G segments per
I/O since the initial driver import.  I don't know why it was added,
can only guess some hardware limitation, but in worst case it means
maximum I/O size of 508KB.  Respect it to be safe, rounding to 256KB.

MFC after:	1 week
Sponsored by:	iXsystems, Inc.
This commit is contained in:
Alexander Motin 2021-04-16 15:39:01 -04:00
parent 8434a65ce4
commit 3e34783420
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/dev/pms/freebsd/driver/ini/src/agdef.h
View File

@ -62,7 +62,7 @@ EW 09-17-2004 1.0.0 Constant definitions
#define AGTIAPI_MAX_DEVICE_7H 256 /*Max devices per channel in 7H */
#define AGTIAPI_MAX_DEVICE_8H 512 /*Max devices per channel in 8H*/
#define AGTIAPI_MAX_CAM_Q_DEPTH 1024
#define AGTIAPI_NSEGS (btoc(maxphys) + 1)
#define AGTIAPI_NSEGS (MIN(btoc(maxphys), 64) + 1)
/*
** Adapter specific defines
*/

2
sys/dev/pms/freebsd/driver/ini/src/agtiapi.c
View File

@ -1834,7 +1834,7 @@ static void agtiapi_cam_action( struct cam_sim *sim, union ccb * ccb )
cpi->max_target = maxTargets - 1;
cpi->max_lun = AGTIAPI_MAX_LUN;
/* Max supported I/O size, in bytes. */
cpi->maxio = ulmin(1024 * 1024, maxphys);
cpi->maxio = ctob(AGTIAPI_NSEGS - 1);
cpi->initiator_id = 255;
strlcpy(cpi->sim_vid, "FreeBSD", SIM_IDLEN);
strlcpy(cpi->hba_vid, "PMC", HBA_IDLEN);