d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the comment introduced in r276192 so that it clearly

Browse Source 
states that the change is needed to avoid a deadlock.

Suggested by:	kib
MFC after:	1 week
This commit is contained in:
Rick Macklem 2014-12-25 14:44:04 +00:00
parent fe07a9d08f
commit 46b34e5adc
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/kern/vfs_default.c
View File

@ -407,9 +407,10 @@ vop_stdadvlock(struct vop_advlock_args *ap)
vp = ap->a_vp;
if (ap->a_fl->l_whence == SEEK_END) {
/*
* The NFSv4 server will LOR/deadlock if a vn_lock() call
* is done on vp. Fortunately, vattr.va_size is only
* needed for SEEK_END and the NFSv4 server only uses SEEK_SET.
* The NFSv4 server must avoid doing a vn_lock() here, since it
* can deadlock the nfsd threads, due to a LOR. Fortunately
* the NFSv4 server always uses SEEK_SET and this code is
* only required for the SEEK_END case.
*/
vn_lock(vp, LK_SHARED | LK_RETRY);
error = VOP_GETATTR(vp, &vattr, curthread->td_ucred);