d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cxgbe(4): Fix an incorrect assert.

Browse Source 
CTRL and OFLD tx queues do not have automatic tx credit flush enabled so
it is okay for the cidx not to be the same as the pidx when the queue is
destroyed.

Reported by:	Jithesh Arakkan @ Chelsio
MFC after:	1 week
Sponsored by:	Chelsio Communications
This commit is contained in:
Navdeep Parhar 2021-05-26 19:18:42 -07:00
parent 740d722def
commit 5ef87bf8b6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/dev/cxgbe/t4_sge.c
View File

@ -4346,7 +4346,8 @@ static void
free_eq(struct adapter *sc, struct sge_eq *eq) free_eq(struct adapter *sc, struct sge_eq *eq)
{ {
MPASS(eq->flags & EQ_SW_ALLOCATED); MPASS(eq->flags & EQ_SW_ALLOCATED);
MPASS(eq->pidx == eq->cidx); if (eq->type == EQ_ETH)
MPASS(eq->pidx == eq->cidx);
free_ring(sc, eq->desc_tag, eq->desc_map, eq->ba, eq->desc); free_ring(sc, eq->desc_tag, eq->desc_map, eq->ba, eq->desc);
mtx_destroy(&eq->eq_lock); mtx_destroy(&eq->eq_lock);
@ -4499,6 +4500,8 @@ free_wrq(struct adapter *sc, struct sge_wrq *wrq)
{ {
free_eq(sc, &wrq->eq); free_eq(sc, &wrq->eq);
MPASS(wrq->nwr_pending == 0); MPASS(wrq->nwr_pending == 0);
MPASS(TAILQ_EMPTY(&wrq->incomplete_wrs));
MPASS(STAILQ_EMPTY(&wrq->wr_list));
bzero(wrq, sizeof(*wrq)); bzero(wrq, sizeof(*wrq));
} }