Andrew Turner
ba9f40ca3b
Use the platform_*_t typedefs to help check the platform function types are
...
correct.
Sponsored by: ABT Systems Ltd
2016-12-13 13:46:09 +00:00
Andrew Turner
59249a516a
Add the missing void to function signatures in much of the arm code.
...
Sponsored by: ABT Systems Ltd
2016-12-13 13:43:22 +00:00
Andrew Turner
3f31908a97
Use platform_*_t to check the platform function signatures are correct in
...
the Rockchip platform code and correct the one place they differ.
Sponsored by: ABT Systems Ltd
2016-12-13 13:07:17 +00:00
Ganbold Tsagaankhuu
a89938019a
Switch Rockchip RK3188 SoC to use the platform code.
...
Reviewed by: andrew, manu
Differential Revision: https://reviews.freebsd.org/D8769
2016-12-13 11:43:46 +00:00
Michael Zhilin
d1c38239e8
[gpiospi] add clock delay to avoid smashing of bits
...
Submitted by: Hiroki Mori <yamori83@yahoo.co.jp>
Reviewed by: loos, ray, mizhka
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D8749
2016-12-13 10:03:29 +00:00
Michael Zhilin
167a228d79
[spi] reformat message and ar5315_spi minor fix
...
This commit corrects print of nomatch (newline was too early) and fix
unit number for new child in ar5315_spi (was 0, now is -1 to calculate it
according to actual system state)
Submitted by: Hiroki Mori <yamori813@yahoo.co.jp>
Reviewed by: ray, loos, mizhka
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D8749
2016-12-13 09:53:43 +00:00
Ed Schouten
d6d7df8aa0
Remove the only user of sysctl_add_oid().
...
My plan is to change this function's prototype at some point in the
future to add a new label argument, which can be used to export all of
sysctl as metrics that can be scraped by Prometheus. Switch over this
caller to use the macro wrapper counterpart.
2016-12-13 07:58:30 +00:00
Colin Percival
93954c2da3
Check that blkfront devices have a non-zero number of sectors and a
...
non-zero sector size. Such a device would be a virtual disk of zero
bytes; clearly not useful, and not something we should try to attach.
As a fortuitous side effect, checking that these values are non-zero
here results in them not *becoming* zero later on the function. This
odd behaviour began with r309124 (clang 3.9.0) but is challenging to
debug; making any changes to this function whatsoever seems to affect
the llvm optimizer behaviour enough to make the unexpected zeroing of
the sector_size variable cease.
PR: 215209
Security: The potential for variables to unexpectedly become zero
has worrying consequences for security in general, but
not so much in this particular context.
2016-12-13 06:54:13 +00:00
Oleksandr Tymoshenko
c85d45a5bb
[iMX6] Add compatibility string for GPT timer on i.MX6 Dual
...
Up until r295436 GPT timer in i.MX6 Dual dts used the same compatiblity
string as i.MX6 Quad. After the sync up with Linux in r295436, GPT timer
stopped getting attached on the i.MX6 Dual
MFC after: 3 days
2016-12-13 05:09:49 +00:00
Luiz Otavio O Souza
a9a7fbcc58
Remove a too strict test and instead, just filter the passed flags with the
...
supported capabilities.
Spotted by: yamori813@yahoo.co.jp (Hiroki Mori)
MFC after: 2 weeks
2016-12-13 03:36:41 +00:00
Oleksandr Tymoshenko
ec0a42e59c
[iMX6] Fix platform compatibility string for i.MX6 Dual
...
i.MX6 Dual boot was broken since r308533 because ofw_bus_node_is_compatible
is more strict than fdt_is_compatible and does not accept partial matches
2016-12-13 03:26:12 +00:00
Devin Teske
f3a8471e5f
It's completely pointless to replace newlines with space
...
(this is done automatically for you upon shell expansion)
2016-12-13 02:56:52 +00:00
Devin Teske
be094a3204
The flags of a WLAN need to be quoted (they contain things like brackets)
2016-12-13 02:54:44 +00:00
Devin Teske
19dbb0ba18
Simplify single-line if statements
2016-12-13 02:48:14 +00:00
Devin Teske
afcce2f52d
Simplify loop by moving predicate to clause
2016-12-13 02:47:39 +00:00
Devin Teske
b46ca7cefe
Wordsmithing
2016-12-13 02:46:36 +00:00
Devin Teske
a9d334210f
Why test $? when you can test the command
2016-12-13 02:45:52 +00:00
Devin Teske
6ef8ca674f
Restore previous comment
2016-12-13 02:45:07 +00:00
Devin Teske
94f5aec600
Both simplify bringup of interface after changes and catch errors in debug
2016-12-13 02:44:33 +00:00
Devin Teske
b9f60aba8b
Calculate proper size of menu list dialog
2016-12-13 02:42:10 +00:00
Devin Teske
9a46c67aed
There's an API function for catching errors and displaying them or
...
logging them to debug output
2016-12-13 02:40:54 +00:00
Devin Teske
7e1166de96
There's an API function for displaying pauses
2016-12-13 02:30:24 +00:00
Devin Teske
d79a135578
There's an API function for displaying yes/no dialogs
2016-12-13 02:29:20 +00:00
Devin Teske
1d92999c48
There's an API function for displaying errors
2016-12-13 02:27:38 +00:00
Devin Teske
35af83c188
Comment
2016-12-13 02:25:23 +00:00
Devin Teske
b45548a80e
Whitespace alignment
2016-12-13 02:23:48 +00:00
Devin Teske
d5fddc4dcb
Relying on dialog auto-sizing (width/height/rows = 0) is a mistake
...
Use the provided API for calculating the appropriate size of menus
2016-12-13 02:22:21 +00:00
Devin Teske
7599c85424
Remove unnecessary quotes
2016-12-13 02:16:00 +00:00
Devin Teske
1095816ec3
Add missing quotes
2016-12-13 02:15:36 +00:00
Devin Teske
01a2404c35
In awk, if you're going to append a newline to your printf
...
AND you're going to print only the argument, just use print
2016-12-13 02:14:40 +00:00
Devin Teske
dba958af5d
This statement has too many backslashes
2016-12-13 02:13:20 +00:00
Devin Teske
be34885e2a
Neither printf (and as is commonly known) nor print need parens in awk
2016-12-13 02:12:00 +00:00
Devin Teske
5943bcd19f
Whitespace and alignment
2016-12-13 02:11:09 +00:00
Devin Teske
191441eed8
You don't need parentheses for awk's printf
2016-12-13 02:07:12 +00:00
Devin Teske
0724c87c95
Continued resolution of conveluted statement
...
We shouldn't be coding things like "x || (x && x) || x || x || x ..."
2016-12-13 02:04:50 +00:00
Devin Teske
32c34b0361
These two error messages have always been backwards since inception
2016-12-13 02:02:14 +00:00
Devin Teske
7f513d3675
Why use $? when you can use the command itself
2016-12-13 01:59:35 +00:00
Devin Teske
6b77f63e5d
If the first ping succeeded, why on Earth should we ping it again?
2016-12-13 01:56:28 +00:00
Devin Teske
a1a6fec1c7
Start deconstructing a conveluted hunk of code
2016-12-13 01:54:44 +00:00
Devin Teske
19cae84e23
Remove completely unnecesary parentheses
2016-12-13 01:52:10 +00:00
Devin Teske
751993945a
Why repeat yourself when you can send stderr to the same place as stdout?
2016-12-13 01:50:22 +00:00
Devin Teske
66ef7d9455
Properly quote variable
2016-12-13 01:44:18 +00:00
Devin Teske
a51195769a
Use more generic f_yesno() from provided API
2016-12-13 01:42:13 +00:00
Devin Teske
f52733d46e
The output of dialog needs to be sanitized
...
for portability/compatibility requirements
2016-12-13 01:41:06 +00:00
Devin Teske
f20b7768fc
Whitespace alignment
2016-12-13 01:39:09 +00:00
Devin Teske
d401d36c04
Sort the domains
2016-12-13 01:36:46 +00:00
Devin Teske
95ee591e83
The --no-items and --stdout options are non-standard and should be avoided
...
From the dialog(1) manual:
using [--stdout] in portable scripts is not recommended
2016-12-13 01:35:26 +00:00
Devin Teske
6e038cc2eb
More efficiently make use of the exit status
2016-12-13 00:27:56 +00:00
Devin Teske
1c61211223
Stop repeating strings (centralize prompt string)
...
NB: Changes to strings now only affect a single line
2016-12-13 00:22:01 +00:00
Devin Teske
e2577019ed
Add missing backslash (no real effect; it's pedantic and correct for
...
the interpolation level)
2016-12-13 00:18:51 +00:00