freebsd kernel with SKQ
Go to file
Randall Stewart 13c0e198ca tcp: Fix bugs related to the PUSH bit and rack and an ack war
Michaels testing with UDP tunneling found an issue with the push bit, which was only partly fixed
in the last commit. The problem is the left edge gets transmitted before the adjustments are done
to the send_map, this means that right edge bits must be considered to be added only if
the entire RSM is being retransmitted.

Now syzkaller also continued to find a crash, which Michael sent me the reproducer for. Turns
out that the reproducer on default (freebsd) stack made the stack get into an ack-war with itself.
After fixing the reference issues in rack the same ack-war was found in rack (and bbr). Basically
what happens is we go into the reassembly code and lose the FIN bit. The trick here is we
should not be going into the reassembly code if tlen == 0 i.e. the peer never sent you anything.
That then gets the proper action on the FIN bit but then you end up in LAST_ACK with no
timers running. This is because the usrclosed function gets called and the FIN's and such have
already been exchanged. So when we should be entering FIN_WAIT2 (or even FIN_WAIT1) we get
stuck in LAST_ACK. Fixing this means tweaking the usrclosed function so that we properly
recognize the condition and drop into FIN_WAIT2 where a timer will allow at least TP_MAXIDLE
before closing (to allow time for the peer to retransmit its FIN if the ack is lost). Setting the fast_finwait2
timer can speed this up in testing.

Reviewed by: mtuexen,rscheff
Sponsored by: Netflix Inc
Differential Revision:	https://reviews.freebsd.org/D30451
2021-05-25 13:23:31 -04:00
.github/workflows Enable GitHub actions CI for stable/13 as well 2021-04-20 09:51:33 +01:00
bin sh: implement persistent history storage 2021-05-10 18:57:13 +02:00
cddl Delete obsolete Solaris compat files 2021-05-24 08:48:47 -06:00
contrib import nvi 2.2.0-3bbdfe4 2021-05-21 22:51:21 +02:00
crypto kerberos.8: Replace dead link 2021-05-16 01:37:09 -04:00
etc sort: Hook NetBSD tests up to the build 2021-05-13 09:34:01 -04:00
gnu dialog: fix macro redefinition 2021-03-01 16:01:44 +01:00
include Vendor import of Gavin D. Howard's bc version 4.0.2 2021-05-12 07:35:58 +02:00
kerberos5 kerberos5: fix the WITH_OPENLDAP build 2021-01-30 00:07:50 -06:00
lib ptrace: add an option to not kill debuggees on debugger exit 2021-05-25 18:22:34 +03:00
libexec rc.d: connect sysctl_lastload 2021-05-20 11:51:31 +07:00
release sys/*/conf/*, docs: fix links to handbook 2021-05-20 09:27:10 +01:00
rescue ping: add a ping6 hard link for backwards compatibility 2020-11-26 18:33:04 +00:00
sbin fsdb: add missing bufinit() call 2021-05-25 09:42:10 -07:00
secure pkgbase: Put openssl in its own package 2021-05-13 17:42:29 +02:00
share man5/{hosts,resolver}.5: note that IPv6 addresses are allowed. 2021-05-25 16:23:20 +01:00
stand loader: gfx_fb_drawrect should use GfxFbBltVideoFill 2021-05-16 11:22:37 +03:00
sys tcp: Fix bugs related to the PUSH bit and rack and an ack war 2021-05-25 13:23:31 -04:00
targets Remove kgmon(8) 2021-04-04 00:50:28 +03:00
tests pf tests: Test cases for fragment reassembly 2021-05-25 15:26:27 +02:00
tools [athstats] Add a tag to listen for beacon stuff 2021-05-22 15:54:44 -07:00
usr.bin usr.bin/chpass: Correct manpage regarding path to temp files 2021-05-25 16:23:20 +01:00
usr.sbin cxgbetool(8): add a 'clip' subcommand to deal with the CLIP table. 2021-05-23 16:28:31 -07:00
.arcconfig Remove history.immutable from .arcconfig 2021-04-13 12:36:25 +01:00
.arclint arc lint: ignore /tests/ in chmod 2017-12-19 03:38:06 +00:00
.cirrus.yml Restore Cirrus-CI boot smoke test 2021-05-05 10:05:58 -04:00
.clang-format clang-format: Avoid breaking after the opening paren of function definitions 2020-10-28 11:54:00 +00:00
.gitattributes Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitignore import nvi 2.2.0-3bbdfe4 2021-05-19 13:35:56 +02:00
COPYRIGHT copyrights: Happy New Year 2021 2020-12-31 10:29:44 -05:00
LOCKS LOCKS: update current locks 2018-06-09 03:08:04 +00:00
MAINTAINERS Add a pointer to csprng@ for the CSPRNG driver. This is enforced anyway by 2020-09-01 08:02:12 +00:00
Makefile Fix 'make bmake' top-level bootstrapping. 2021-03-06 09:45:08 -08:00
Makefile.inc1 Add elfctl to toolchain. 2021-05-21 15:32:42 +02:00
Makefile.libcompat libcompat: remove redundant path for ncurses 2021-01-07 15:14:52 +01:00
Makefile.sys.inc AUTO_OBJ: For all top-level targets enforce using an OBJDIR. 2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc Correct location of libcap_random.so in ObsoleteFiles.inc 2021-05-12 20:34:23 +02:00
README.md Whitespace cleanup 2021-03-12 19:57:58 +08:00
RELNOTES Spellcheck. 2021-04-12 15:12:19 -07:00
UPDATING sys/*/conf/*, docs: fix links to handbook 2021-05-20 09:27:10 +01:00

FreeBSD Source:

This is the top level of the FreeBSD source directory.

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), FreeBSD handbook on building userland, and Handbook for kernels for more information, including setting make(1) variables.

Source Roadmap:

Directory Description
bin System/user commands.
cddl Various commands and libraries under the Common Development and Distribution License.
contrib Packages contributed by 3rd parties.
crypto Cryptography stuff (see crypto/README).
etc Template files for /etc.
gnu Various commands and libraries under the GNU Public License. Please see gnu/COPYING and gnu/COPYING.LIB for more information.
include System include files.
kerberos5 Kerberos5 (Heimdal) package.
lib System libraries.
libexec System daemons.
release Release building Makefile & associated tools.
rescue Build system for statically linked /rescue utilities.
sbin System commands.
secure Cryptographic libraries and commands.
share Shared resources.
stand Boot loader sources.
sys Kernel sources.
sys/arch/conf Kernel configuration files. GENERIC is the configuration used in release builds. NOTES contains documentation of all possible entries.
tests Regression tests which can be run by Kyua. See tests/README for additional information.
tools Utilities for regression testing and miscellaneous tasks.
usr.bin User commands.
usr.sbin System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see FreeBSD Handbook.