Daniel Hartmeier 7f368082ad When checking the sequence number of a TCP header embedded in an ... ICMP error message, do not access th_flags. The field is beyond the first eight bytes of the header that are required to be present and were pulled up in the mbuf. A random value of th_flags can have TH_SYN set, which made the sequence number comparison not apply the window scaling factor, which led to legitimate ICMP(v6) packets getting blocked with "BAD ICMP" debug log messages (if enabled with pfctl -xm), thus breaking PMTU discovery. Triggering the bug requires TCP window scaling to be enabled (sysctl net.inet.tcp.rfc1323, enabled by default) on both end- points of the TCP connection. Large scaling factors increase the probability of triggering the bug. PR: kern/115413: [ipv6] ipv6 pmtu not working Tested by: Jacek Zapala Reviewed by: mlaier Approved by: re (kensmith)		2007-08-23 09:30:58 +00:00
..
net	When checking the sequence number of a TCP header embedded in an	2007-08-23 09:30:58 +00:00
netinet	Use in_cksum_skip() to calculate in4_cksum instead of doing handrolled magic	2004-08-05 20:41:38 +00:00