numam-dpdk/app/test-pmd
Huisong Li 08dcd18706 app/testpmd: fix queue stats mapping configuration
Currently, the queue stats mapping has the following problems:
1) Many PMD drivers don't support queue stats mapping. But there is no
   failure message after executing the command "set stat_qmap rx 0 2 2".
2) Once queue mapping is set, unrelated and unmapped queues are also
   displayed.
3) The configuration result does not take effect or can not be queried
   in real time.
4) The mapping arrays, "tx_queue_stats_mappings_array" &
   "rx_queue_stats_mappings_array" are global and their sizes are based
   on fixed max port and queue size assumptions.
5) These record structures, 'map_port_queue_stats_mapping_registers()'
   and its sub functions are redundant for majority of drivers.
6) The display of the queue stats and queue stats mapping is mixed
   together.

Since xstats is used to obtain queue statistics, we have made the
following simplifications and adjustments:
1) If PMD requires and supports queue stats mapping, configure to driver
   in real time by calling ethdev API after executing the command "set
   stat_qmap rx/tx ...". If not, the command can not be accepted.
2) Based on the above adjustments, these record structures,
   'map_port_queue_stats_mapping_registers()' and its sub functions can
   be removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping"
   parameters, and 'parse_queue_stats_mapping_config()' can be removed
   too.
3) remove display of queue stats mapping in 'fwd_stats_display()' &
   'nic_stats_display()', and obtain queue stats by xstats.  Since the
   record structures are removed, 'nic_stats_mapping_display()' can be
   deleted.

Fixes: 4dccdc789b ("app/testpmd: simplify handling of stats mappings error")
Fixes: 013af9b6b6 ("app/testpmd: various updates")
Fixes: ed30d9b691 ("app/testpmd: add stats per queue")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2021-01-08 16:03:04 +01:00
..
5tswap.c net: add function to calculate IPv4 header length 2020-10-16 19:48:17 +02:00
bpf_cmd.c cmdline: avoid name clash with Windows system types 2020-11-05 17:49:00 +01:00
bpf_cmd.h build: replace use of old build macros 2020-10-19 22:15:44 +02:00
cmdline_flow.c app/testpmd: fix flow tunnel commands 2020-11-20 21:10:05 +01:00
cmdline_mtr.c cmdline: avoid name clash with Windows system types 2020-11-05 17:49:00 +01:00
cmdline_mtr.h app/testpmd: add commands for metering and policing 2018-01-10 00:51:31 +01:00
cmdline_tm.c cmdline: avoid name clash with Windows system types 2020-11-05 17:49:00 +01:00
cmdline_tm.h app/testpmd: add TM command for non-leaf and packet mode 2020-09-18 18:55:10 +02:00
cmdline.c app/testpmd: fix queue stats mapping configuration 2021-01-08 16:03:04 +01:00
config.c app/testpmd: fix queue stats mapping configuration 2021-01-08 16:03:04 +01:00
csumonly.c gso: fix mbuf freeing responsibility 2020-11-03 22:45:02 +01:00
flowgen.c app/testpmd: add record-burst-stats runtime config 2020-09-18 18:55:08 +02:00
icmpecho.c app/testpmd: add record-burst-stats runtime config 2020-09-18 18:55:08 +02:00
ieee1588fwd.c net: add rte prefix to ether defines 2019-05-24 13:34:45 +02:00
iofwd.c app/testpmd: add record-burst-stats runtime config 2020-09-18 18:55:08 +02:00
macfwd.c app/testpmd: add record-burst-stats runtime config 2020-09-18 18:55:08 +02:00
macswap_common.h net: add rte prefix to IP structure 2019-05-24 13:34:46 +02:00
macswap_neon.h net: add rte prefix to ether structures 2019-05-24 13:34:45 +02:00
macswap_sse.h net: add rte prefix to ether structures 2019-05-24 13:34:45 +02:00
macswap.c build: remove deprecated cpuflag macros 2020-09-25 11:13:57 +02:00
macswap.h net: add rte prefix to ether functions 2019-05-24 13:34:45 +02:00
meson.build build: replace use of old build macros 2020-10-19 22:15:44 +02:00
noisy_vnf.c app/testpmd: enable burst stats for noisy VNF mode 2020-09-18 18:55:08 +02:00
parameters.c app/testpmd: fix queue stats mapping configuration 2021-01-08 16:03:04 +01:00
rxonly.c app/testpmd: add record-burst-stats runtime config 2020-09-18 18:55:08 +02:00
testpmd.c app/testpmd: fix queue stats mapping configuration 2021-01-08 16:03:04 +01:00
testpmd.h app/testpmd: fix queue stats mapping configuration 2021-01-08 16:03:04 +01:00
txonly.c app/testpmd: fix packet header in txonly mode 2020-09-30 19:19:13 +02:00
util.c app/testpmd: switch Rx timestamp to dynamic mbuf field 2020-11-03 16:21:15 +01:00