numam-dpdk/app/test-pmd
Ferruh Yigit 1bb4a528c4 ethdev: fix max Rx packet length
There is a confusion on setting max Rx packet length, this patch aims to
clarify it.

'rte_eth_dev_configure()' API accepts max Rx packet size via
'uint32_t max_rx_pkt_len' field of the config struct 'struct
rte_eth_conf'.

Also 'rte_eth_dev_set_mtu()' API can be used to set the MTU, and result
stored into '(struct rte_eth_dev)->data->mtu'.

These two APIs are related but they work in a disconnected way, they
store the set values in different variables which makes hard to figure
out which one to use, also having two different method for a related
functionality is confusing for the users.

Other issues causing confusion is:
* maximum transmission unit (MTU) is payload of the Ethernet frame. And
  'max_rx_pkt_len' is the size of the Ethernet frame. Difference is
  Ethernet frame overhead, and this overhead may be different from
  device to device based on what device supports, like VLAN and QinQ.
* 'max_rx_pkt_len' is only valid when application requested jumbo frame,
  which adds additional confusion and some APIs and PMDs already
  discards this documented behavior.
* For the jumbo frame enabled case, 'max_rx_pkt_len' is an mandatory
  field, this adds configuration complexity for application.

As solution, both APIs gets MTU as parameter, and both saves the result
in same variable '(struct rte_eth_dev)->data->mtu'. For this
'max_rx_pkt_len' updated as 'mtu', and it is always valid independent
from jumbo frame.

For 'rte_eth_dev_configure()', 'dev->data->dev_conf.rxmode.mtu' is user
request and it should be used only within configure function and result
should be stored to '(struct rte_eth_dev)->data->mtu'. After that point
both application and PMD uses MTU from this variable.

When application doesn't provide an MTU during 'rte_eth_dev_configure()'
default 'RTE_ETHER_MTU' value is used.

Additional clarification done on scattered Rx configuration, in
relation to MTU and Rx buffer size.
MTU is used to configure the device for physical Rx/Tx size limitation,
Rx buffer is where to store Rx packets, many PMDs use mbuf data buffer
size as Rx buffer size.
PMDs compare MTU against Rx buffer size to decide enabling scattered Rx
or not. If scattered Rx is not supported by device, MTU bigger than Rx
buffer size should fail.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
Acked-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
Acked-by: Hyong Youb Kim <hyonkim@cisco.com>
2021-10-18 19:20:20 +02:00
..
5tswap.c net: rename Ethernet header fields 2021-10-08 14:58:11 +02:00
bpf_cmd.c app/testpmd: send failure logs to stderr 2021-07-24 15:12:57 +02:00
bpf_cmd.h build: replace use of old build macros 2020-10-19 22:15:44 +02:00
cmdline_flow.c app/testpmd: fix hex string parser in flow commands 2021-10-14 14:34:31 +02:00
cmdline_mtr.c app/testpmd: send failure logs to stderr 2021-07-24 15:12:57 +02:00
cmdline_mtr.h app/testpmd: support policy actions per color 2021-04-21 12:22:18 +02:00
cmdline_tm.c app/testpmd: send failure logs to stderr 2021-07-24 15:12:57 +02:00
cmdline_tm.h app/testpmd: add TM command for non-leaf and packet mode 2020-09-18 18:55:10 +02:00
cmdline.c ethdev: fix max Rx packet length 2021-10-18 19:20:20 +02:00
config.c ethdev: fix max Rx packet length 2021-10-18 19:20:20 +02:00
csumonly.c net: rename Ethernet header fields 2021-10-08 14:58:11 +02:00
flowgen.c app/testpmd: update forward engine beginning 2021-10-08 18:57:48 +02:00
icmpecho.c net: rename Ethernet header fields 2021-10-08 14:58:11 +02:00
ieee1588fwd.c app/testpmd: update forward engine beginning 2021-10-08 18:57:48 +02:00
iofwd.c app/testpmd: add record-burst-stats runtime config 2020-09-18 18:55:08 +02:00
macfwd.c net: rename Ethernet header fields 2021-10-08 14:58:11 +02:00
macswap_common.h net: add rte prefix to IP structure 2019-05-24 13:34:46 +02:00
macswap_neon.h net: add rte prefix to ether structures 2019-05-24 13:34:45 +02:00
macswap_sse.h net: add rte prefix to ether structures 2019-05-24 13:34:45 +02:00
macswap.c build: remove deprecated cpuflag macros 2020-09-25 11:13:57 +02:00
macswap.h net: rename Ethernet header fields 2021-10-08 14:58:11 +02:00
meson.build app: reduce indentation in build files 2021-04-21 14:04:09 +02:00
noisy_vnf.c app/testpmd: update forward engine beginning 2021-10-08 18:57:48 +02:00
parameters.c ethdev: fix max Rx packet length 2021-10-18 19:20:20 +02:00
rxonly.c app/testpmd: add record-burst-stats runtime config 2020-09-18 18:55:08 +02:00
testpmd.c ethdev: fix max Rx packet length 2021-10-18 19:20:20 +02:00
testpmd.h ethdev: fix max Rx packet length 2021-10-18 19:20:20 +02:00
txonly.c app/testpmd: fix txonly forwarding 2021-10-08 18:57:48 +02:00
util.c app/testpmd: fix RSS hash offload display 2021-10-15 13:27:05 +02:00