numam-dpdk/app/test/test_kni.c
Min Hu (Connor) 381dfcf047 test/kni: check init result
Return value 'rte_kni_init' of a function is not checked. If
it fails, error handling (logging and return) should be done.

This patch fixed it.

Fixes: 0c6bc8ef70 ("kni: memzone pool for alloc and release")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2021-04-26 15:33:07 +02:00

771 lines
17 KiB
C

/* SPDX-License-Identifier: BSD-3-Clause
* Copyright(c) 2010-2014 Intel Corporation
*/
#include <stdio.h>
#include <stdint.h>
#include <unistd.h>
#include <string.h>
#include <sys/wait.h>
#include <dirent.h>
#include "test.h"
#if !defined(RTE_EXEC_ENV_LINUX) || !defined(RTE_LIB_KNI)
static int
test_kni(void)
{
printf("KNI not supported, skipping test\n");
return TEST_SKIPPED;
}
#else
#include <rte_string_fns.h>
#include <rte_mempool.h>
#include <rte_ethdev.h>
#include <rte_bus_pci.h>
#include <rte_cycles.h>
#include <rte_kni.h>
#define NB_MBUF 8192
#define MAX_PACKET_SZ 2048
#define MBUF_DATA_SZ (MAX_PACKET_SZ + RTE_PKTMBUF_HEADROOM)
#define PKT_BURST_SZ 32
#define MEMPOOL_CACHE_SZ PKT_BURST_SZ
#define SOCKET 0
#define NB_RXD 1024
#define NB_TXD 1024
#define KNI_TIMEOUT_MS 5000 /* ms */
#define IFCONFIG "/sbin/ifconfig "
#define TEST_KNI_PORT "test_kni_port"
#define KNI_MODULE_PATH "/sys/module/rte_kni"
#define KNI_MODULE_PARAM_LO KNI_MODULE_PATH"/parameters/lo_mode"
#define KNI_TEST_MAX_PORTS 4
/* The threshold number of mbufs to be transmitted or received. */
#define KNI_NUM_MBUF_THRESHOLD 100
static int kni_pkt_mtu = 0;
struct test_kni_stats {
volatile uint64_t ingress;
volatile uint64_t egress;
};
static const struct rte_eth_rxconf rx_conf = {
.rx_thresh = {
.pthresh = 8,
.hthresh = 8,
.wthresh = 4,
},
.rx_free_thresh = 0,
};
static const struct rte_eth_txconf tx_conf = {
.tx_thresh = {
.pthresh = 36,
.hthresh = 0,
.wthresh = 0,
},
.tx_free_thresh = 0,
.tx_rs_thresh = 0,
};
static const struct rte_eth_conf port_conf = {
.txmode = {
.mq_mode = ETH_DCB_NONE,
},
};
static struct rte_kni_ops kni_ops = {
.change_mtu = NULL,
.config_network_if = NULL,
.config_mac_address = NULL,
.config_promiscusity = NULL,
};
static unsigned int lcore_main, lcore_ingress, lcore_egress;
static struct rte_kni *test_kni_ctx;
static struct test_kni_stats stats;
static volatile uint32_t test_kni_processing_flag;
static struct rte_mempool *
test_kni_create_mempool(void)
{
struct rte_mempool * mp;
mp = rte_mempool_lookup("kni_mempool");
if (!mp)
mp = rte_pktmbuf_pool_create("kni_mempool",
NB_MBUF,
MEMPOOL_CACHE_SZ, 0, MBUF_DATA_SZ,
SOCKET);
return mp;
}
static struct rte_mempool *
test_kni_lookup_mempool(void)
{
return rte_mempool_lookup("kni_mempool");
}
/* Callback for request of changing MTU */
static int
kni_change_mtu(uint16_t port_id, unsigned int new_mtu)
{
printf("Change MTU of port %d to %u\n", port_id, new_mtu);
kni_pkt_mtu = new_mtu;
printf("Change MTU of port %d to %i successfully.\n",
port_id, kni_pkt_mtu);
return 0;
}
static int
test_kni_link_change(void)
{
int ret;
int pid;
pid = fork();
if (pid < 0) {
printf("Error: Failed to fork a process\n");
return -1;
}
if (pid == 0) {
printf("Starting KNI Link status change tests.\n");
if (system(IFCONFIG TEST_KNI_PORT" up") == -1) {
ret = -1;
goto error;
}
ret = rte_kni_update_link(test_kni_ctx, 1);
if (ret < 0) {
printf("Failed to change link state to Up ret=%d.\n",
ret);
goto error;
}
rte_delay_ms(1000);
printf("KNI: Set LINKUP, previous state=%d\n", ret);
ret = rte_kni_update_link(test_kni_ctx, 0);
if (ret != 1) {
printf(
"Failed! Previous link state should be 1, returned %d.\n",
ret);
goto error;
}
rte_delay_ms(1000);
printf("KNI: Set LINKDOWN, previous state=%d\n", ret);
ret = rte_kni_update_link(test_kni_ctx, 1);
if (ret != 0) {
printf(
"Failed! Previous link state should be 0, returned %d.\n",
ret);
goto error;
}
printf("KNI: Set LINKUP, previous state=%d\n", ret);
ret = 0;
rte_delay_ms(1000);
error:
if (system(IFCONFIG TEST_KNI_PORT" down") == -1)
ret = -1;
printf("KNI: Link status change tests: %s.\n",
(ret == 0) ? "Passed" : "Failed");
exit(ret);
} else {
int p_ret, status;
while (1) {
p_ret = waitpid(pid, &status, WNOHANG);
if (p_ret != 0) {
if (WIFEXITED(status))
return WEXITSTATUS(status);
return -1;
}
rte_delay_ms(10);
rte_kni_handle_request(test_kni_ctx);
}
}
}
/**
* This loop fully tests the basic functions of KNI. e.g. transmitting,
* receiving to, from kernel space, and kernel requests.
*
* This is the loop to transmit/receive mbufs to/from kernel interface with
* supported by KNI kernel module. The ingress lcore will allocate mbufs and
* transmit them to kernel space; while the egress lcore will receive the mbufs
* from kernel space and free them.
* On the main lcore, several commands will be run to check handling the
* kernel requests. And it will finally set the flag to exit the KNI
* transmitting/receiving to/from the kernel space.
*
* Note: To support this testing, the KNI kernel module needs to be insmodded
* in one of its loopback modes.
*/
static int
test_kni_loop(__rte_unused void *arg)
{
int ret = 0;
unsigned nb_rx, nb_tx, num, i;
const unsigned lcore_id = rte_lcore_id();
struct rte_mbuf *pkts_burst[PKT_BURST_SZ];
if (lcore_id == lcore_main) {
rte_delay_ms(KNI_TIMEOUT_MS);
/* tests of handling kernel request */
if (system(IFCONFIG TEST_KNI_PORT" up") == -1)
ret = -1;
if (system(IFCONFIG TEST_KNI_PORT" mtu 1400") == -1)
ret = -1;
if (system(IFCONFIG TEST_KNI_PORT" down") == -1)
ret = -1;
rte_delay_ms(KNI_TIMEOUT_MS);
test_kni_processing_flag = 1;
} else if (lcore_id == lcore_ingress) {
struct rte_mempool *mp = test_kni_lookup_mempool();
if (mp == NULL)
return -1;
while (1) {
if (test_kni_processing_flag)
break;
for (nb_rx = 0; nb_rx < PKT_BURST_SZ; nb_rx++) {
pkts_burst[nb_rx] = rte_pktmbuf_alloc(mp);
if (!pkts_burst[nb_rx])
break;
}
num = rte_kni_tx_burst(test_kni_ctx, pkts_burst,
nb_rx);
stats.ingress += num;
rte_kni_handle_request(test_kni_ctx);
if (num < nb_rx) {
for (i = num; i < nb_rx; i++) {
rte_pktmbuf_free(pkts_burst[i]);
}
}
rte_delay_ms(10);
}
} else if (lcore_id == lcore_egress) {
while (1) {
if (test_kni_processing_flag)
break;
num = rte_kni_rx_burst(test_kni_ctx, pkts_burst,
PKT_BURST_SZ);
stats.egress += num;
for (nb_tx = 0; nb_tx < num; nb_tx++)
rte_pktmbuf_free(pkts_burst[nb_tx]);
rte_delay_ms(10);
}
}
return ret;
}
static int
test_kni_allocate_lcores(void)
{
unsigned i, count = 0;
lcore_main = rte_get_main_lcore();
printf("main lcore: %u\n", lcore_main);
for (i = 0; i < RTE_MAX_LCORE; i++) {
if (count >=2 )
break;
if (rte_lcore_is_enabled(i) && i != lcore_main) {
count ++;
if (count == 1)
lcore_ingress = i;
else if (count == 2)
lcore_egress = i;
}
}
printf("count: %u\n", count);
return count == 2 ? 0 : -1;
}
static int
test_kni_register_handler_mp(void)
{
#define TEST_KNI_HANDLE_REQ_COUNT 10 /* 5s */
#define TEST_KNI_HANDLE_REQ_INTERVAL 500 /* ms */
#define TEST_KNI_MTU 1450
#define TEST_KNI_MTU_STR " 1450"
int pid;
pid = fork();
if (pid < 0) {
printf("Failed to fork a process\n");
return -1;
} else if (pid == 0) {
int i;
struct rte_kni *kni = rte_kni_get(TEST_KNI_PORT);
struct rte_kni_ops ops = {
.change_mtu = kni_change_mtu,
.config_network_if = NULL,
.config_mac_address = NULL,
.config_promiscusity = NULL,
};
if (!kni) {
printf("Failed to get KNI named %s\n", TEST_KNI_PORT);
exit(-1);
}
kni_pkt_mtu = 0;
/* Check with the invalid parameters */
if (rte_kni_register_handlers(kni, NULL) == 0) {
printf("Unexpectedly register successuflly "
"with NULL ops pointer\n");
exit(-1);
}
if (rte_kni_register_handlers(NULL, &ops) == 0) {
printf("Unexpectedly register successfully "
"to NULL KNI device pointer\n");
exit(-1);
}
if (rte_kni_register_handlers(kni, &ops)) {
printf("Fail to register ops\n");
exit(-1);
}
/* Check registering again after it has been registered */
if (rte_kni_register_handlers(kni, &ops) == 0) {
printf("Unexpectedly register successfully after "
"it has already been registered\n");
exit(-1);
}
/**
* Handle the request of setting MTU,
* with registered handlers.
*/
for (i = 0; i < TEST_KNI_HANDLE_REQ_COUNT; i++) {
rte_kni_handle_request(kni);
if (kni_pkt_mtu == TEST_KNI_MTU)
break;
rte_delay_ms(TEST_KNI_HANDLE_REQ_INTERVAL);
}
if (i >= TEST_KNI_HANDLE_REQ_COUNT) {
printf("MTU has not been set\n");
exit(-1);
}
kni_pkt_mtu = 0;
if (rte_kni_unregister_handlers(kni) < 0) {
printf("Fail to unregister ops\n");
exit(-1);
}
/* Check with invalid parameter */
if (rte_kni_unregister_handlers(NULL) == 0) {
exit(-1);
}
/**
* Handle the request of setting MTU,
* without registered handlers.
*/
for (i = 0; i < TEST_KNI_HANDLE_REQ_COUNT; i++) {
rte_kni_handle_request(kni);
if (kni_pkt_mtu != 0)
break;
rte_delay_ms(TEST_KNI_HANDLE_REQ_INTERVAL);
}
if (kni_pkt_mtu != 0) {
printf("MTU shouldn't be set\n");
exit(-1);
}
exit(0);
} else {
int p_ret, status;
rte_delay_ms(1000);
if (system(IFCONFIG TEST_KNI_PORT " mtu" TEST_KNI_MTU_STR)
== -1)
return -1;
rte_delay_ms(1000);
if (system(IFCONFIG TEST_KNI_PORT " mtu" TEST_KNI_MTU_STR)
== -1)
return -1;
p_ret = wait(&status);
if (!WIFEXITED(status)) {
printf("Child process (%d) exit abnormally\n", p_ret);
return -1;
}
if (WEXITSTATUS(status) != 0) {
printf("Child process exit with failure\n");
return -1;
}
}
return 0;
}
static int
test_kni_processing(uint16_t port_id, struct rte_mempool *mp)
{
int ret = 0;
unsigned i;
struct rte_kni *kni;
struct rte_kni_conf conf;
struct rte_eth_dev_info info;
struct rte_kni_ops ops;
const struct rte_pci_device *pci_dev;
const struct rte_bus *bus = NULL;
if (!mp)
return -1;
memset(&conf, 0, sizeof(conf));
memset(&info, 0, sizeof(info));
memset(&ops, 0, sizeof(ops));
ret = rte_eth_dev_info_get(port_id, &info);
if (ret != 0) {
printf("Error during getting device (port %u) info: %s\n",
port_id, strerror(-ret));
return -1;
}
if (info.device)
bus = rte_bus_find_by_device(info.device);
if (bus && !strcmp(bus->name, "pci")) {
pci_dev = RTE_DEV_TO_PCI(info.device);
conf.addr = pci_dev->addr;
conf.id = pci_dev->id;
}
snprintf(conf.name, sizeof(conf.name), TEST_KNI_PORT);
/* core id 1 configured for kernel thread */
conf.core_id = 1;
conf.force_bind = 1;
conf.mbuf_size = MAX_PACKET_SZ;
conf.group_id = port_id;
ops = kni_ops;
ops.port_id = port_id;
/* basic test of kni processing */
kni = rte_kni_alloc(mp, &conf, &ops);
if (!kni) {
printf("fail to create kni\n");
return -1;
}
test_kni_ctx = kni;
test_kni_processing_flag = 0;
stats.ingress = 0;
stats.egress = 0;
/**
* Check multiple processes support on
* registerring/unregisterring handlers.
*/
if (test_kni_register_handler_mp() < 0) {
printf("fail to check multiple process support\n");
ret = -1;
goto fail_kni;
}
ret = test_kni_link_change();
if (ret != 0)
goto fail_kni;
rte_eal_mp_remote_launch(test_kni_loop, NULL, CALL_MAIN);
RTE_LCORE_FOREACH_WORKER(i) {
if (rte_eal_wait_lcore(i) < 0) {
ret = -1;
goto fail_kni;
}
}
/**
* Check if the number of mbufs received from kernel space is equal
* to that of transmitted to kernel space
*/
if (stats.ingress < KNI_NUM_MBUF_THRESHOLD ||
stats.egress < KNI_NUM_MBUF_THRESHOLD) {
printf("The ingress/egress number should not be "
"less than %u\n", (unsigned)KNI_NUM_MBUF_THRESHOLD);
ret = -1;
goto fail_kni;
}
if (rte_kni_release(kni) < 0) {
printf("fail to release kni\n");
return -1;
}
test_kni_ctx = NULL;
/* test of reusing memzone */
kni = rte_kni_alloc(mp, &conf, &ops);
if (!kni) {
printf("fail to create kni\n");
return -1;
}
/* Release the kni for following testing */
if (rte_kni_release(kni) < 0) {
printf("fail to release kni\n");
return -1;
}
return ret;
fail_kni:
if (rte_kni_release(kni) < 0) {
printf("fail to release kni\n");
ret = -1;
}
return ret;
}
static int
test_kni(void)
{
int ret = -1;
uint16_t port_id;
struct rte_kni *kni;
struct rte_mempool *mp;
struct rte_kni_conf conf;
struct rte_eth_dev_info info;
struct rte_kni_ops ops;
const struct rte_pci_device *pci_dev;
const struct rte_bus *bus;
FILE *fd;
DIR *dir;
char buf[16];
dir = opendir(KNI_MODULE_PATH);
if (!dir) {
if (errno == ENOENT) {
printf("Cannot run UT due to missing rte_kni module\n");
return TEST_SKIPPED;
}
printf("opendir: %s", strerror(errno));
return -1;
}
closedir(dir);
/* Initialize KNI subsystem */
ret = rte_kni_init(KNI_TEST_MAX_PORTS);
if (ret < 0) {
printf("fail to initialize KNI subsystem\n");
return -1;
}
if (test_kni_allocate_lcores() < 0) {
printf("No enough lcores for kni processing\n");
return -1;
}
mp = test_kni_create_mempool();
if (!mp) {
printf("fail to create mempool for kni\n");
return -1;
}
/* configuring port 0 for the test is enough */
port_id = 0;
ret = rte_eth_dev_configure(port_id, 1, 1, &port_conf);
if (ret < 0) {
printf("fail to configure port %d\n", port_id);
return -1;
}
ret = rte_eth_rx_queue_setup(port_id, 0, NB_RXD, SOCKET, &rx_conf, mp);
if (ret < 0) {
printf("fail to setup rx queue for port %d\n", port_id);
return -1;
}
ret = rte_eth_tx_queue_setup(port_id, 0, NB_TXD, SOCKET, &tx_conf);
if (ret < 0) {
printf("fail to setup tx queue for port %d\n", port_id);
return -1;
}
ret = rte_eth_dev_start(port_id);
if (ret < 0) {
printf("fail to start port %d\n", port_id);
return -1;
}
ret = rte_eth_promiscuous_enable(port_id);
if (ret != 0) {
printf("fail to enable promiscuous mode for port %d: %s\n",
port_id, rte_strerror(-ret));
return -1;
}
/* basic test of kni processing */
fd = fopen(KNI_MODULE_PARAM_LO, "r");
if (fd == NULL) {
printf("fopen: %s", strerror(errno));
return -1;
}
memset(&buf, 0, sizeof(buf));
if (fgets(buf, sizeof(buf), fd)) {
if (!strncmp(buf, "lo_mode_fifo", strlen("lo_mode_fifo")) ||
!strncmp(buf, "lo_mode_fifo_skb",
strlen("lo_mode_fifo_skb"))) {
ret = test_kni_processing(port_id, mp);
if (ret < 0) {
fclose(fd);
goto fail;
}
} else
printf("test_kni_processing skipped because of missing rte_kni module lo_mode argument\n");
}
fclose(fd);
/* test of allocating KNI with NULL mempool pointer */
memset(&info, 0, sizeof(info));
memset(&conf, 0, sizeof(conf));
memset(&ops, 0, sizeof(ops));
ret = rte_eth_dev_info_get(port_id, &info);
if (ret != 0) {
printf("Error during getting device (port %u) info: %s\n",
port_id, strerror(-ret));
return -1;
}
if (info.device)
bus = rte_bus_find_by_device(info.device);
else
bus = NULL;
if (bus && !strcmp(bus->name, "pci")) {
pci_dev = RTE_DEV_TO_PCI(info.device);
conf.addr = pci_dev->addr;
conf.id = pci_dev->id;
}
conf.group_id = port_id;
conf.mbuf_size = MAX_PACKET_SZ;
ops = kni_ops;
ops.port_id = port_id;
kni = rte_kni_alloc(NULL, &conf, &ops);
if (kni) {
ret = -1;
printf("unexpectedly creates kni successfully with NULL "
"mempool pointer\n");
goto fail;
}
/* test of allocating KNI without configurations */
kni = rte_kni_alloc(mp, NULL, NULL);
if (kni) {
ret = -1;
printf("Unexpectedly allocate KNI device successfully "
"without configurations\n");
goto fail;
}
/* test of allocating KNI without a name */
memset(&conf, 0, sizeof(conf));
memset(&info, 0, sizeof(info));
memset(&ops, 0, sizeof(ops));
ret = rte_eth_dev_info_get(port_id, &info);
if (ret != 0) {
printf("Error during getting device (port %u) info: %s\n",
port_id, strerror(-ret));
ret = -1;
goto fail;
}
if (info.device)
bus = rte_bus_find_by_device(info.device);
else
bus = NULL;
if (bus && !strcmp(bus->name, "pci")) {
pci_dev = RTE_DEV_TO_PCI(info.device);
conf.addr = pci_dev->addr;
conf.id = pci_dev->id;
}
conf.group_id = port_id;
conf.mbuf_size = MAX_PACKET_SZ;
ops = kni_ops;
ops.port_id = port_id;
kni = rte_kni_alloc(mp, &conf, &ops);
if (kni) {
ret = -1;
printf("Unexpectedly allocate a KNI device successfully "
"without a name\n");
goto fail;
}
/* test of releasing NULL kni context */
ret = rte_kni_release(NULL);
if (ret == 0) {
ret = -1;
printf("unexpectedly release kni successfully\n");
goto fail;
}
/* test of handling request on NULL device pointer */
ret = rte_kni_handle_request(NULL);
if (ret == 0) {
ret = -1;
printf("Unexpectedly handle request on NULL device pointer\n");
goto fail;
}
/* test of getting KNI device with pointer to NULL */
kni = rte_kni_get(NULL);
if (kni) {
ret = -1;
printf("Unexpectedly get a KNI device with "
"NULL name pointer\n");
goto fail;
}
/* test of getting KNI device with an zero length name string */
memset(&conf, 0, sizeof(conf));
kni = rte_kni_get(conf.name);
if (kni) {
ret = -1;
printf("Unexpectedly get a KNI device with "
"zero length name string\n");
goto fail;
}
/* test of getting KNI device with an invalid string name */
memset(&conf, 0, sizeof(conf));
snprintf(conf.name, sizeof(conf.name), "testing");
kni = rte_kni_get(conf.name);
if (kni) {
ret = -1;
printf("Unexpectedly get a KNI device with "
"a never used name string\n");
goto fail;
}
ret = 0;
fail:
if (rte_eth_dev_stop(port_id) != 0)
printf("Failed to stop port %u\n", port_id);
return ret;
}
#endif
REGISTER_TEST_COMMAND(kni_autotest, test_kni);