numam-spdk
Go to file
Tomasz Zawadzki 752ceb0c12 lib/blob: prevent overflowing uint32_t when clearing cluster data
When blob is deleted or reduced in size, the trimmed clusters
are cleared using bs_batch_clear_dev().

blob_persist_clear_clusters() iterated over the clusters
and batched each contigous set of LBA.

The lba_count is of the uint32_t type, long enough
contigous set of LBA could overflow it.
As a result that range would only be cleared with the
overflown value.

This patch prevents that overflow from occuring by
verifying against UINT32_MAX.

This is already addressed with an API change in SPDK 21.10:
(f01146ae)blob: use uint64_t for unmap and write_zeroes lba count

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I17282a2a81587c26b7e89a74dcc6a9c8a017ce15
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9971
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2021-11-17 10:55:17 +00:00
.githooks githooks/prepush: remove clang 2020-06-10 13:56:32 +00:00
.github github: automatically close pull requests 2021-01-21 21:20:53 +00:00
app spdk_top: fix app crashing on tab selection with TAB key 2021-03-10 16:22:10 +00:00
build/lib build: consolidate library outputs in build/lib 2016-11-17 13:15:09 -07:00
doc doc: added scheduler framework documentation 2021-02-01 08:04:38 +00:00
dpdk@707692e67d dpdk: update submodule to DPDK 20.11 2021-01-20 14:21:38 +00:00
dpdkbuild configure: remove --with-igb-uio-driver option 2021-01-22 08:47:48 +00:00
examples nvme/fio_plugin: remove ZBD_IGNORE usage 2021-10-27 08:47:51 +00:00
go go: empty Go package 2018-06-28 18:15:51 +00:00
include nvme: add quirks for new RedHat QEMU NVMe dev/vendor ID 2021-07-26 08:41:37 +00:00
intel-ipsec-mb@93c2ddf877 intel-ipsec-mb: update submodule to v0.54 2020-09-22 11:40:50 +00:00
ipsecbuild Makefile: don't override MAKEFLAGS in submake 2020-02-21 09:33:45 +00:00
isa-l@2df39cf5f1 isa-l: update submodule to v2.30.0 2021-01-21 19:24:10 +00:00
isalbuild Makefile: don't override MAKEFLAGS in submake 2020-02-21 09:33:45 +00:00
lib lib/blob: prevent overflowing uint32_t when clearing cluster data 2021-11-17 10:55:17 +00:00
libvfio-user@7e110c6b64 nvmf/vfio_user: update libvfio-user submodule 2021-01-25 08:08:44 +00:00
mk build/fio: disable warning for fio clang-11 builds 2021-05-10 10:45:57 +00:00
module bdev/nvme: do not use DSM to emulate write zeroes 2021-07-26 08:41:37 +00:00
ocf@02f6fc3a71 ocf: update submodule to v20.03.1 2020-08-27 08:36:29 +00:00
pkg SPDK 21.01.2-pre 2021-03-10 16:22:10 +00:00
scripts test: move spdk_test_image.qcow2 to spdk_dependencies dir 2021-10-27 08:47:51 +00:00
shared_lib build: add SO_SUFFIX for combined spdk.so library 2020-10-02 07:13:53 +00:00
test test/scheduler: Commonize collect_cpu_idle() 2021-10-27 08:47:51 +00:00
vfiouserbuild libvfio-user: include libvfio-user as a submodule with SPDK 2021-01-21 05:00:18 +00:00
.astylerc astyle: change "add-braces" to "j" for compatibility 2017-12-13 21:23:27 -05:00
.gitignore add .gitreview to .gitignore 2020-10-12 08:26:27 +00:00
.gitmodules libvfio-user: include libvfio-user as a submodule with SPDK 2021-01-21 05:00:18 +00:00
autobuild.sh autobuild: Update patches for mainline DPDK 2021-07-27 07:54:48 +00:00
autopackage.sh autopackage: Make lto build dependent only on RUN_NIGHTLY flag 2021-05-10 10:45:57 +00:00
autorun_post.py post_process: clearly delineate the beginning os script output. 2020-06-17 07:21:44 +00:00
autorun.sh autorun: allow pass configuration file path 2021-03-05 08:01:45 +00:00
autotest.sh autotest: Don't run spdk_dd tests under crypto job 2021-10-27 08:47:51 +00:00
CHANGELOG.md SPDK 21.01.2-pre 2021-03-10 16:22:10 +00:00
CONFIG nvmf/vfio_user: disable vfio_user by default 2021-01-29 17:06:10 +00:00
configure nvmf/vfio_user: disable vfio_user by default 2021-01-29 17:06:10 +00:00
CONTRIBUTING.md Add CONTRIBUTING.md 2017-09-05 13:25:45 -04:00
LICENSE Remove year from copyright headers. 2016-01-28 08:54:18 -07:00
Makefile build: generate pkg-config files for SPDK 2021-01-21 09:46:32 +00:00
README.md readme: add dpdk shared library note to LD_LIBRARY_PATH 2020-10-01 07:12:46 +00:00

Storage Performance Development Kit

Build Status

The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for writing high performance, scalable, user-mode storage applications. It achieves high performance by moving all of the necessary drivers into userspace and operating in a polled mode instead of relying on interrupts, which avoids kernel context switches and eliminates interrupt handling overhead.

The development kit currently includes:

In this readme

Documentation

Doxygen API documentation is available, as well as a Porting Guide for porting SPDK to different frameworks and operating systems.

Source Code

git clone https://github.com/spdk/spdk
cd spdk
git submodule update --init

Prerequisites

The dependencies can be installed automatically by scripts/pkgdep.sh. The scripts/pkgdep.sh script will automatically install the bare minimum dependencies required to build SPDK. Use --help to see information on installing dependencies for optional components

./scripts/pkgdep.sh

Build

Linux:

./configure
make

FreeBSD: Note: Make sure you have the matching kernel source in /usr/src/ and also note that CONFIG_COVERAGE option is not available right now for FreeBSD builds.

./configure
gmake

Unit Tests

./test/unit/unittest.sh

You will see several error messages when running the unit tests, but they are part of the test suite. The final message at the end of the script indicates success or failure.

Vagrant

A Vagrant setup is also provided to create a Linux VM with a virtual NVMe controller to get up and running quickly. Currently this has been tested on MacOS, Ubuntu 16.04.2 LTS and Ubuntu 18.04.3 LTS with the VirtualBox and Libvirt provider. The VirtualBox Extension Pack or [Vagrant Libvirt] (https://github.com/vagrant-libvirt/vagrant-libvirt) must also be installed in order to get the required NVMe support.

Details on the Vagrant setup can be found in the SPDK Vagrant documentation.

AWS

The following setup is known to work on AWS: Image: Ubuntu 18.04 Before running setup.sh, run modprobe vfio-pci then: DRIVER_OVERRIDE=vfio-pci ./setup.sh

Advanced Build Options

Optional components and other build-time configuration are controlled by settings in the Makefile configuration file in the root of the repository. CONFIG contains the base settings for the configure script. This script generates a new file, mk/config.mk, that contains final build settings. For advanced configuration, there are a number of additional options to configure that may be used, or mk/config.mk can simply be created and edited by hand. A description of all possible options is located in CONFIG.

Boolean (on/off) options are configured with a 'y' (yes) or 'n' (no). For example, this line of CONFIG controls whether the optional RDMA (libibverbs) support is enabled:

CONFIG_RDMA?=n

To enable RDMA, this line may be added to mk/config.mk with a 'y' instead of 'n'. For the majority of options this can be done using the configure script. For example:

./configure --with-rdma

Additionally, CONFIG options may also be overridden on the make command line:

make CONFIG_RDMA=y

Users may wish to use a version of DPDK different from the submodule included in the SPDK repository. Note, this includes the ability to build not only from DPDK sources, but also just with the includes and libraries installed via the dpdk and dpdk-devel packages. To specify an alternate DPDK installation, run configure with the --with-dpdk option. For example:

Linux:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-linuxapp-gcc
make

FreeBSD:

./configure --with-dpdk=/path/to/dpdk/x86_64-native-bsdapp-clang
gmake

The options specified on the make command line take precedence over the values in mk/config.mk. This can be useful if you, for example, generate a mk/config.mk using the configure script and then have one or two options (i.e. debug builds) that you wish to turn on and off frequently.

Shared libraries

By default, the build of the SPDK yields static libraries against which the SPDK applications and examples are linked. Configure option --with-shared provides the ability to produce SPDK shared libraries, in addition to the default static ones. Use of this flag also results in the SPDK executables linked to the shared versions of libraries. SPDK shared libraries by default, are located in ./build/lib. This includes the single SPDK shared lib encompassing all of the SPDK static libs (libspdk.so) as well as individual SPDK shared libs corresponding to each of the SPDK static ones.

In order to start a SPDK app linked with SPDK shared libraries, make sure to do the following steps:

  • run ldconfig specifying the directory containing SPDK shared libraries
  • provide proper LD_LIBRARY_PATH

If DPDK shared libraries are used, you may also need to add DPDK shared libraries to LD_LIBRARY_PATH

Linux:

./configure --with-shared
make
ldconfig -v -n ./build/lib
LD_LIBRARY_PATH=./build/lib/:./dpdk/build/lib/ ./build/bin/spdk_tgt

Hugepages and Device Binding

Before running an SPDK application, some hugepages must be allocated and any NVMe and I/OAT devices must be unbound from the native kernel drivers. SPDK includes a script to automate this process on both Linux and FreeBSD. This script should be run as root.

sudo scripts/setup.sh

Users may wish to configure a specific memory size. Below is an example of configuring 8192MB memory.

sudo HUGEMEM=8192 scripts/setup.sh

Example Code

Example code is located in the examples directory. The examples are compiled automatically as part of the build process. Simply call any of the examples with no arguments to see the help output. You'll likely need to run the examples as a privileged user (root) unless you've done additional configuration to grant your user permission to allocate huge pages and map devices through vfio.

Contributing

For additional details on how to get more involved in the community, including contributing code and participating in discussions and other activities, please refer to spdk.io