numam-spdk/lib/scsi/dev.c
Shuhei Matsumoto ab808d2b68 lib/scsi: Pass bdev_name instead of bdev to scsi_lun_construct()
Pass not bdev but bdev_name to scsi_lun_construct() to fix the
race condition due to the time gap between spdk_bdev_get_by_name()
and spdk_bdev_open(). A pointer to a bdev is valid only while the
bdev is opened.

spdk_bdev_open() has been replaced recently by spdk_bdev_open_ext(),
but the issue still existed.

Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Ic462422dbc2501c24907f56a36570fbb54fef65b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4482
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2020-10-08 13:11:15 +00:00

455 lines
9.6 KiB
C

/*-
* BSD LICENSE
*
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "scsi_internal.h"
static struct spdk_scsi_dev g_devs[SPDK_SCSI_MAX_DEVS];
struct spdk_scsi_dev *
scsi_dev_get_list(void)
{
return g_devs;
}
static struct spdk_scsi_dev *
allocate_dev(void)
{
struct spdk_scsi_dev *dev;
int i;
for (i = 0; i < SPDK_SCSI_MAX_DEVS; i++) {
dev = &g_devs[i];
if (!dev->is_allocated) {
memset(dev, 0, sizeof(*dev));
dev->id = i;
dev->is_allocated = 1;
return dev;
}
}
return NULL;
}
static void
free_dev(struct spdk_scsi_dev *dev)
{
assert(dev->is_allocated == 1);
assert(dev->removed == true);
dev->is_allocated = 0;
if (dev->remove_cb) {
dev->remove_cb(dev->remove_ctx, 0);
dev->remove_cb = NULL;
}
}
void
spdk_scsi_dev_destruct(struct spdk_scsi_dev *dev,
spdk_scsi_dev_destruct_cb_t cb_fn, void *cb_arg)
{
int lun_cnt;
int i;
if (dev == NULL) {
if (cb_fn) {
cb_fn(cb_arg, -EINVAL);
}
return;
}
if (dev->removed) {
if (cb_fn) {
cb_fn(cb_arg, -EINVAL);
}
return;
}
dev->removed = true;
dev->remove_cb = cb_fn;
dev->remove_ctx = cb_arg;
lun_cnt = 0;
for (i = 0; i < SPDK_SCSI_DEV_MAX_LUN; i++) {
if (dev->lun[i] == NULL) {
continue;
}
/*
* LUN will remove itself from this dev when all outstanding IO
* is done. When no more LUNs, dev will be deleted.
*/
scsi_lun_destruct(dev->lun[i]);
lun_cnt++;
}
if (lun_cnt == 0) {
free_dev(dev);
return;
}
}
static int
scsi_dev_find_lowest_free_lun_id(struct spdk_scsi_dev *dev)
{
int i;
for (i = 0; i < SPDK_SCSI_DEV_MAX_LUN; i++) {
if (dev->lun[i] == NULL) {
return i;
}
}
return -1;
}
int
spdk_scsi_dev_add_lun(struct spdk_scsi_dev *dev, const char *bdev_name, int lun_id,
void (*hotremove_cb)(const struct spdk_scsi_lun *, void *),
void *hotremove_ctx)
{
return spdk_scsi_dev_add_lun_ext(dev, bdev_name, lun_id,
NULL, NULL,
hotremove_cb, hotremove_ctx);
}
int
spdk_scsi_dev_add_lun_ext(struct spdk_scsi_dev *dev, const char *bdev_name, int lun_id,
void (*resize_cb)(const struct spdk_scsi_lun *, void *),
void *resize_ctx,
void (*hotremove_cb)(const struct spdk_scsi_lun *, void *),
void *hotremove_ctx)
{
struct spdk_scsi_lun *lun;
/* Search the lowest free LUN ID if LUN ID is default */
if (lun_id == -1) {
lun_id = scsi_dev_find_lowest_free_lun_id(dev);
if (lun_id == -1) {
SPDK_ERRLOG("Free LUN ID is not found\n");
return -1;
}
}
lun = scsi_lun_construct(bdev_name, resize_cb, resize_ctx, hotremove_cb, hotremove_ctx);
if (lun == NULL) {
return -1;
}
lun->id = lun_id;
lun->dev = dev;
dev->lun[lun_id] = lun;
return 0;
}
void
spdk_scsi_dev_delete_lun(struct spdk_scsi_dev *dev,
struct spdk_scsi_lun *lun)
{
int lun_cnt = 0;
int i;
for (i = 0; i < SPDK_SCSI_DEV_MAX_LUN; i++) {
if (dev->lun[i] == lun) {
dev->lun[i] = NULL;
}
if (dev->lun[i]) {
lun_cnt++;
}
}
if (dev->removed == true && lun_cnt == 0) {
free_dev(dev);
}
}
struct spdk_scsi_dev *spdk_scsi_dev_construct(const char *name, const char *bdev_name_list[],
int *lun_id_list, int num_luns, uint8_t protocol_id,
void (*hotremove_cb)(const struct spdk_scsi_lun *, void *),
void *hotremove_ctx)
{
return spdk_scsi_dev_construct_ext(name, bdev_name_list, lun_id_list,
num_luns, protocol_id,
NULL, NULL,
hotremove_cb, hotremove_ctx);
}
struct spdk_scsi_dev *spdk_scsi_dev_construct_ext(const char *name, const char *bdev_name_list[],
int *lun_id_list, int num_luns, uint8_t protocol_id,
void (*resize_cb)(const struct spdk_scsi_lun *, void *),
void *resize_ctx,
void (*hotremove_cb)(const struct spdk_scsi_lun *, void *),
void *hotremove_ctx)
{
struct spdk_scsi_dev *dev;
size_t name_len;
bool found_lun_0;
int i, rc;
name_len = strlen(name);
if (name_len > sizeof(dev->name) - 1) {
SPDK_ERRLOG("device %s: name longer than maximum allowed length %zu\n",
name, sizeof(dev->name) - 1);
return NULL;
}
if (num_luns == 0) {
SPDK_ERRLOG("device %s: no LUNs specified\n", name);
return NULL;
}
found_lun_0 = false;
for (i = 0; i < num_luns; i++) {
if (lun_id_list[i] == 0) {
found_lun_0 = true;
break;
}
}
if (!found_lun_0) {
SPDK_ERRLOG("device %s: no LUN 0 specified\n", name);
return NULL;
}
for (i = 0; i < num_luns; i++) {
if (bdev_name_list[i] == NULL) {
SPDK_ERRLOG("NULL spdk_scsi_lun for LUN %d\n",
lun_id_list[i]);
return NULL;
}
}
dev = allocate_dev();
if (dev == NULL) {
return NULL;
}
memcpy(dev->name, name, name_len + 1);
dev->num_ports = 0;
dev->protocol_id = protocol_id;
for (i = 0; i < num_luns; i++) {
rc = spdk_scsi_dev_add_lun_ext(dev, bdev_name_list[i], lun_id_list[i],
resize_cb, resize_ctx,
hotremove_cb, hotremove_ctx);
if (rc < 0) {
spdk_scsi_dev_destruct(dev, NULL, NULL);
return NULL;
}
}
return dev;
}
void
spdk_scsi_dev_queue_mgmt_task(struct spdk_scsi_dev *dev,
struct spdk_scsi_task *task)
{
assert(task != NULL);
scsi_lun_execute_mgmt_task(task->lun, task);
}
void
spdk_scsi_dev_queue_task(struct spdk_scsi_dev *dev,
struct spdk_scsi_task *task)
{
assert(task != NULL);
scsi_lun_execute_task(task->lun, task);
}
static struct spdk_scsi_port *
scsi_dev_find_free_port(struct spdk_scsi_dev *dev)
{
int i;
for (i = 0; i < SPDK_SCSI_DEV_MAX_PORTS; i++) {
if (!dev->port[i].is_used) {
return &dev->port[i];
}
}
return NULL;
}
int
spdk_scsi_dev_add_port(struct spdk_scsi_dev *dev, uint64_t id, const char *name)
{
struct spdk_scsi_port *port;
int rc;
if (dev->num_ports == SPDK_SCSI_DEV_MAX_PORTS) {
SPDK_ERRLOG("device already has %d ports\n", SPDK_SCSI_DEV_MAX_PORTS);
return -1;
}
port = spdk_scsi_dev_find_port_by_id(dev, id);
if (port != NULL) {
SPDK_ERRLOG("device already has port(%" PRIu64 ")\n", id);
return -1;
}
port = scsi_dev_find_free_port(dev);
if (port == NULL) {
assert(false);
return -1;
}
rc = scsi_port_construct(port, id, dev->num_ports, name);
if (rc != 0) {
return rc;
}
dev->num_ports++;
return 0;
}
int
spdk_scsi_dev_delete_port(struct spdk_scsi_dev *dev, uint64_t id)
{
struct spdk_scsi_port *port;
port = spdk_scsi_dev_find_port_by_id(dev, id);
if (port == NULL) {
SPDK_ERRLOG("device does not have specified port(%" PRIu64 ")\n", id);
return -1;
}
scsi_port_destruct(port);
dev->num_ports--;
return 0;
}
struct spdk_scsi_port *
spdk_scsi_dev_find_port_by_id(struct spdk_scsi_dev *dev, uint64_t id)
{
int i;
for (i = 0; i < SPDK_SCSI_DEV_MAX_PORTS; i++) {
if (!dev->port[i].is_used) {
continue;
}
if (dev->port[i].id == id) {
return &dev->port[i];
}
}
/* No matching port found. */
return NULL;
}
void
spdk_scsi_dev_free_io_channels(struct spdk_scsi_dev *dev)
{
int i;
for (i = 0; i < SPDK_SCSI_DEV_MAX_LUN; i++) {
if (dev->lun[i] == NULL) {
continue;
}
scsi_lun_free_io_channel(dev->lun[i]);
}
}
int
spdk_scsi_dev_allocate_io_channels(struct spdk_scsi_dev *dev)
{
int i, rc;
for (i = 0; i < SPDK_SCSI_DEV_MAX_LUN; i++) {
if (dev->lun[i] == NULL) {
continue;
}
rc = scsi_lun_allocate_io_channel(dev->lun[i]);
if (rc < 0) {
spdk_scsi_dev_free_io_channels(dev);
return -1;
}
}
return 0;
}
const char *
spdk_scsi_dev_get_name(const struct spdk_scsi_dev *dev)
{
return dev->name;
}
int
spdk_scsi_dev_get_id(const struct spdk_scsi_dev *dev)
{
return dev->id;
}
struct spdk_scsi_lun *
spdk_scsi_dev_get_lun(struct spdk_scsi_dev *dev, int lun_id)
{
struct spdk_scsi_lun *lun;
if (lun_id < 0 || lun_id >= SPDK_SCSI_DEV_MAX_LUN) {
return NULL;
}
lun = dev->lun[lun_id];
if (lun != NULL && !spdk_scsi_lun_is_removing(lun)) {
return lun;
} else {
return NULL;
}
}
bool
spdk_scsi_dev_has_pending_tasks(const struct spdk_scsi_dev *dev,
const struct spdk_scsi_port *initiator_port)
{
int i;
for (i = 0; i < SPDK_SCSI_DEV_MAX_LUN; ++i) {
if (dev->lun[i] &&
(scsi_lun_has_pending_tasks(dev->lun[i], initiator_port) ||
scsi_lun_has_pending_mgmt_tasks(dev->lun[i], initiator_port))) {
return true;
}
}
return false;
}