Jessica Clarke
a34d3ca6ef
re: Avoid subobject overread when setting IDRn ...
IDR0-IDR5 can be read byte-by-byte but must be written to as 4-byte
words. The current code to do this is rather clunky and ends up reading
past the end of the union's eaddr member due to MAC addresses only being
6 bytes. In practice this ends up being fine because the align_dummy
member will pad the union to a multiple of 4 bytes, but this is dodgy,
and on CHERI with subobject bounds enforcement enabled, as is done in
CheriBSD's pure-capability kernel, will trap.
Instead, make the buffer in use the right size, just use an array of
uint32_t's rather than a char buffer that's then cast to uint32_t * to
simplify it in the process, and zero-initialise it first to avoid
reading uninitialised data in the trailing bytes.
Found by: CHERI
Reviewed by: jhb
Differential Revision: https://reviews.freebsd.org/D33617
2021-12-23 20:19:31 +00:00
2021-12-09 17:04:45 -07:00
2021-06-21 15:13:13 -03:00
2020-12-23 11:10:53 +03:00
2021-12-09 20:08:25 -05:00
2020-09-01 21:34:24 +00:00
2020-09-01 21:34:41 +00:00
2020-09-01 21:34:58 +00:00
2020-09-01 21:35:14 +00:00
2021-11-25 11:36:33 -05:00
2021-12-17 15:34:43 -05:00
2021-12-09 21:36:21 -05:00
2021-04-12 09:32:02 -04:00
2021-12-10 11:48:42 +00:00
2020-09-01 21:37:53 +00:00
2020-09-01 21:38:06 +00:00
2020-09-01 21:38:18 +00:00
2021-11-24 16:25:50 +00:00
2020-09-01 21:39:19 +00:00
2020-09-01 21:39:19 +00:00
2021-12-13 13:36:50 +02:00
2020-09-01 21:39:19 +00:00
2020-12-12 19:34:12 +00:00
2021-12-09 16:37:26 +00:00
2021-12-13 08:09:15 -08:00
2021-12-10 11:45:36 +00:00
2021-12-14 16:53:09 -07:00
2021-05-22 21:23:00 -07:00
2021-09-10 00:37:40 +03:00
2021-07-13 14:38:31 +00:00
2020-10-02 18:18:01 +00:00
2021-12-02 14:45:04 -08:00
2021-11-25 22:50:42 +00:00
2021-12-10 12:02:05 +00:00
2021-12-03 23:29:51 -07:00
2021-12-14 14:59:09 +00:00
2021-09-03 13:51:08 -04:00
2020-09-07 15:35:40 +00:00
2020-09-24 10:57:39 +00:00
2021-12-10 12:19:16 +00:00
2021-07-21 02:51:25 +01:00
2021-12-09 17:04:45 -07:00
2020-02-11 18:57:07 +00:00
2021-10-22 11:41:36 -07:00
2021-10-05 12:17:10 +00:00
2020-09-01 22:10:24 +00:00
2020-09-01 22:10:34 +00:00
2019-11-03 20:39:46 +00:00
2021-11-25 03:33:39 +00:00
2021-09-24 23:31:51 -04:00
2021-10-22 11:41:36 -07:00
2020-09-01 22:11:22 +00:00
2021-12-14 09:49:17 -08:00
2021-11-18 23:05:32 -07:00
2021-12-21 12:33:26 -08:00
2021-09-02 22:35:26 +03:00
2020-02-03 17:35:11 +00:00
2020-02-26 14:26:36 +00:00
2020-02-25 22:03:30 +00:00
2021-12-09 17:04:45 -07:00
2021-04-27 19:07:33 +02:00
2021-01-13 18:43:51 +01:00
2021-12-08 08:55:40 +00:00
2021-09-07 11:19:29 -04:00
2021-09-16 16:47:45 +02:00
2021-12-22 10:01:54 +01:00
2021-12-09 16:37:26 +00:00
2021-11-24 07:40:37 +01:00
2021-10-02 10:43:41 +02:00
2019-12-16 21:35:02 +00:00
2021-10-16 08:09:31 +02:00
2021-12-06 11:28:01 +01:00
2021-11-25 11:25:11 +00:00
2021-09-20 17:17:57 +02:00
2020-07-01 00:33:16 +00:00
2021-01-12 13:16:10 +00:00
2021-12-20 11:24:21 +00:00
2021-12-07 07:13:53 +01:00
2020-11-28 22:34:33 +00:00
2021-12-09 21:16:16 -05:00
2020-02-03 17:35:11 +00:00
2019-12-13 19:39:33 +00:00
2021-07-26 16:41:05 -04:00
2020-07-26 18:15:16 +00:00
2021-11-30 15:18:01 -07:00
2020-06-10 21:38:35 +00:00
2021-12-18 21:31:03 +01:00
2021-04-12 14:28:43 -07:00
2021-12-09 20:24:29 -05:00
2021-12-09 20:35:21 -05:00
2021-12-04 11:07:04 -07:00
2021-05-21 08:53:59 +01:00
2021-05-21 08:53:59 +01:00
2021-11-25 19:26:04 -05:00
2021-12-14 16:53:09 -07:00
2021-12-03 12:02:42 -08:00
2021-11-25 00:45:12 -07:00
2021-11-23 14:09:29 -08:00
2021-11-24 20:15:02 -05:00
2021-11-24 13:07:58 -05:00
2021-08-26 12:04:28 +02:00
2021-12-16 13:23:30 +00:00
2021-11-18 23:22:12 -07:00
2021-12-19 12:05:52 +02:00
2021-04-14 13:15:19 +03:00
2020-02-13 19:09:24 +00:00
2021-12-09 20:21:16 +00:00
2021-10-21 21:40:46 +03:00
2021-09-14 21:06:39 -04:00
2020-02-07 09:22:08 +00:00
2020-02-26 14:26:36 +00:00
2021-11-19 19:29:21 +01:00
2021-11-05 16:38:25 -07:00
2021-11-15 14:04:08 +08:00
2020-02-26 14:26:36 +00:00
2020-03-24 18:35:33 +00:00
2021-12-14 13:26:44 -05:00
2020-11-20 01:15:48 +00:00
2019-10-16 14:57:38 +00:00
2020-02-26 14:26:36 +00:00
2021-12-14 17:06:56 +00:00
2021-06-06 16:44:47 -04:00
2021-11-03 16:16:20 +01:00
2021-11-24 11:54:08 -08:00
2020-08-31 15:03:23 +00:00
2020-02-26 14:26:36 +00:00
2021-06-06 16:44:46 -04:00
2021-08-08 18:29:48 -04:00
2020-09-18 16:48:08 +00:00
2021-11-16 10:27:27 -08:00
2020-02-07 19:53:07 +00:00
2019-10-21 18:07:11 +00:00
2021-08-14 08:55:58 +02:00
2020-09-24 10:57:39 +00:00
2021-11-03 16:20:11 +01:00
2021-11-25 22:50:42 +00:00
2020-04-06 05:48:58 +00:00
2020-11-19 03:59:21 +00:00
2021-12-09 17:04:45 -07:00
2021-11-23 20:56:53 -05:00
2021-09-03 12:15:39 -04:00
2021-12-09 17:04:57 -07:00
2021-12-09 17:04:45 -07:00
2021-11-18 23:22:12 -07:00
2021-12-09 17:04:45 -07:00
2021-11-29 17:02:01 +01:00
2021-11-30 10:40:50 +01:00
2021-12-02 14:45:04 -08:00
2021-08-10 20:44:27 -04:00
2021-12-04 00:08:27 -07:00
2020-02-26 14:26:36 +00:00
2021-07-28 13:28:29 +02:00
2021-06-22 20:52:06 -06:00
2021-12-15 12:35:38 +00:00
2020-12-16 00:17:54 +00:00
2020-09-01 22:05:21 +00:00
2019-10-22 14:20:35 +00:00
2021-12-03 11:06:58 +01:00
2021-09-26 13:56:33 +00:00
2021-12-10 11:53:38 +00:00
2020-09-01 22:04:24 +00:00
2021-08-28 19:24:27 +02:00
2021-01-04 13:18:47 +00:00
2021-09-27 12:13:03 -07:00
2020-09-01 22:03:46 +00:00
2021-12-06 10:23:40 -07:00
2021-06-22 20:52:06 -06:00
2021-12-06 10:23:40 -07:00
2020-09-01 22:02:55 +00:00
2021-12-18 23:43:00 +01:00
2021-12-21 12:41:51 +05:30
2021-11-15 13:01:30 -05:00
2020-09-07 15:35:40 +00:00
2021-06-22 20:52:06 -06:00
2021-08-26 11:00:39 +02:00
2020-09-01 22:01:17 +00:00
2021-12-14 15:27:47 -07:00
2021-01-07 17:05:30 -07:00
2020-09-01 22:00:30 +00:00
2021-12-09 17:04:45 -07:00
2021-08-14 08:55:58 +02:00
2020-09-01 21:59:31 +00:00
2021-11-19 19:19:36 +01:00
2020-09-01 21:58:56 +00:00
2020-09-01 21:58:40 +00:00
2020-09-01 21:58:29 +00:00
2020-09-01 21:58:12 +00:00
2021-06-22 20:52:06 -06:00
2021-06-22 20:52:06 -06:00
2021-12-17 13:10:22 -05:00
2021-11-04 09:02:27 -07:00
2021-12-23 10:41:41 -08:00
2021-11-18 23:05:32 -07:00
2020-09-01 21:57:15 +00:00
2020-09-01 21:56:55 +00:00
2020-09-01 21:56:30 +00:00
2019-12-01 20:43:37 +00:00
2021-12-14 14:24:21 +00:00
2021-11-16 10:27:27 -08:00
2021-12-23 20:19:31 +00:00
2020-10-05 19:58:55 +00:00
2020-09-01 21:55:52 +00:00
2021-09-03 18:10:06 -04:00
2021-09-09 14:26:17 -04:00
2021-12-06 09:43:26 +02:00
2021-04-12 14:28:43 -07:00
2021-12-18 13:29:32 +00:00
2020-09-01 21:54:35 +00:00
2020-12-26 13:48:06 +01:00
2021-12-14 14:08:35 +00:00
2021-12-09 17:04:45 -07:00
2021-05-25 16:59:18 -07:00
2021-09-04 12:56:57 +02:00
2019-10-21 18:07:40 +00:00
2021-06-22 20:52:06 -06:00
2021-12-14 14:31:10 +00:00
2021-12-14 14:08:17 +00:00
2021-06-28 16:13:03 -06:00
2021-04-07 15:05:49 -05:00
2021-06-22 20:52:06 -06:00
2020-09-01 21:52:46 +00:00
2019-11-29 03:51:01 +00:00
2021-12-22 10:18:35 +01:00
2020-08-28 16:40:33 +00:00
2021-06-22 20:52:06 -06:00
2020-02-26 14:26:36 +00:00
2020-09-01 21:52:20 +00:00
2020-08-30 07:34:32 +00:00
2021-06-22 20:52:06 -06:00
2021-12-03 15:18:39 -07:00
2021-12-06 11:27:59 +01:00
2020-09-01 21:51:38 +00:00
2021-01-12 13:16:10 +00:00
2019-12-23 21:46:48 +00:00
2021-12-03 15:31:14 -07:00
2021-08-16 06:28:33 +02:00
2020-09-01 21:50:21 +00:00
2021-12-09 17:04:45 -07:00
2021-12-03 15:40:29 -07:00
2021-09-30 14:16:19 -06:00
2021-12-18 21:31:58 +01:00
2021-11-25 22:50:42 +00:00
2020-09-01 21:49:49 +00:00
2020-09-01 21:49:31 +00:00
2021-12-09 18:09:53 +00:00
2021-12-14 14:38:42 +00:00
2020-09-01 21:48:55 +00:00
2021-09-02 22:25:16 -04:00
2020-01-01 00:35:02 +00:00
2021-12-14 14:12:35 +00:00
2021-10-02 10:47:21 +02:00
2021-08-28 19:24:27 +02:00
2021-12-06 11:28:03 +01:00
2020-02-26 14:26:36 +00:00
2020-09-01 21:47:20 +00:00
2021-12-09 21:13:10 -05:00
2021-09-10 10:03:51 -04:00
2020-09-07 15:35:40 +00:00
2021-12-10 05:06:54 +00:00
2021-12-15 13:46:17 +00:00
2020-09-08 13:21:13 +00:00
2020-02-11 18:57:07 +00:00
a34d3ca6ef