Restructure spx_attach() to properly free memory in the event that one
of its allocations fails. Allocate the ipxp last so as to avoid having
to free it if another allocation goes wrong.
Normalize retrieval of ipxp and cb from socket in spx_sp_attach(), and
add assertions.
In spx_ctloutput(), acquire the ipxp lock around read operations,
especially reads of spx header structures, which will now be cached
in the stack until they can be copied out after releasing the lock.
Panic if a bad socket option direction is passed in by the caller.
Clean up and style(9) SPX code prior to significant functional changes
being committed:
- Wrap comments more evenly on right border.
- Clean up braces.
Also, along similar lines:
- Assert some pointers are non-NULL before dereferencing them.
- Remove one assertion that looks, on face value, poor.
Admit to ourselves that we don't actually implement pr_ctlinput() for
IPX or SPX, as the code in the implementing functions is essentially
a no-op. Replace with a comment indicating we don't implement these
currently.
In spx_attach() and spx_detach(), there is no need to check whether the
ipxpcb is NULL or not: in attach it will be, and on detach it won't be.
If for any reason these invariants don't hold true, panicking is a good
idea.
Noticed by: Coverity Prevent analysis tool
Comment that raw output filter code for IPX should run in a netisr so as
to avoid recursing the socket code, as this input path can run in the
call stack of an output path.
Move spx_savesi from being a global variable to an automatically allocated
variable on the spx_input() stack. It's not very large, and this will
avoid parallelism issues when spx_input() runs in more than one thread at
a time.
sysctl_ctx_init.9 from HEAD to RELENG_6:
Add a basic man page for the sysctl(9) macro interfaces. Previously man
pages existed only for the dynamic sysctl interfaces. There's probably
more complete and accurate content, better advice, etc, that could be
added here.
Per scottl's suggest, add a small piece of moralizing text regarding the
fact that sysctl names quickly get embedded in system configuration files,
libraries, third party applications, and even books, so renaming and
removing names after they've been published is a tricky issue.
--
Fix typo.
Submitted by: Antoine Brodin <antoine dot brodin@laposte dot net>
--
Fix a couple of typos and other minor nits
Reviewed by: rwatson
Adjust minimum iod threads from 4 to 0 -- since we compile the NFS
client into the kernel by default, and many users won't use NFS,
don't start an extra 4 kernel threads that are unused. Once NFS
becomes active, it will start nfsiod's as it needs them.
We might consider mandating a minimum iod's equal to the number of
active NFS mounts (truncated to some value), which would force some
to remain available without having to create a new one if the file
system is mostly inactive.
PR: 70880
Prodded by: cel
Head nod: peter
Pointed out by: Joe <fbsd_user at a1poweruser dot com>
- Document the new Read_Node_List command, autodetection of HCI nodes and
that the '-n' parameter is now optional
- Grammar fixes
Approved by: emax (mentor)
- Add HCI node autodetection. As a consequence of this, make the '-n'
parameter optional.
- Add Read_Node_List command which prints a list of available HCI nodes,
their Netgraph IDs and connected hooks
Revisions:
hccontrol.h rev. 1.6
hccontrol.c rev. 1.4 + 1.5
node.c rev. 1.4
Approved by: emax (mentor)
sys/sparc64/sparc64/trap.c 1.80 (partial)
- s,tramoline,trampoline, in a comment.
- Use FBSDID in trap.c
- Make the global trap_sig[] static as it's not used outside of trap.c.
- Sync cpu_thread_siginfo() and sendsig() with the other archs; for fast
data access MMU miss and data access protection traps set ksi_addr to
the SFAR reg which contains the faulting address and otherwise to the
TPC reg. Generally the TCP reg contains the address of the instruction
that caused the exception, except for fast instruction access traps
(and some others; more refinement may be needed here) it also contains
the faulting address.
Previously, sendsig() always set si_addr to the SFAR reg which is wrong
for most traps and cpu_thread_siginfo() didn't set it at all.
- In sendsig() add support for FreeBSD old-style signals.
- Set a two read-only variables (${prefix} and ${etcdir}). This is
especially useful when using /etc/rc.d scripts with third-party
software installed from ports.
- Fix rc.d/sshd to work with openssh from ports using ${etcdir}
instead of hardcoded /etc.
- Reflect prefix/etcdir changes in rc.subr.8.
src/etc/rc.d/sshd: rev 1.9 -> 1.10
src/etc/rc.subr: rev 1.51 -> 1.52
src/share/man/man8/rc.subr.8: rev 1.11 -> 1.12
Revert the (int *) -> (intptr_t *) conversion done as part of rev. 1.59
(MFC'ed in rev. 1.55.2.3) for IOCTLs where casting data to intptr_t *
isn't the right thing to do, fixing tap(4) on big-endian LP64 machines.
- Change the "jail_" prefix for internal script variables. This fixes an
issue where some global jail_* variables were overriden in the script. [1]
- Change "jid" to "jname" in rc.conf(5), since it's more a jail name than a
jail id. [1]
- Update examples and comments in defaults/rc.conf to advertise new
variables and the fact that some of the jail-specific variables may be made
jail-global. [2]
src/share/man/man5/rc.conf.5: rev 1.293 -> 1.294
src/etc/rc.d/jail: rev 1.31 -> 1.32
src/etc/defaults/rc.conf: rev 1.282 -> 1.283
Reported by: pjd [1], clsung [2]
- Add new ntpd_config variable so that people can override it in rc.conf.
- Add default value in /etc/defaults/rc.conf.
- Add documentation bits to rc.conf(5).
src/etc/rc.d/ntpd: rev 1.12 -> 1.13
src/share/man/man5/rc.conf.5: rev 1.292 -> 1.293
src/etc/defaults/rc.conf: rev 1.280 -> 1.281
Make this example more real world usable: When the manpage first appeared
is not interesting, when the driver appeared is. Most people who use this
example leave the manpage appearance date in and the driver date out.
> date: 2006/01/30 14:24:31; author: kensmith; state: Exp; lines: +1 -0
> Enable splitting up the MFSROOT floppy on amd64, the contents now overflow
> one floppy's worth of space.
Note that this is not the exact right place for this code since it runs
a little earlier than the normal reset SYSINIT. However, it appears to
work fine and can be backed out if it causes problems.
to, so don't try.
The PR indicates that NO_BIND_NAMED would also trigger this problem, but
I was unable to reproduce it.
This is going directly to RELENG_6 because testing shows that HEAD is not
affected by this issue, likely due to the renovation of the make knobs
in that branch.
PR: misc/97188
Submitted by: Peter Losher <Peter_Losher@isc.org>
showing lockmgr) encountered with "make -jX release" for X > 1
and running on SMP hardware are gone once PREEMPTION is disabled.
Better ideas on fixing the problem are more than welcome.
